Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1558312 - Review Request: etherwallet - Client-side tool for interacting with the Ethereum network
Summary: Review Request: etherwallet - Client-side tool for interacting with the Ether...
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: FE-NEEDSPONSOR FE-DEADREVIEW
TreeView+ depends on / blocked
 
Reported: 2018-03-20 02:27 UTC by Rene Jr Purcell
Modified: 2020-08-10 00:57 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-08-10 00:57:46 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Rene Jr Purcell 2018-03-20 02:27:14 UTC
Spec URL: https://copr-be.cloud.fedoraproject.org/results/arsenick/MyLiveCrypto/fedora-27-x86_64/00729766-etherwallet/mew.spec
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/arsenick/MyLiveCrypto/fedora-27-x86_64/00729766-etherwallet/etherwallet-3.20.03-1.fc27.src.rpm
Description: This is my first package I submit, I know there will be few/lot of things to fix, I'm here to learn! There's no binary, no real dependency other than a browser. The package install the files in /usr/share/mew/ and copy a .desktop file which open /usr/share/mew/index.html with xdg-open.

I haven't seen any specific rules where crypto currency wallet wouldn't be accepted in official repo but I think this could spark an interesting discussion as those tools are used with users private key, they could present a risk for the user, they have to trust the packager and the original project. 

I hope my spec file is not too ugly, Thanks
Fedora Account System Username: arsenick

Comment 1 Robert-André Mauchin 🐧 2018-03-20 11:53:13 UTC
Just a few preliminary remarks.

 - Not needed:
    - Group:
    - BuildRoot: %{_tmppath}/%{name}-v%{version}-root
    - %{__rm} -rf %{buildroot}
    - %clean
      %{__rm} -rf %{buildroot}
    - %defattr(-,root,root,-)

 - /usr/share/mew/ → %{_datadir}/mew/

 - Split the description lines to stay below 80 characters per line

 - No need to use macros for %{__install} and %{__cp}

 - Don't put this in the summary: Package maintained by Rene Jr Purcell.

 - Summary shouldn't end with a dot

 - The correct shorthand for MIT is MIT, not "MIT License". See https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#SoftwareLicenses for a list of valid licenses.

 - Don't depend on Firefox, let the user choose whatever browser they want

 - Latest version is v3.21.02

Comment 3 Rene Jr Purcell 2018-03-23 03:31:56 UTC
I've updated the spec file according to your comment on my other package: https://bugzilla.redhat.com/show_bug.cgi?id=1558976#c1

So the LICENSE.md file has been added and the changelog section of the spec file has been populated. There was a new release of the upstream today, it's now in sync with it.

Spec URL: https://copr-be.cloud.fedoraproject.org/results/arsenick/MyLiveCrypto/fedora-27-x86_64/00731471-etherwallet/mew.spec

SRPM URL: https://copr-be.cloud.fedoraproject.org/results/arsenick/MyLiveCrypto/fedora-27-x86_64/00731471-etherwallet/etherwallet-3.21.03-1.fc27.src.rpm

Comment 4 Robert-André Mauchin 🐧 2018-10-04 16:54:47 UTC
I'm sorry I have forgotten this review.

The problem I have with this is that you're distributing the end result instead of building from the source with gulp.

You might need to package some gulp dependencies yourself to get the whole pipeline (may take some work).

Comment 5 Rene Jr Purcell 2019-04-05 17:51:09 UTC
Hi Robert, I should have updated those request. I've talked with few helping folks on freenode after I posted those review request and they told me exactly the same thing as your last comment. I then realised there a load of dependency in there.. And I just can't build packages for all of those, if I remember it was like 200 nodejs dependency..

So I don't know if things has changed since but if I really need to build packages for every dependency than I will not have the time required to do this unfortunately..

Comment 6 Robert-André Mauchin 🐧 2019-04-05 20:24:51 UTC
Repost as is and I'll review the thingie.
Don't forget to add a Provides: bundled(jquery) = 1.12.3

Comment 7 Package Review 2020-07-10 00:56:31 UTC
This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time. We're sorry
it is taking so long. If you're still interested in packaging this software
into Fedora repositories, please respond to this comment clearing the
NEEDINFO flag.

You may want to update the specfile and the src.rpm to the latest version
available and to propose a review swap on Fedora devel mailing list to increase
chances to have your package reviewed. If this is your first package and you
need a sponsor, you may want to post some informal reviews. Read more at
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group.

Without any reply, this request will shortly be considered abandoned
and will be closed.
Thank you for your patience.

Comment 8 Package Review 2020-08-10 00:57:46 UTC
This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.


Note You need to log in before you can comment on or make changes to this bug.