Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1578726 - dbus-python FTBFS with Python 3.7
Summary: dbus-python FTBFS with Python 3.7
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: dbus-python
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Alternative GTK desktop environments
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1539950
Blocks: PYTHON37
TreeView+ depends on / blocked
 
Reported: 2018-05-16 09:56 UTC by Miro Hrončok
Modified: 2018-05-23 12:40 UTC (History)
11 users (show)

Fixed In Version: dbus-python-1.2.8-1.fc29
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-05-23 12:40:48 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)
build.log from copr (244.32 KB, text/plain)
2018-05-16 09:56 UTC, Miro Hrončok 		no flags Details
root.log from copr (68.25 KB, text/plain)
2018-05-16 09:57 UTC, Miro Hrončok 		no flags Details
build.log from copr with python3-build/test-suite.log (275.91 KB, text/plain)
2018-05-23 10:37 UTC, Miro Hrončok 		no flags Details
Show Obsolete (1) View All

Description Miro Hrončok 2018-05-16 09:56:18 UTC 
Created attachment 1437208 [details]
build.log from copr

I'm bootstrapping Python 3.7 in copr. dbus-python fails to build due to 3 failed tests:

FAIL: test/test-client.py
FAIL: test/test-p2p.py
FAIL: test/test-signals.py

Version-Release number: 1.2.4-13.fc29

Will attach build and root logs.
Comment 1 Miro Hrončok 2018-05-16 09:57:27 UTC 
Created attachment 1437209 [details]
root.log from copr
Comment 2 Miro Hrončok 2018-05-23 10:37:50 UTC 
Created attachment 1440545 [details]
build.log from copr with python3-build/test-suite.log

  File "../test/test-client.py", line 331
    for async in (True, False):
            ^
SyntaxError: invalid syntax

  File "/builddir/build/BUILD/dbus-python-1.2.4/python3-build/../test/test-service.py", line 278
    def AsynchronousMethod(self, async, fail, variant, return_cb, error_cb):
                                     ^
SyntaxError: invalid syntax


This is related to PEP 492 https://www.python.org/dev/peps/pep-0492/

async is now a keyword.
Comment 3 Miro Hrončok 2018-05-23 11:46:43 UTC 
The async thing is fixed in:

commit 2d5ccd0cb9e580732d0abfbf8a97b1bf779d2a9e
Author: Simon McVittie <smcv>
Date:   Mon Jan 29 10:30:43 2018 +0000

    Avoid using async keyword
    
    Signed-off-by: Simon McVittie <smcv>



This is included in 1.2.8.
Comment 4 Miro Hrončok 2018-05-23 12:02:55 UTC 
I confirm that 1.2.8 builds with CPython 3.7.
Comment 5 Miro Hrončok 2018-05-23 12:05:17 UTC 
https://src.fedoraproject.org/rpms/dbus-python/pull-request/3
Note You need to log in before you can comment on or make changes to this bug.