Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1583626 - python-twisted FTBFS with Python 3.7
Summary: python-twisted FTBFS with Python 3.7
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: python-twisted
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Thomas Vander Stichele
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PYTHON37
TreeView+ depends on / blocked
 
Reported: 2018-05-29 11:46 UTC by Miro Hrončok
Modified: 2023-09-12 01:28 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-06-13 14:14:51 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)
build.log from copr (719.83 KB, text/plain)
2018-05-29 11:46 UTC, Miro Hrončok 		no flags Details
root.log from copr (44.55 KB, text/plain)
2018-05-29 11:51 UTC, Miro Hrončok 		no flags Details
View All

Description Miro Hrončok 2018-05-29 11:46:40 UTC 
Created attachment 1445368 [details]
build.log from copr

Description of problem: python-twisted FTBFS with Python 3.7 bacuse it uses async (now a keyword) as a function parameter name.

Bytecompiling .py files below /builddir/build/BUILDROOT/python-twisted-16.4.1-9.fc29.x86_64/usr/lib64/python3.7 using /usr/bin/python3.7
*** Error compiling '/builddir/build/BUILDROOT/python-twisted-16.4.1-9.fc29.x86_64/usr/lib64/python3.7/site-packages/twisted/conch/manhole.py'...
  File "/usr/lib64/python3.7/manhole.py", line 133
    def write(self, data, async=False):
                              ^
SyntaxError: invalid syntax


Version-Release number of selected component (if applicable): 16.4.1-9.fc29

This is blocking other packages.

Build logs attached.
Comment 1 Miro Hrončok 2018-05-29 11:51:02 UTC 
This has not yet been fixed upstream: https://github.com/twisted/twisted/blob/2e7b403c03e9b9b891a5eb36297e494f541d5d6a/src/twisted/conch/manhole.py#L154

There might be other problems: https://github.com/twisted/twisted/pull/1018
Comment 2 Miro Hrončok 2018-05-29 11:51:31 UTC 
Created attachment 1445370 [details]
root.log from copr
Comment 3 Miro Hrončok 2018-06-04 13:08:29 UTC 
Thomas?
Comment 4 Miro Hrončok 2018-06-05 16:10:03 UTC 
See proposed upstream fix: https://github.com/twisted/twisted/pull/966
Comment 5 Miro Hrončok 2018-06-08 10:41:39 UTC 
FYI: 3.7.0c1 is expected in 3 days (2018-06-11, [1]). I'd like to start building stuff in a side tag soon after that.

This blocks the "packager stack", hence a bit critical.

Thomas, could you please respond?


[1] https://www.python.org/dev/peps/pep-0537/
Comment 6 Miro Hrončok 2018-06-11 13:42:04 UTC 
I'm trying to backport https://github.com/twisted/twisted/pull/966 to see if that helps. This package does not run tests, so I will simply try to rebuild the dependent packages to verify if "works".
Comment 7 Miro Hrončok 2018-06-11 14:04:18 UTC 
txzmq:

    + nosetests-3.7
    ...
    Ran 36 tests in 3.346s


python-moksha-hub:


    + /usr/bin/python3 setup.py test
    ...
    Ran 58 tests in 60.315s
Comment 8 Miro Hrončok 2018-06-11 14:07:55 UTC 
Patch ready at https://src.fedoraproject.org/rpms/python-twisted/pull-request/5

Still waiting for "important" packages to build.
Comment 9 Miro Hrončok 2018-06-11 14:58:54 UTC 
+ py.test-3 fedmsg
============= 222 passed, 102 skipped, 1 warnings in 14.80 seconds =============


I think we are good in here.
Comment 10 Miro Hrončok 2018-06-13 14:14:51 UTC 
Pushed the dirty patch.
Comment 11 Red Hat Bugzilla 2023-09-12 01:28:39 UTC 
The needinfo request[s] on this closed bug have been removed as they have been unresolved for 1000 days
Note You need to log in before you can comment on or make changes to this bug.