Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1594896 - python-pytest-relaxed FTBFS on Python 3.7
Summary: python-pytest-relaxed FTBFS on Python 3.7
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: python-pytest-relaxed
Version: rawhide
Hardware: Unspecified
OS: Unspecified
high
unspecified
Target Milestone: ---
Assignee: Othman Madjoudj
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PYTHON37
TreeView+ depends on / blocked
 
Reported: 2018-06-25 16:04 UTC by Miro Hrončok
Modified: 2019-10-30 02:14 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-07-02 18:19:40 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Miro Hrončok 2018-06-25 16:04:39 UTC
Description of problem: python-pytest-relaxed FTBFS in the Python 3.7 side tag:

    fedpkg build --target=f29-python


Version-Release number of selected component (if applicable): python-pytest-relaxed-1.0.0-4.fc29

It seems to be a Python 2 test failure.

+ pytest-2.7
============================= test session starts ==============================
platform linux2 -- Python 2.7.15, pytest-3.6.1, py-1.5.3, pluggy-0.6.0
rootdir: /builddir/build/BUILD/pytest-relaxed-1.0.0, inifile: setup.cfg
plugins: relaxed-1.0.0
collected 49 items
tests/test_collection.py ....F.F...F.FFF.......F.F...F.FFF...            [ 36%]
tests/test_display.py FsF..F.Fs..F.
=================================== FAILURES ===================================
...

This transitively blocks Ansible.

https://koji.fedoraproject.org/koji/taskinfo?taskID=27753562

Comment 1 Miro Hrončok 2018-06-26 13:08:14 UTC
Will test an update to 1.1.2

Comment 2 Miro Hrončok 2018-06-26 13:18:04 UTC
OK, so 1.1.2 requires pytest < 3.3 (we have 3.6) and 1.1.0 (last version thet does not) have the same failures.

fabric, python-invoke and python-paramiko BR this. I guess we are a bit in a corner now. As for paramiko, I try to remove the dependency, as it blocks ansible.

Athmane, you are the maintainer of all of those, any input here?

Comment 3 Miro Hrončok 2018-06-26 13:55:45 UTC
JFYI the removal from paramiko was easy, since they don't use the plugin, only the @pytest_relaxed.raises decorator.

Comment 4 Miro Hrončok 2018-06-26 13:58:21 UTC
fabric and invoke on the other hand use the plugin.

Comment 5 Miro Hrončok 2018-06-26 14:09:13 UTC
I see several ways out:

1) BEST: fix https://github.com/bitprophet/pytest-relaxed/issues/2 and make this work
2) TEDIOUS: Package python-pytest-compat-3.2 
3) UNSAFE: Skip tests in fabric and invoke

Comment 6 Miro Hrončok 2018-06-29 14:32:48 UTC
I see you have disabled tests in python-pytest-relaxed. The package has been rebuilt in the 3.7 side tag, but python-invoke FTBFS.

Comment 7 Miro Hrončok 2018-07-02 18:19:40 UTC
I've build fabric and invoke.


Note You need to log in before you can comment on or make changes to this bug.