Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1596291 - accerciser fails to build against Python 3.7
Summary: accerciser fails to build against Python 3.7
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: accerciser
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Kalev Lember
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1596269
Blocks: PYTHON37
TreeView+ depends on / blocked
 
Reported: 2018-06-28 14:24 UTC by Marcel Plch
Modified: 2018-06-28 21:06 UTC (History)
2 users (show)

Fixed In Version: accerciser-3.22.0-7.fc29
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-06-28 21:06:46 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)

Description Marcel Plch 2018-06-28 14:24:22 UTC 
Description of problem:
When built against new python version, this package fails to build.
This occurs due to 'async' being used as an argument to function. Async is a keyword in 3.7.
Note that the function, where this argument is used, is imported from 'pyatspi' module, so it's package has to be fixed first.
Simple patch renaming async to asynch should be a sufficient solution.


Version-Release number of selected component (if applicable):
3.22.0-7

How reproducible:
always

Steps to Reproduce:
1. fedpkg clone accerciser
2. cd accerciser
3. fedpkg --release master  build --target=f29-python  --nowait  --srpm --scratch

Actual results:
fails to build

Expected results:
build passes correctly
Comment 1 Marcel Plch 2018-06-28 14:47:57 UTC 
Note to maintainer: Please, rebuild with --target=f29-python in a side tag after the fix.
Comment 2 Miro Hrončok 2018-06-28 16:13:16 UTC 
Should be fixed by changing:

    pyatspi.Registry.start(async=True, gil=False)


into:

    pyatspi.Registry.start(**{'async': True, 'gil': False})

This removes the syntax error and assuming pyatspi get's fixed in backwards compatible fashion should work.
Comment 3 Miro Hrončok 2018-06-28 17:23:19 UTC 
https://gitlab.gnome.org/GNOME/accerciser/merge_requests/1
Comment 4 Miro Hrončok 2018-06-28 17:28:43 UTC 
https://src.fedoraproject.org/rpms/accerciser/pull-request/1
Comment 5 Kalev Lember 2018-06-28 21:06:46 UTC 
Thanks! I've merged the PR and kicked off a build.
Note You need to log in before you can comment on or make changes to this bug.