Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1601482 - /usr/include/attr/xattr.h is absent from libattr-devel-2.4.48-1
Summary: /usr/include/attr/xattr.h is absent from libattr-devel-2.4.48-1
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: attr
Version: 28
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Kamil Dudka
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-07-16 13:17 UTC by Patrice LUCAS
Modified: 2018-07-22 03:03 UTC (History)
5 users (show)

Fixed In Version: attr-2.4.48-3.fc29 attr-2.4.48-3.fc28
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-07-22 03:03:01 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)

Description Patrice LUCAS 2018-07-16 13:17:48 UTC 
The header file /usr/include/attr/xattr.h disappears in libattr-devel-2.4.48-1 package while libattr-devel-2.4.47-23 contains it.





[root@vm0 ~]# dnf provides "/usr/include/attr/xattr.h"
Last metadata expiration check: 1:36:39 ago on Mon 16 Jul 2018 11:39:58 AM UTC.
libattr-devel-2.4.47-23.fc28.i686 : Files needed for building programs with libattr
Repo        : fedora
Matched from:
Filename    : /usr/include/attr/xattr.h

libattr-devel-2.4.47-23.fc28.x86_64 : Files needed for building programs with libattr
Repo        : fedora
Matched from:
Filename    : /usr/include/attr/xattr.h

[root@vm0 ~]# rpm -q libattr-devel
libattr-devel-2.4.48-1.fc28.x86_64
[root@vm0 ~]# rpm -ql libattr-devel
/usr/include/attr
/usr/include/attr/attributes.h
/usr/include/attr/error_context.h
/usr/include/attr/libattr.h
/usr/lib64/libattr.so
/usr/lib64/pkgconfig/libattr.pc
/usr/share/man/man3/attr_get.3.gz
/usr/share/man/man3/attr_getf.3.gz
/usr/share/man/man3/attr_list.3.gz
/usr/share/man/man3/attr_listf.3.gz
/usr/share/man/man3/attr_multi.3.gz
/usr/share/man/man3/attr_multif.3.gz
/usr/share/man/man3/attr_remove.3.gz
/usr/share/man/man3/attr_removef.3.gz
/usr/share/man/man3/attr_set.3.gz
/usr/share/man/man3/attr_setf.3.gz
[root@vm0 ~]#
Comment 1 Adam Williamson 2018-07-16 22:30:20 UTC 
This was apparently an intentional change: per Petr Pisar, "This is an intentional change. Applications should use sys/xattr.h instead provided by glibc." Elsewhere, Richard W.M. Jones provided these recommendations:

To provide for both locations we use this in configure.ac:

AC_CHECK_HEADERS([\
    attr/xattr.h \
    sys/xattr.h])

and this in each source file which needs the header:

#include <config.h>

#ifdef HAVE_ATTR_XATTR_H
# include <attr/xattr.h>
#else
# ifdef HAVE_SYS_XATTR_H
#  include <sys/xattr.h>
# endif
#endif

Rich.
Comment 2 Kamil Dudka 2018-07-17 06:45:31 UTC 
Yes, this is an intentional change upstream.  I overlooked the change while updating the package because attr.spec lists /usr/include/attr and not the individual header files.

I will hotfix it temporarily by providing a symlink /usr/include/attr/xattr.h -> ../sys/xattr.h which will be removed in the next release of Fedora via properly announced Fedora change.
Comment 3 Kamil Dudka 2018-07-17 06:52:51 UTC 
fixed via https://src.fedoraproject.org/cgit/rpms/attr.git/commit/?id=d60f6fa4
Comment 4 Fedora Update System 2018-07-17 07:00:47 UTC 
attr-2.4.48-3.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-e8c0b389f3
Comment 5 Patrice LUCAS 2018-07-17 07:46:01 UTC 
(In reply to Kamil Dudka from comment #2)
> Yes, this is an intentional change upstream.  I overlooked the change while
> updating the package because attr.spec lists /usr/include/attr and not the
> individual header files.
> 
> I will hotfix it temporarily by providing a symlink
> /usr/include/attr/xattr.h -> ../sys/xattr.h which will be removed in the
> next release of Fedora via properly announced Fedora change.

Thanks a lot ! Thank you for being highly responsive. You quickly fixed it and your solution perfectly fits our development process (The symlink fixs the current continuous integration tests and we are updating our product for the next version of Fedora.)
Comment 6 Kamil Dudka 2018-07-17 08:12:59 UTC 
No problem.  Thank you for verifying the temporary fix!
Comment 7 Fedora Update System 2018-07-19 20:18:06 UTC 
attr-2.4.48-3.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-e8c0b389f3
Comment 8 Raphael Groner 2018-07-20 01:30:15 UTC 
This issue affects koschei with ecryptfs-utils in F28.
Comment 9 Kamil Dudka 2018-07-20 09:54:06 UTC 
(In reply to Raphael Groner from comment #8)
> This issue affects koschei with ecryptfs-utils in F28.

ecryptfs-utils-111-12.fc29 now builds successfully against attr-2.4.48-3.fc29:

https://apps.fedoraproject.org/koschei/build/5019858
Comment 10 Kamil Dudka 2018-07-20 09:55:46 UTC 
... and it will build successfully in f28, too, once this is pushed to stable.
Comment 11 Fedora Update System 2018-07-22 03:03:01 UTC 
attr-2.4.48-3.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.
Note You need to log in before you can comment on or make changes to this bug.