Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1608973 - Possible Patented items in gnuradio
Summary: Possible Patented items in gnuradio
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: gnuradio
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Jaroslav Škarvada
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: FE-Legal
TreeView+ depends on / blocked
 
Reported: 2018-07-26 15:31 UTC by Dave Olsthoorn
Modified: 2018-08-10 23:34 UTC (History)
4 users (show)

Fixed In Version: gnuradio-3.7.13.4-3.fc29
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-08-10 20:35:45 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)
cleaning script (844 bytes, application/x-shellscript)
2018-07-28 16:28 UTC, Dave Olsthoorn 		no flags Details
View All

Description Dave Olsthoorn 2018-07-26 15:31:25 UTC 
Description of problem:
The source of gnuradio contains both decoders and encoders for dvb-t, dvb-t2 (for data streams, not for codecs) and maybe more. These components are possibly patented and thus not allowed in fedora.

Version-Release number of selected component (if applicable):
gnuradio-3.7.13.3-3.fc28
Comment 1 Dave Olsthoorn 2018-07-26 15:44:49 UTC 
List of patents applying to DVB-T: http://www.sisvel.com/DVB-T/Patents.pdf
List of patents applying to DVB-T2: http://www.sisvel.com/DVB-T2/Patents.pdf
Comment 2 Dave Olsthoorn 2018-07-26 17:15:26 UTC 
Github link to dvb-t sources: https://github.com/gnuradio/gnuradio/tree/master/gr-dtv/lib/dvbt
Github link to dvb-t2 sources: https://github.com/gnuradio/gnuradio/tree/master/gr-dtv/lib/dvbt2

Other possibly patented decoders/encoders:

dvb - https://github.com/gnuradio/gnuradio/tree/master/gr-dtv/lib/dvb
  note: used in other dvb decoders/encoders?

atsc - https://github.com/gnuradio/gnuradio/tree/master/gr-dtv/lib/atsc
       https://github.com/gnuradio/gnuradio/tree/master/gr-atsc
  note: https://www.atsc.org/policies/patent-statements/
Comment 3 Tom "spot" Callaway 2018-07-27 18:44:35 UTC 
Okay. DVB-T2 and ATSC support needs to come entirely out of the Fedora package. Everything seems to have expired for DVB-T, so it could stay, but I'm not sure if keeping the gr-dtv module in Fedora without ATSC and DVB-T2 is the right decision. It seems like removing gr-atsc and gr-drv and then making rpmfusion packages for them would provide a better user experience.

Jaroslav, I'll let you decide exactly how you want to do this, but the source tarball needs to be "clean", which means that the gr-atsc/ directory and the gr-dtv/lib/[atsc|dvbt2] directories need to be removed entirely.

Note: I did a local test build removing gr-atsc/ and the gr-dtv/lib/[atsc|dvbt2] directories, and it succeeded, but I don't know if it actually works or not.
Comment 4 Dave Olsthoorn 2018-07-28 16:28:53 UTC 
Created attachment 1471262 [details]
cleaning script

An shell script to clean the tarball of patented content
Comment 5 Tom "spot" Callaway 2018-08-09 14:37:40 UTC 
Jaroslav? If you don't take care of this soon, I will do it for you.
Comment 6 Jaroslav Škarvada 2018-08-09 14:39:11 UTC 
(In reply to Tom "spot" Callaway from comment #5)
> Jaroslav? If you don't take care of this soon, I will do it for you.

Sorry for delay, I will try to resolve it today.
Comment 7 Jaroslav Škarvada 2018-08-09 19:28:42 UTC 
(In reply to Tom "spot" Callaway from comment #3)
> Okay. DVB-T2 and ATSC support needs to come entirely out of the Fedora
> package. Everything seems to have expired for DVB-T, so it could stay, but
> I'm not sure if keeping the gr-dtv module in Fedora without ATSC and DVB-T2
> is the right decision. It seems like removing gr-atsc and gr-drv and then
> making rpmfusion packages for them would provide a better user experience.
> 
> Jaroslav, I'll let you decide exactly how you want to do this, but the
> source tarball needs to be "clean", which means that the gr-atsc/ directory
> and the gr-dtv/lib/[atsc|dvbt2] directories need to be removed entirely.
> 
> Note: I did a local test build removing gr-atsc/ and the
> gr-dtv/lib/[atsc|dvbt2] directories, and it succeeded, but I don't know if
> it actually works or not.

Is it needed to repack the tarball, or is it enough to drop the patented content in the %prep phase?
Comment 8 Tom "spot" Callaway 2018-08-10 13:31:47 UTC 
You need to repack the tarball.
Comment 9 Jaroslav Škarvada 2018-08-10 14:54:05 UTC 
Thanks for info, building the test build now.
Comment 10 Jaroslav Škarvada 2018-08-10 14:54:25 UTC 
(In reply to Dave Olsthoorn from comment #4)
> Created attachment 1471262 [details]
> cleaning script
> 
> An shell script to clean the tarball of patented content

Thanks for the script :)
Comment 11 Jaroslav Škarvada 2018-08-10 14:59:32 UTC 
I opened upstream bug:
https://github.com/gnuradio/gnuradio/issues/1948
Comment 12 Jaroslav Škarvada 2018-08-10 23:34:06 UTC 
It's in the dist-git, but not build. I cannot build it on s390x due to bug 1614512.
Note You need to log in before you can comment on or make changes to this bug.