Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1614929 - Review Request: golang-github-fatih-set - Set data structure for Go
Summary: Review Request: golang-github-fatih-set - Set data structure for Go
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: FE-NEEDSPONSOR 1615641
TreeView+ depends on / blocked
 
Reported: 2018-08-10 18:46 UTC by redhatrises
Modified: 2018-09-04 18:29 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-09-04 18:29:03 UTC
Type: ---
Embargoed:
zebob.m: fedora-review+

Attachments (Terms of Use)

Description redhatrises 2018-08-10 18:46:30 UTC 
Spec URL: https://copr-be.cloud.fedoraproject.org/results/rga/compliance-masonry/fedora-rawhide-x86_64/00786826-golang-github-fatih-set/golang-github-fatih-set.spec
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/rga/compliance-masonry/fedora-rawhide-x86_64/00786826-golang-github-fatih-set/golang-github-fatih-set.spec

Koji Scratch Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=28971307

Description: 
Set is a basic and simple, hash-based, Set data structure implementation in Go (Golang).
Fedora Account System Username: rga
Comment 1 redhatrises 2018-08-10 18:49:21 UTC 
Dependency for part of my first package https://bugzilla.redhat.com/show_bug.cgi?id=1609038
Comment 2 redhatrises 2018-08-10 20:47:56 UTC 
Added the SRPM link and had an unneeded BuildRequires:

Spec URL: https://copr-be.cloud.fedoraproject.org/results/rga/compliance-masonry/fedora-28-x86_64/00786883-golang-github-fatih-set/golang-github-fatih-set.spec
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/rga/compliance-masonry/fedora-28-x86_64/00786883-golang-github-fatih-set/golang-github-fatih-set-0.2.1-1.fc28.src.rpm

Koji Scratch Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=28973857
Comment 3 Robert-André Mauchin 🐧 2018-08-12 19:58:32 UTC 
 - Version:        0.2.1 should go before %gometa

 - You're missing the Release info in yous %changelog entry:

* Thu Aug 9 2018 Gabe <redhatrises> - 0.2.1-1

 - golang-github-fatih-set.src: E: description-line-too-long C Set is a basic and simple, hash-based, Set data structure implementation in Go (Golang).

Split the description to stay below 80 characters per line.


 - License ok
 - Latest version packaged
 - Builds in mock
 - Conforms to Packaging Guidelines

Package approved. Fix the above issues before importing.
Comment 4 redhatrises 2018-08-13 16:08:34 UTC 
Thanks for the reviewing!

Updated Spec URL: https://copr-be.cloud.fedoraproject.org/results/rga/compliance-masonry/fedora-28-x86_64/00787539-golang-github-fatih-set/golang-github-fatih-set.spec
Updated SRPM URL: https://copr-be.cloud.fedoraproject.org/results/rga/compliance-masonry/fedora-28-x86_64/00787539-golang-github-fatih-set/golang-github-fatih-set-0.2.1-1.fc28.src.rpm
Comment 5 Gwyn Ciesla 2018-08-27 16:34:02 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-fatih-set
Comment 6 redhatrises 2018-09-04 18:29:03 UTC 
Package is now in rawhide. Thanks everyone!
Note You need to log in before you can comment on or make changes to this bug.