Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1627250 - Retire python-glusterfs-api in Fedora 30+ (or switch it to python3 only)
Summary: Retire python-glusterfs-api in Fedora 30+ (or switch it to python3 only)
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: python-glusterfs-api
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Kaleb KEITHLEY
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PYTHON3 PY2REMOVAL
TreeView+ depends on / blocked
 
Reported: 2018-09-10 14:06 UTC by Miro Hrončok
Modified: 2018-09-26 17:16 UTC (History)
9 users (show)

Fixed In Version: python-glusterfs-api-1.2-1
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-09-26 17:16:27 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Miro Hrončok 2018-09-10 14:06:20 UTC 
In line with the Mass Python 2 Package Removal [0], all (sub)packages of python-glusterfs-api were marked for removal:

 * python2-glusterfs-api

According to our query, those packages only provide a Python 2 importable module. If this is not true, please tell us why, so we can fix our query.

Please retire your package in Rawhide (Fedora 30).

If there is no objection in a week, we will retire the package for you.

We hope this doesn't come to you as a surprise. If you want to know our motivation for this, please read the change document [0].

[0] https://fedoraproject.org/wiki/Changes/Mass_Python_2_Package_Removal
Comment 1 Kaleb KEITHLEY 2018-09-11 11:15:52 UTC 
Prasanth, what's the status of this?

I see that a couple of files in https://github.com/gluster/libgfapi-python/blob/master/gluster/... have been updated with commit message "Port to Python 3.x" and I see some python3-isms, but no new Release/tag has been made.

Also https://files.pythonhosted.org/packages/source/g/gfapi/%{python_package_name}-%{version}.tar.gz gives a 404 error.

top-level https://files.pythonhosted.org now sends people to to https://pypi.org and I don't see any evidence at https://pypi.org/project/gfapi/ that anything has changed.

Is it python3 ready? Can we get a 1.2 or 2.0 tag? If so I'll update the package in Fedora and save it from being retired.

Thanks
Comment 2 Prashanth Pai 2018-09-12 04:11:53 UTC 
The libgfapi-python project now supports both python2 and python3.

However, it doesn't conform to the Fedora packaging guidelines about the shebang lines yet. I'll look into that.
Comment 3 Kaleb KEITHLEY 2018-09-12 11:26:59 UTC 
Please do not retire it. We are working on making it python3.
Comment 4 Miro Hrončok 2018-09-12 11:44:28 UTC 
Do you need help with the shebangs? I can send a PR for the spec as long as it's gfapi 1.1 that works with Python 3.
Comment 5 Kaleb KEITHLEY 2018-09-12 11:53:15 UTC 
gfapi-1.1 is not the version that works with py3.

The shebangs need to be fixed and a 1.2 or 2.0 release/tag made.

I would also like to know what is currently considered the authoritative source:
  https://files.pythonhosted.org/packages/source/g/gfapi (dead, so probably not)
or
  https://pypi.org/project/gfapi/ (where I can't find a source tarball)
or
  https://github.com/gluster/libgfapi-python (which says it's only a mirror of pythonhosted)
Comment 6 Prashanth Pai 2018-09-17 05:14:22 UTC 
(In reply to Kaleb KEITHLEY from comment #5)
> gfapi-1.1 is not the version that works with py3.
> 
> The shebangs need to be fixed and a 1.2 or 2.0 release/tag made.
> 
> I would also like to know what is currently considered the authoritative
> source:
>   https://files.pythonhosted.org/packages/source/g/gfapi (dead, so probably
> not)
> or
>   https://pypi.org/project/gfapi/ (where I can't find a source tarball)
> or
>   https://github.com/gluster/libgfapi-python (which says it's only a mirror
> of pythonhosted)

I'll update this BZ when I cut out the release.

The guideline at https://fedoraproject.org/wiki/Packaging:Guidelines#Shebang_lines explicitly states - "Files which are not installed as executables SHOULD NOT have shebang lines". As the python bindings is a library without any executable, the shebang rule is not applicable.
Comment 7 Kaleb KEITHLEY 2018-09-26 17:16:27 UTC 
fixed in python-glusterfs-api-1.2-1.fc29 and python-glusterfs-api-1.2-1.fc30
Note You need to log in before you can comment on or make changes to this bug.