Hi Luis.

Are you in the packager group?
I don't see your FAS in this group.

Hi Antonio, I'm still not in the group of packers.

Your package needs to be renovate a little bit.

Are you already read the packaging guidelines?
https://fedoraproject.org/wiki/Packaging:Guidelines#Macros
https://fedoraproject.org/wiki/Packaging:RPMMacros

This document reports many informations for correctly using RPM macros.

Also read the section about BuildRequires packages.
https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRequires

Why creation of debug packages is disabled with "%global debug_package %{nil}"?
https://fedoraproject.org/wiki/Packaging:Guidelines#Debuginfo_packages

And, none license file?

Thank you for your comments, I will be looking at the documentation

Hi Antonio, I have updated the files
1- I removed the debug "%global debug_package %{nil}"
2 -I included the license

- Dependencies (save some exception) are automatically resolved.
The 'Requires:' lines are not needed.

- With "BuildRequires:  pkgconfig(libssh) <= 0.7.5" you can't currently build this package on Fedora because  we have 'libssh-0.8.3' available now.

Why this choice?

- Usually, '%post' and '%postun' scriptlets are positioned after '%install' section; however, the 'update-desktop-database' commands are not needed anymore and can be removed.

- Make command?

%build
%configure --with-gtk2
??%make_build??

- All commands you have listed under '%install' (the '$RPM_BUILD_ROOT' removing is redundant) are done with a simple

%make_install

- '%defattr' is redundant.
(See https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions)

- Use the macro:

'%{_prefix}/share' --> '%{_datadir}'

- '%{name}.desktop' file is not verified. See https://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage

Postscriptum:

What '%make_build' and '%make_install' commands do? Discover it with the '--eval' option of 'rpm':

$ rpm --eval %make_build
/usr/bin/make -O -j2

$ rpm --eval %make_install
/usr/bin/make install DESTDIR=/home/sagitter/rpmbuild/BUILDROOT/%{NAME}-%{VERSION}-%{RELEASE}.x86_64 INSTALL="/usr/bin/install -p"

I have updated the files, can you verify please.

Thanks

- 'desktop-file-install' already includes the file validation; the line 

'desktop-file-validate %{buildroot}/%{_datadir}/applications/%{name}.desktop'

can be removed.

- As said before, the 'update-desktop-database' commands are not used anymore.

- Additionally,

'%{_datadir}/%{name}/*'

will allow to own all the files inside '%{_datadir}/%{name}/' but not the directory '%{_datadir}/%{name}'.

Just modify that line to

'%{_datadir}/%{name}/'

Done!

Scratch build on Koji:

checking for cl.exe... no
configure: error: in `/builddir/build/BUILD/lterm-1.5.1':
configure: error: no acceptable C compiler found in $PATH
See `config.log' for more details
RPM build errors:
error: Bad exit status from /var/tmp/rpm-tmp.7hniiv (%build)

Try a build with Mock for testing a new SRPM.
GCC compiler is missing among BuildRequires packages.

I added GCC to BuildRequires 
can you see my koji result https://koji.fedoraproject.org/koji/taskinfo?taskID=30080208

You need a sponsor now:
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group

Thanks a lot Antonio.

Thanks Antonio for the review process and thanks Eduardo for sponsor Luis in the packager team.

Cheers,

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/lterm

https://koji.fedoraproject.org/koji/buildinfo?buildID=1153693

lterm-1.5.1-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-1787f702b1

lterm-1.5.1-1.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2018-dc188994d0

lterm-1.5.1-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-dc188994d0

lterm-1.5.1-1.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-1787f702b1

lterm-1.5.1-1.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.

lterm-1.5.1-1.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.