Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at
Bug 165497 - Review Request: dumpasn1 - ASN.1 object dump utility
Summary: Review Request: dumpasn1 - ASN.1 object dump utility
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Christian Iseli
QA Contact: David Lawrence
Depends On:
TreeView+ depends on / blocked
Reported: 2005-08-09 21:03 UTC by Ville Skyttä
Modified: 2007-11-30 22:11 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2005-08-15 18:57:31 UTC
Type: ---

Attachments (Terms of Use)

Description Ville Skyttä 2005-08-09 21:03:33 UTC

dumpasn1 is an ASN.1 object dump program that will dump data encoded
using any of the ASN.1 encoding rules in a variety of user-specified

Comment 1 Christian Iseli 2005-08-15 18:57:31 UTC
- rpmlint is happy
- name ok
- spec name ok
- packaging guidelines met
- license ok
- license matches actual license in package
- license file in %doc
- spec file in American English
- spec file legible
- source matches upstream
- locale handling ok
- BuildRequires ok
- builds, installs, runs, and uninstalls cleanly
- builds in mock

  Minor nit: there are a few warnings, but nothing serious.

- files stuff: ok
- clean section ok
- macro useage pretty ok

  Minor nit: in Source0, Source1, and Patch0 you sometimes use %{name}
  and sometime use dumpasn1 directly.  I think you should use %{name}

- package contains code
- %doc is only doc



Comment 2 Ville Skyttä 2005-08-15 20:43:07 UTC
Thanks for the review.  Macro usage tweaked a bit in CVS, devel built  
successfully, will request a FC-4 branch in a jiffy and a build later. 

Comment 3 Christian Iseli 2005-08-15 21:16:51 UTC
You are welcome.  BTW, forgot to ask:  Is there any reason for the CC="%{__cc}"
on the make line ?

Comment 4 Ville Skyttä 2005-08-16 06:17:03 UTC
Not really, I think it's a relic from the times I first did this package and 
the Debian patch was not yet applied (ie. no Makefile). 

Note You need to log in before you can comment on or make changes to this bug.