Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at
Bug 165660 - Review Request: perl-Text-Quoted
Summary: Review Request: perl-Text-Quoted
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Paul Howarth
QA Contact: David Lawrence
Depends On:
TreeView+ depends on / blocked
Reported: 2005-08-11 09:17 UTC by Ralf Corsepius
Modified: 2010-03-01 16:51 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2005-08-20 01:49:54 UTC
Type: ---
j: fedora-cvs+

Attachments (Terms of Use)

Description Ralf Corsepius 2005-08-11 09:17:14 UTC
Spec Name or Url:
SRPM Name or Url:

Text::Quoted examines the structure of some text which may contain multiple
different levels of quoting, and turns the text into a nested data structure.

Comment 1 Paul Howarth 2005-08-19 12:10:01 UTC

- rpmlint not quite clean - see below
- package and spec file naming is OK
- package meets guidelines
- license is same as perl
- spec file written in English and is legible
- source matches upstream
- builds OK on FC4 and in mock for devel
- BR's OK
- no locales, libraries, subpackages, pkgconfigs etc. to worry about
- not relocatable
- no directory ownership issues
- installed with wrong permissions - see below
- no duplicate files
- %clean section present and correct
- macro usage is consistent
- code, not content
- no large docs
- docs don't affect runtime


- rpmlint output
E: perl-Text-Quoted script-without-shellbang
This script does not begins with a shellbang. It will prevent its execution.

This is a permissions problem and can be fixed by adding after %setup:
chmod -x

- BR: perl is redundant
- find of empty .bs files is redundant

These can be fixed post-import.


Comment 2 Ralf Corsepius 2005-08-19 13:25:25 UTC
> E: perl-Text-Quoted script-without-shellbang
> /usr/lib/perl5/vendor_perl/5.8.6/Text/
> This script does not begins with a shellbang. It will prevent its execution.
This is a perl module (*.pm) and not a script. Perl modules normally aren't
executed directly, so they don't have to carry a shebang, nor are they supposed
to be executable. 

IMO, this yet another case of a "false error" from rpmlint.

Comment 3 Paul Howarth 2005-08-19 13:27:32 UTC
Without the chmod referred to in the review, it *is* installed as executeable
and therefore it isn't a "false error".

Comment 4 Ralf Corsepius 2005-08-19 14:01:45 UTC
Urgs, you are right. Sorry for having missed this. To be fixed RSN.

Comment 5 Mark Chappell 2010-03-01 14:00:57 UTC
corsepiu is listed as not interested in EPEL

Package Change Request
Package Name: perl-Text-Quoted
New Branches: EL-4 EL-5
Owners: tremble

Comment 6 Jason Tibbitts 2010-03-01 16:51:14 UTC
CVS done.

Note that when we add EPEL branches like this, we'll change the owner as requested but the other parameters such as comaintainers are copied.  If this isn't what's desired, please fix things up in pkgdb.

Note You need to log in before you can comment on or make changes to this bug.