Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 165878 - Review Request: kadu
Summary: Review Request: kadu
Keywords:
Status: CLOSED DUPLICATE of bug 199192
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Greg DeKoenigsberg
QA Contact: David Lawrence
URL: http://www.kadu.net
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2005-08-13 11:48 UTC by Mariusz Wasiluk
Modified: 2007-11-30 22:11 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-07-17 21:51:52 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Mariusz Wasiluk 2005-08-13 11:48:56 UTC
Spec Name or Url: http://kadu.net/~nastian/kadu.spec
SRPM Name or Url: http://kadu.net/~nastian/kadu-0.4.1-1.fc4.src.rpm
Description: Kadu is client of Gadu-Gadu 6.1 protocol (very popular in Poland).
It's an Internet Messager for Linux and UN*X or MacOSX. It supports
voice messaging, file transfer, animated emoticons and modules.

Comment 1 Dawid Gajownik 2005-08-15 17:22:48 UTC
It seems to be your first pacakge in Fedora Extras, so the first review must be
done by you sponsor. I may only help you cleaning up the spec file :]

- use %{dist} in the Release tag instead of hardcoding 'fc4'.
http://fedoraproject.org/wiki/Extras/BuildRequests
http://fedoraproject.org/wiki/DistTag

I'm not shure whether it's still true but few people on Fedora Extras were
suggesting adding %{dist} after importing package info CVS.
- remove spaces after "Applications/Internet"
- MacOSX â Mac OS X (?)
- Alsa â ALSA
- you have removed dots from the %description fileds. Please revert your
changes. They're not allowed only at the end of a "Summary".
- I'm not a native English speaker but "Modules aRts for Kadu" sounds weird to
me. Maybe "aRts module for Kadu" would be better?
- according to this page â
http://fedoraproject.org/wiki/PackageNamingGuidelines#NormalPackages you should
avoid using underscore in the package name.
- this files could be marked as %doc:

%{_datadir}/%{name}/AUTHORS
%{_datadir}/%{name}/README
%{_datadir}/%{name}/ChangeLog
%{_datadir}/%{name}/COPYING
%{_datadir}/%{name}/HISTORY
%{_datadir}/%{name}/THANKS

- you can also pass to this options the desktop-file-install program:

 --add-category InstantMessaging

http://standards.freedesktop.org/menu-spec/latest/apa.html  

Comment 2 Mariusz Wasiluk 2005-08-19 18:14:37 UTC
New:
SPEC: http://kadu.net/~nastian/kadu.spec
SRPM: http://kadu.net/~nastian/kadu-0.4.1-2.src.rpm

I can't avoid underscore in package name becouse it is module name.
Files:
%{_datadir}/%{name}/AUTHORS
%{_datadir}/%{name}/README
%{_datadir}/%{name}/ChangeLog
%{_datadir}/%{name}/COPYING
%{_datadir}/%{name}/HISTORY
%{_datadir}/%{name}/THANKS
are used by Kadu in About window so they must be in that path. If I put them
also to doc they will be duplicated in package.

Comment 3 Dawid Gajownik 2005-08-30 10:55:59 UTC
Sorry that it took me so long but I was a bit busy recently :/
(In reply to comment #1)

> Maybe "aRts module for Kadu" would be better?

This also applies to the "Summary" fields ;-)

(In reply to comment #2)

> I can't avoid underscore in package name becouse it is module name.

OK.

> Files are used by Kadu in About window so they must be in that path.

Oh, I didn't know about it.

I missed few things:
- remove hardcoded path from the kadu.desktop path:

Exec=kadu -caption "%c" %i %m

should be sufficient.
- in Categories field you can add "Qt" and maybe "KDE":
http://standards.freedesktop.org/menu-spec/latest/apa.html
This site does not mention "X-KDE-Base" so I'm not shure whether it's valid
entry :/ (help)
- drop these lines:

Requires:       qt >= 3.2
Requires:       libsndfile >= 1.0.11

RPM automatically detects proper requirements. What is more, Fedora Core and
Extras (FC3+) provide appopriate versions of these libraries.
- don't include /usr/lib/debug in the devel package
- architecture dependent files (modules) are in /usr/share directory - that's
against FHS 2.3 standard
http://www.pathname.com/fhs/pub/fhs-2.3.html#USRSHAREARCHITECTUREINDEPENDENTDATA
I would suggest contacting with upstream and urge them to move these files to 
/usr/lib/kadu
http://www.pathname.com/fhs/pub/fhs-2.3.html#USRLIBLIBRARIESFORPROGRAMMINGANDPA
- modules are not stripped

And one more thing which looks weird to me - rpmlint warns about too long line
in description. Maybe it counts non-US-ASCII characters as two characters?

Comment 4 Marcin Slusarz 2005-11-06 10:11:51 UTC
why this spec does not include external modules?

ps: .so files was moved to /usr/lib month ago, but as it would break
compatibility in 0.4 line, it will be included in next major release (0.5)



Comment 5 Marcin Garski 2006-01-06 13:50:56 UTC
Kadu 0.4.3 has been released some time ago.

Mariusz do you still work on this package?

Comment 6 Michał Bentkowski 2006-07-16 10:51:39 UTC
If I would like to take over this package, I should create new bug or continue 
it here?

Comment 7 Rahul Sundaram 2006-07-17 11:56:57 UTC
You should create a new request and close this one

Comment 8 Michał Bentkowski 2006-07-17 17:39:37 UTC
(In reply to comment #7)
> You should create a new request and close this one
Yes, but... I have no permissions to change status of this bug.

Comment 9 Michał Bentkowski 2006-07-17 21:24:02 UTC
Bug 199192 is new request for this package.

Comment 10 Jason Tibbitts 2006-07-17 21:51:52 UTC

*** This bug has been marked as a duplicate of 199192 ***


Note You need to log in before you can comment on or make changes to this bug.