Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 166059 - Review Request: perl-Class-Container
Summary: Review Request: perl-Class-Container
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Greg DeKoenigsberg
QA Contact: David Lawrence
URL: http://ftp.kspei.com/pub/steve/rpms/p...
Whiteboard:
Depends On:
Blocks: FE-ACCEPT 166063
TreeView+ depends on / blocked
 
Reported: 2005-08-16 14:23 UTC by Steven Pritchard
Modified: 2007-11-30 22:11 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2005-08-21 00:49:49 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
Proposed spec patch (624 bytes, patch)
2005-08-16 14:59 UTC, Ralf Corsepius
no flags Details | Diff

Description Steven Pritchard 2005-08-16 14:23:34 UTC
Spec Name or Url: http://ftp.kspei.com/pub/steve/rpms/perl-Class-Container/perl-Class-Container.spec
SRPM Name or Url: http://ftp.kspei.com/pub/steve/rpms/perl-Class-Container-0.12-1.src.rpm
Description:
This class facilitates building frameworks of several classes that
inter-operate. It was first designed and built for "HTML::Mason", in
which the Compiler, Lexer, Interpreter, Resolver, Component, Buffer, and
several other objects must create each other transparently, passing the
appropriate parameters to the right class, possibly substituting other
subclasses for any of these objects.

The main features of "Class::Container" are:

*   Explicit declaration of containment relationships (aggregation,
    factory creation, etc.)

*   Declaration of constructor parameters accepted by each member in a
    class framework

*   Transparent passing of constructor parameters to the class that
    needs them

*   Ability to create one (automatic) or many (manual) contained objects
    automatically and transparently

Comment 1 Ralf Corsepius 2005-08-16 14:59:14 UTC
Created attachment 117790 [details]
Proposed spec patch

Comment 2 Ralf Corsepius 2005-08-16 15:00:57 UTC
Package looks fine, source match cpan, ...

Some minor nits:
- The LD_RUN_PATH "sed" isn't necessary.
- %check ||:
- Explicitly setting perl_vendorlib isn't necessary since FC3

I'd approve the package with the patch from the attachment applied.


Comment 3 Steven Pritchard 2005-08-17 22:46:30 UTC
Done, and checked into CVS.  Approved?

Comment 4 Ralf Corsepius 2005-08-18 01:33:53 UTC
Yep.


Note You need to log in before you can comment on or make changes to this bug.