Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 166200 - Review Request: perl-IO-CaptureOutput : Capture STDOUT/STDERR from subprocesses and XS/C modules
Summary: Review Request: perl-IO-CaptureOutput : Capture STDOUT/STDERR from subprocess...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Chris Grau
QA Contact: David Lawrence
URL: http://search.cpan.org/dist/IO-Captur...
Whiteboard:
Depends On:
Blocks: FE-ACCEPT 166203
TreeView+ depends on / blocked
 
Reported: 2005-08-17 20:47 UTC by Tom "spot" Callaway
Modified: 2007-11-30 22:11 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2005-08-18 04:21:58 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Tom "spot" Callaway 2005-08-17 20:47:53 UTC 
Spec Name or Url: 
http://www.auroralinux.org/people/spot/review/Maypole/perl-IO-CaptureOutput.spec

SRPM Name or Url:
http://www.auroralinux.org/people/spot/review/Maypole/perl-IO-CaptureOutput-1.03-2.src.rpm

Description: 

Capture STDOUT/STDERR from subprocesses and XS/C modules

(NOTE: This package is one of the Maypole dependencies)
Comment 1 Chris Grau 2005-08-18 00:28:24 UTC 
Review:

- rpmlint clean
- package name okay
- spec file name okay
- package meets PackagingGuidelines
- license okay
- license matches upstream
- spec file in am. english (and legible)
- source matches upstream
- package builds on FC-4
- no locales
- no shared libs
- not relocatable
- owns all created directories
- no duplicate %files
- file permissions okay
- %clean okay
- consistent use of macros
- code, not content
- no -docs package
- no -devel package

Needswork:

Testing resulted in this output:

> t/capture.........ok
> 3/13 skipped: Inline->bind failed : This innvocation of Inline requires the
Parse::RecDescent module.
> t/capture_exec....ok
> t/pod.............skipped
> all skipped: Test::Pod 1.00 required for testing POD
> t/pod_coverage....skipped
> all skipped: Test::Pod::Coverage 1.00 required for testing pod coverage

I see that perl(Inline) is a BR for testing, but the named modules should also
be added to the BRs for complete test coverage.

Nitpicks:

- BuildRequires: perl >= 1:5.6.1
- make called without %{_smp_mflags}
Comment 2 Tom "spot" Callaway 2005-08-18 03:23:57 UTC 
All items fixed in -3:

New SRPM:
http://www.auroralinux.org/people/spot/review/Maypole/perl-IO-CaptureOutput-1.03-3.src.rpm

New SPEC:
http://www.auroralinux.org/people/spot/review/Maypole/perl-IO-CaptureOutput.spec
Comment 3 Chris Grau 2005-08-18 03:52:04 UTC 
Still needs BR: perl(Test::Pod) for full test coverage.  Add that and I'll
approve it.
Comment 4 Tom "spot" Callaway 2005-08-18 03:57:26 UTC 
Doh. I thought T::P::C would drag it in. I was wrong. Fixed in -4.

New SRPM:
http://www.auroralinux.org/people/spot/review/Maypole/perl-IO-CaptureOutput-1.03-4.src.rpm

New SPEC:
http://www.auroralinux.org/people/spot/review/Maypole/perl-IO-CaptureOutput.spec
Comment 5 Chris Grau 2005-08-18 04:03:36 UTC 
Okay, it's approved.
Note You need to log in before you can comment on or make changes to this bug.