* BuildRequires: desktop-file-utils is missing
* rpmlint says: zero-length /usr/share/apps/rekall/stock/component/py/dummy.
Maybe it's justified, since it's a dummy file
* rpmlint of rekall-runtime says: library-without-ldconfig (missing ldconfig in
post and postun for this subpackage), devel-file-in-non-devel-package
/usr/lib/librek{all,base}rt.so. Maybe it's not necessary to make a
rekall-runtime-devel subpackage, but in this case please have rekall-runtime
provide it.
* Typo in rekall-runtime %description: s/design functions or removed/design
functions are removed/g
* --vendor in desktop files should be fedora, not kde
* in the desktop file: missing "Application" category. I would also add the
"Office" category.
* when creating a new database with the xbase driver, I get the message :
« xbase: cannot load driver. Library files for "libkbase_driver_xbase.la" not
found in paths. ». Same thing for mysql driver and pgsql. It looks like rekall
needs those *.la files.
* rekall apparently uses .rlk files. It could be useful to associate those files
with rekall, using a mime entry in the desktop file (--add-mime-type switch) and
running update-desktop-database in %post.
* the desktop entry does not have an icon. Symlinking
%{_datadir}/apps/rekall/icons/hicolor/32x32/apps/rekall.png to
%{_datadir}/pixmaps should do the trick.

All of these issues should be covered in -2. I tested making an xbase/xbsql
database and it didn't throw any errors.

New SRPM: http://www.auroralinux.org/people/spot/review/rekall-2.2.3-2.src.rpm
New SPEC: http://www.auroralinux.org/people/spot/review/rekall.spec

> * the desktop entry does not have an icon. Symlinking
> %{_datadir}/apps/rekall/icons/hicolor/32x32/apps/rekall.png to
> %{_datadir}/pixmaps should do the trick.

I am not really sure about this but I think the better way for the icon to
appear would be running gtk-update-icon-cache instead of creating this symlink.
This should, at least in gnome, show the icon in the menu.

Yes, I'm not sure what the Right Way is, but IIRC KDE looks for its icons in
_datadir/pixmaps and in _datadir/icons/<theme>/<size>/apps, and not in
_datadir/apps/rekall anyway. I don't think there is such thing as
gtk-update-icon-cache for KDE.

Last problems I see :
* subpackage -runtime should also require desktop-file-utils (it uses
update-desktop-database in scriptlets)
* while making the icon symlink, please change /usr/share into %{datadir}
* you symlink rekall's icon, but you copy rekallrt's one. Please symlink it too
(or copy the symlink, not the icon)

Fixed in -3:

- runtime now requires d-f-u
- use %{_datadir} everywhere

I need to copy the rekallrt icon, otherwise, rekall-runtime would have to
require the "rekall" package, and the whole point of the runtime is that it can
be distributed without the rest of rekall.

SRPM:
http://www.auroralinux.org/people/spot/review/rekall-2.2.3-3.src.rpm

SPEC:
http://www.auroralinux.org/people/spot/review/rekall.spec

> I need to copy the rekallrt icon, otherwise, rekall-runtime would have to
> require the "rekall" package

Yes of course...

However, it seems that rekall-runtime is not really independant. Having no
rekall package installed, here's what I get:
$ sudo rpm -Uvh rekall-runtime-2.2.3-3.fc4.i386.rpm
error: Failed dependencies:
   libkbase_common.so.0 is needed by rekall-runtime-2.2.3-3.fc4.i386
   libkbase_kde.so.0 is needed by rekall-runtime-2.2.3-3.fc4.i386
   libkbase_tkwidgets.so.0 is needed by rekall-runtime-2.2.3-3.fc4.i386

It's been built in mock. And the "rekall" package provides these libs.

-4 fixes this by creating a "rekall-common" subpackage, which both rekall and
rekall-runtime need to function. Tested and confirmed that it enables
rekall-runtime to work.

New SRPM: http://www.auroralinux.org/people/spot/review/rekall-2.2.3-4.src.rpm
New SPEC: http://www.auroralinux.org/people/spot/review/rekall.spec

Review for release 4:
* RPM name is OK
* Source rekall-2.2.3-2.tar.gz is the same as upstream
* Builds fine in mock
* rpmlint looks OK
* File list looks OK
* rekall-runtime can be installed independently
* Works as expected

APPROVED. After import, you may want to remove the following duplicate
BuildRequires :
- xbase-devel (required by xbsql-devel)
- qt-devel (required by kdelibs-devel)

Rekall is published, closing bug