Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at
Bug 166438 - Review Request: R-mAr
Summary: Review Request: R-mAr
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Tom "spot" Callaway
QA Contact: David Lawrence
Depends On:
TreeView+ depends on / blocked
Reported: 2005-08-21 10:05 UTC by José Matos
Modified: 2007-11-30 22:11 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2005-10-06 12:54:43 UTC
Type: ---

Attachments (Terms of Use)

Description José Matos 2005-08-21 10:05:06 UTC
Spec Name or Url:
SRPM Name or Url:
R package:
An R add-on package for estimation of multivariate AR models through a
computationally-efficient stepwise least-squares algorithm (Neumaier
and Schneider, 2001); the procedure is of particular interest for
high-dimensional data without missing values such as geophysical

Comment 1 José Matos 2005-09-09 10:10:25 UTC
Same version, new location: 
As soon as I get a review of this package I will submit more R packages 
that are in the queue since its packaging it is mostly similar. 

Comment 2 Tom "spot" Callaway 2005-10-05 17:00:18 UTC
Agreed. This looks exactly like the template I was using for the CRAN packages I
had in the queue.

The only difference is that I also have:

%{_bindir}/R CMD check %{packname}

I also have tetex-latex as a BuildRequires, since it seems to need it for many
packages to generate the docs. 

Comment 3 Tom "spot" Callaway 2005-10-05 17:35:56 UTC
Minor changes:
%doc DESCRIPTION COPYING doesn't seem to be needed as these files end up in
%{_libdir}/R/library/%{packname} as part of the install process.

%check should be:

cd ..;%{_bindir}/R CMD check %{packname}

Comment 4 Tom "spot" Callaway 2005-10-05 17:41:04 UTC
With the changes I describe above applied...


- rpmlint checks return:
W: R-mAr invalid-license GPL version 2 or newer
(rpmlint making noise)
E: R-mAr no-binary
E: R-mAr only-non-binary-in-usr-lib
(safe to ignore for R packages)
W: R-mAr no-documentation
W: R-mAr dangerous-command-in-%post perl
W: R-mAr dangerous-command-in-%postun perl
(safe to ignore)

- package meets naming guidelines
- package meets packaging guidelines
- license (GPL) OK, text included, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc
- no need for .desktop file

APPROVED, assuming my changes are applied (BR: tetex-latex, no duplication of
docs, use of %check).

With this sort of a template, these packages should be quick to review. :)

Comment 5 José Matos 2005-10-06 12:11:58 UTC
I have applied all your suggestions and I have imported the package. 
Thank you. 

Comment 6 José Matos 2005-10-06 12:54:43 UTC
Build on target development succeeded. 

Note You need to log in before you can comment on or make changes to this bug.