Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at
Bug 166915 - Review Request: qscintilla - A Scintilla port to Qt
Summary: Review Request: qscintilla - A Scintilla port to Qt
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Aurelien Bompard
QA Contact: David Lawrence
Depends On:
TreeView+ depends on / blocked
Reported: 2005-08-27 15:59 UTC by Konstantin Ryabitsev
Modified: 2007-11-30 22:11 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2005-09-17 15:49:05 UTC
Type: ---

Attachments (Terms of Use)
specfile patch for new version + "rm -rf" problem (deleted)
2005-09-12 10:46 UTC, Aurelien Bompard
no flags Details | Diff

Description Konstantin Ryabitsev 2005-08-27 15:59:57 UTC
Spec Name or Url:
SRPM Name or Url:
QScintilla is a port or Scintilla to the Qt GUI toolkit from Trolltech 
and runs on any operating system supported by Qt (eg. Windows, UNIX/Linux, 

Comment 1 Aurelien Bompard 2005-09-11 14:07:31 UTC
* This is not the last version, as a result
is not available any more. Please update
* rm -rf $RPM_BUILD_ROOT should be in %install, not in %build

Comment 2 Konstantin Ryabitsev 2005-09-12 03:16:11 UTC
Hmm... Moving the rm -rf is tricky, since apparently part of the make actually
installs stuff. I'll have to see how to fix this more intelligently.

Comment 3 Aurelien Bompard 2005-09-12 10:07:11 UTC
After looking at the Makefiles, here's what I propose:

--- qscintilla.spec.orig        2005-09-12 11:36:31.000000000 +0200
+++ qscintilla.spec     2005-09-12 12:05:13.000000000 +0200
@@ -52,19 +52,27 @@

 pushd qt
 qmake qscintilla
-make %{?_smp_mflags}
+echo 'build: $(UICDECLS) $(OBJECTS) $(OBJMOC) $(SUBLIBS) $(OBJCOMP)' >> Makefile
+make %{?_smp_mflags} build

 pushd designer
 qmake designer
-make %{?_smp_mflags}
+echo 'build: $(UICDECLS) $(OBJECTS) $(OBJMOC) $(SUBLIBS) $(OBJCOMP)' >> Makefile
+make %{?_smp_mflags} build

+pushd qt
+pushd designer
 mkdir -pm 755 \
     $RPM_BUILD_ROOT%{qtdir}/include \

Comment 4 Aurelien Bompard 2005-09-12 10:46:45 UTC
Created attachment 118705 [details]
specfile patch for new version + "rm -rf" problem

This patch will not work with the newer version. Version 1.65-gpl-1.6 supports
INSTALL_ROOT, but still installs files in root during "make". Here's the patch,
adapt it as you wish, I'm not very familiar  with qmake.

Comment 5 Aurelien Bompard 2005-09-12 12:07:49 UTC
And by the way, if you could include the doc/ and example/ subdir in the -devel
package (or make a -docs subpackage), it would be nice.

Comment 6 Konstantin Ryabitsev 2005-09-12 15:07:27 UTC
Aurelien: Thanks for your help! Updated spec file and srpm available from:

Comment 7 Aurelien Bompard 2005-09-12 17:22:03 UTC
One last thing: the html documentation files in
/usr/share/doc/qscintilla-devel-1.6/Scintilla/* are executable

Comment 9 Aurelien Bompard 2005-09-14 08:52:20 UTC
Review for release 2.fc4:
* RPM name is OK
* Source qscintilla-1.65-gpl-1.6.tar.gz is the same as upstream
* Builds fine in mock
* rpmlint of qscintilla looks OK
* rpmlint of qscintilla-designer looks OK
* rpmlint of qscintilla-devel looks OK
* File list of qscintilla looks OK
* File list of qscintilla-designer looks OK
* File list of qscintilla-devel looks OK

Comment 10 Rex Dieter 2005-09-14 11:28:00 UTC
Small nitpick: it would be better/cleaner if the doc file permission fix were
done in the %prep section, instead of %install.

Comment 11 Konstantin Ryabitsev 2005-09-15 04:26:22 UTC
Yeah, that makes sense. One more small edit to move the permission fixups into

Comment 12 Aurelien Bompard 2005-09-15 06:16:49 UTC
Still looks good (even prettier :) ). APPROVED

Note You need to log in before you can comment on or make changes to this bug.