1672313 – Review Request: perl-Perl-PrereqScanner-NotQuiteLite - A tool to scan your Perl code for its prerequisites

Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 1672313 - Review Request: perl-Perl-PrereqScanner-NotQuiteLite - A tool to scan your Perl code for its prerequisites

Summary: Review Request: perl-Perl-PrereqScanner-NotQuiteLite - A tool to scan your Pe...

Keywords:
Status:	CLOSED ERRATA
Alias:	None
Product:	Fedora
Classification:	Fedora
Component:	Package Review
Sub Component:
Version:	rawhide
Hardware:	All
OS:	Linux
Priority:	medium
Severity:	medium
Target Milestone:	---
Assignee:	Jitka Plesnikova
QA Contact:	Fedora Extras Quality Assurance
Docs Contact:
URL:
Whiteboard:
Depends On:	1672274
Blocks:	1672013
TreeView+	depends on / blocked

Reported:	2019-02-04 14:15 UTC by Paul Howarth
Modified:	2019-02-18 02:03 UTC (History)
CC List:	2 users (show)
Fixed In Version:
Doc Type:	If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:	2019-02-18 02:03:47 UTC
Type:	---
Embargoed:
Dependent Products:
Flags:	jplesnik: fedora-review+

Attachments	(Terms of Use)

Description Paul Howarth 2019-02-04 14:15:21 UTC

Spec URL: http://subversion.city-fan.org/repos/cfo-repo/perl-Perl-PrereqScanner-NotQuiteLite/branches/fedora/perl-Perl-PrereqScanner-NotQuiteLite.spec

SRPM URL: http://www.city-fan.org/~paul/extras/perl-Perl-PrereqScanner-NotQuiteLite/perl-Perl-PrereqScanner-NotQuiteLite-0.9903-1.fc30.src.rpm

Description:
Perl::PrereqScanner::NotQuiteLite is yet another prerequisites scanner. It
passes almost all the scanning tests for Perl::PrereqScanner and
Module::ExtractUse (i.e. except for a few dubious ones), and runs slightly
faster than PPI-based Perl::PrereqScanner. However, it doesn't run as fast as
Perl::PrereqScanner::Lite (which uses an XS lexer).

Perl::PrereqScanner::NotQuiteLite also recognizes eval. Prerequisites in eval
are not considered as requirements, but you can collect them as suggestions.

Conditional requirements or requirements loaded in a block are treated as
recommends. No-ed modules are stored separately (since 0.94). You may or may
not need to merge them into requires.

Fedora Account System Username: pghmcfc

Comment 1 Jitka Plesnikova 2019-02-06 14:06:37 UTC

Please correct all 'FIX' issues.
Otherwise the package looks good.
Approved

Source file is ok
Summary is ok
License is ok
Description is ok

Source0 are ok
FIX: Please update URL to use link to metacpan.org
     https://metacpan.org/release/Perl-PrereqScanner-NotQuiteLite

All tests passed

BuildRequires are almost ok
FIX: Please add 'perl(if)' - t/Util.pm:12, t/scan/Util.pm:8

$ rpm -qp --requires perl-Perl-PrereqScanner-NotQuiteLite-0.9903-1.fc30.noarch.rpm | grep -v 'rpmlib' |sort | uniq -c
      1 perl(Carp)
      1 perl(constant)
      1 perl(CPAN::Meta::Prereqs)
      1 perl(CPAN::Meta::Requirements)
      1 perl(Data::Dump)
      1 perl(Exporter) >= 5.57
      1 perl(File::Basename)
      1 perl(File::Find)
      1 perl(File::Spec)
      1 perl(Getopt::Long)
      1 perl(JSON::PP)
      1 perl(lib)
      1 perl(:MODULE_COMPAT_5.28.1)
      1 perl(Module::CoreList)
      1 perl(Module::CPANfile)
      1 perl(Module::Find)
      1 perl(parent)
      1 perl(Perl::PrereqScanner::NotQuiteLite)
      1 perl(Perl::PrereqScanner::NotQuiteLite::App)
      1 perl(Perl::PrereqScanner::NotQuiteLite::Context)
      1 perl(Perl::PrereqScanner::NotQuiteLite::Util)
      1 perl(Perl::PrereqScanner::NotQuiteLite::Util::Prereqs)
      1 perl(Pod::Usage)
      1 perl(Regexp::Trie)
      1 perl(strict)
      1 perl(warnings)
      1 /usr/bin/perl
Binary requires are Ok.

$ rpm -qp --provides perl-Perl-PrereqScanner-NotQuiteLite-0.9903-1.fc30.noarch.rpm | sort | uniq -c
      1 perl(Perl::PrereqScanner::NotQuiteLite) = 0.9903
      1 perl-Perl-PrereqScanner-NotQuiteLite = 0.9903-1.fc30
      1 perl(Perl::PrereqScanner::NotQuiteLite::App)
      1 perl(Perl::PrereqScanner::NotQuiteLite::Context)
      1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::Aliased)
      1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::AnyMoose)
      1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::Autouse)
      1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::Catalyst)
      1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::ClassAccessor)
      1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::ClassAutouse)
      1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::ClassLoad)
      1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::Core)
      1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::Inline)
      1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::KeywordDeclare)
      1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::Later)
      1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::Mixin)
      1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::ModuleRuntime)
      1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::MojoBase)
      1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::Moose)
      1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::MooseXDeclare)
      1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::Only)
      1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::PackageVariant)
      1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::Plack)
      1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::POE)
      1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::Prefork)
      1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::Superclass)
      1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::Syntax)
      1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::SyntaxCollector)
      1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::TestClassMost)
      1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::TestMore)
      1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::TestRequires)
      1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::UniversalVersion)
      1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::Unless)
      1 perl(Perl::PrereqScanner::NotQuiteLite::Tokens)
      1 perl(Perl::PrereqScanner::NotQuiteLite::Util)
      1 perl(Perl::PrereqScanner::NotQuiteLite::Util::CPANfile)
      1 perl(Perl::PrereqScanner::NotQuiteLite::Util::Prereqs)
Binary provides are Ok.

$ rpmlint ./perl-Perl-PrereqScanner-NotQuiteLite*
perl-Perl-PrereqScanner-NotQuiteLite.noarch: W: spelling-error %description -l en_US ExtractUse -> Extract Use, Extract-use, Extract
perl-Perl-PrereqScanner-NotQuiteLite.noarch: W: spelling-error %description -l en_US eval -> veal, vela, val
perl-Perl-PrereqScanner-NotQuiteLite.src: W: spelling-error %description -l en_US ExtractUse -> Extract Use, Extract-use, Extract
perl-Perl-PrereqScanner-NotQuiteLite.src: W: spelling-error %description -l en_US eval -> veal, vela, val
2 packages and 1 specfiles checked; 0 errors, 4 warnings.
Rpmlint is ok

Comment 2 Jitka Plesnikova 2019-02-06 14:14:49 UTC

The 'Suggests' is not supported in EPEL 6/7

perl-Perl-PrereqScanner-NotQuiteLite.spec:Line 50
Suggests:       perl(CPAN::Common::Index)

Comment 3 Paul Howarth 2019-02-06 14:30:10 UTC

(In reply to Jitka Plesnikova from comment #2)
> The 'Suggests' is not supported in EPEL 6/7
> 
> perl-Perl-PrereqScanner-NotQuiteLite.spec:Line 50
> Suggests:       perl(CPAN::Common::Index)

I know; we don't have ExtUtils::MakeMaker::CPANfile there either so I'm only targeting f29/f30 with this package.

Accordingly, I'll update the flow to use %make_build/%make_install too.

Thanks for the review Jitka.

Comment 4 Gwyn Ciesla 2019-02-06 14:40:31 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Perl-PrereqScanner-NotQuiteLite

Comment 5 Fedora Update System 2019-02-06 16:06:47 UTC

perl-Perl-PrereqScanner-NotQuiteLite-0.9903-2.fc29 perl-Regexp-Trie-0.02-2.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-2e81a7f560

Comment 6 Fedora Update System 2019-02-06 16:06:51 UTC

perl-Perl-PrereqScanner-NotQuiteLite-0.9903-2.fc29 perl-Regexp-Trie-0.02-2.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-2e81a7f560

Comment 7 Fedora Update System 2019-02-10 04:27:14 UTC

perl-Perl-PrereqScanner-NotQuiteLite-0.9903-2.fc29, perl-Regexp-Trie-0.02-2.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-2e81a7f560

Comment 8 Fedora Update System 2019-02-18 02:03:47 UTC

perl-Perl-PrereqScanner-NotQuiteLite-0.9903-2.fc29, perl-Regexp-Trie-0.02-2.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.

Note You need to log in before you can comment on or make changes to this bug.