Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 167673 - Review Request: flow-tools - Tool set for working with NetFlow data
Summary: Review Request: flow-tools - Tool set for working with NetFlow data
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Tom "spot" Callaway
QA Contact: David Lawrence
URL: http://www.splintered.net/sw/flow-tools/
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2005-09-06 20:40 UTC by Paul P Komkoff Jr
Modified: 2015-03-18 11:16 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2005-09-08 08:24:47 UTC
Type: ---
Embargoed:
gwync: fedora-cvs+

Attachments (Terms of Use)
pre-review fixes (2.99 KB, patch)
2005-09-06 23:50 UTC, Tom "spot" Callaway 		no flags Details | Diff
View All

Description Paul P Komkoff Jr 2005-09-06 20:40:59 UTC 
Spec Name or Url: http://mirrors.sgu.ru/mm/s/SPECS/flow-tools.spec
SRPM Name or Url: http://mirrors.sgu.ru/mm/s/4/SRPMS/flow-tools-0.68-1.src.rpm
Description: 
Flow-tools is library and a collection of programs used to collect,
send, process, and generate reports from NetFlow data. The tools can be
used together on a single server or distributed to multiple servers for
large deployments. The flow-toools library provides an API for development
of custom applications for NetFlow export versions 1,5,6 and the 14 currently
defined version 8 subversions. A Perl and Python interface have been
contributed and are included in the distribution.
Comment 1 Tom "spot" Callaway 2005-09-06 23:50:24 UTC 
Created attachment 118537 [details]
pre-review fixes

There were several items I noticed in the course of the review. Specifically:

- some missing macros
- %{version} not being used in Source
- Group should be Application/System, not System Environment/Daemons
- didn't own/create %{_localstatedir}/ft/
- missing BR: autoconf
- don't need generic INSTALL
- config files not marked config(noreplace)
- don't own all directories we create
- wasn't running ldconfig on post/postun

I've attached a patch which covers these issues. Please apply this patch, and
I'll review the package.
Comment 2 Paul P Komkoff Jr 2005-09-07 05:00:00 UTC 
Apllied. Now:
Spec Name or Url: http://mirrors.sgu.ru/mm/s/SPECS/flow-tools.spec
SRPM Name or Url: http://mirrors.sgu.ru/mm/s/4/SRPMS/flow-tools-0.68-2.src.rpm
Comment 3 Tom "spot" Callaway 2005-09-07 15:39:58 UTC 
Review:

Good:

- rpmlint checks return: 
W: flow-tools-devel no-documentation
Safe to ignore.
- meets Packaging, naming guidelines
- license (BSD) OK, text in %doc, matches source
- spec in am. english, legible
- source matches upstream
- compiles on x86 devel
- no missing, unnecessary BuildRequires
- no locales
- post/postun ldconfig ok
- not relocatable
- owns all dirs it creates
- no duplicate files
- permissions ok
- clean ok
- macros consistent
- code, not content
- no need for -docs
- -devel ok
- -devel requires main package n-v-r
- not a gui app
- .la files removed


Nitpick:

- the url for Patch0 (http://stingr.net/2/flow-tools/flow-tools-0.68a.patch) is
a 404. You should either fix the URL or drop it entirely (its not needed).

APPROVED.
Comment 4 Paul P Komkoff Jr 2010-07-09 08:28:45 UTC 
Package Change Request
======================
Package Name: flow-tools
New Branches: EL-4 EL-5 EL-6
Owners: stingray orion
Comment 5 Kevin Fenzi 2010-07-09 17:57:53 UTC 
CVS done (by process-cvs-requests.py).
Comment 6 Orion Poplawski 2015-03-17 21:04:50 UTC 
Package Change Request
======================
Package Name: flow-tools
New Branches: epel7
Owners: stingray orion
Comment 7 Gwyn Ciesla 2015-03-18 11:16:15 UTC 
Git done (by process-git-requests).
Note You need to log in before you can comment on or make changes to this bug.