Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at
Bug 167863 - Review Request: gpp - gnome-photo-printer
Summary: Review Request: gpp - gnome-photo-printer
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Gérard Milmeister
QA Contact: David Lawrence
Depends On:
TreeView+ depends on / blocked
Reported: 2005-09-09 01:15 UTC by Matt Domsch
Modified: 2007-11-30 22:11 UTC (History)
1 user (show)

Fixed In Version: 0.6.5-2.fc3 and .fc3
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2005-11-11 04:06:35 UTC
Type: ---

Attachments (Terms of Use)

Description Matt Domsch 2005-09-09 01:15:19 UTC
Spec Name or Url:
SRPM Name or Url:

Gnome Photo Printer is intended for printing photos in an easy way.
Just drag your Photos from Nautilus to the Gnome Photo Printer window
and drop it.  Make some selections like Photo or Paper size, hit Preview
or  Print , and see your pictures printed.

Comment 1 Gérard Milmeister 2005-09-10 19:07:32 UTC
- in the description there are a few too many spaces, e.g., "or  Print ,"
- in the desktop file, use printer.png instead of full path; better yet would
  be a new icon, because the printer.png icon is pretty generic; maybe
  you concoct something from a printer icon and a photo icon
- in the desktop file, name should be "Gnome Photo Printer" or simply
  "Photo Printer" or simply "Print Photos"; I prefer the second, so
  there is no issue with "Gnome" and "GNOME" :-)
- in the desktop file, why is StartupNotify false? it seems to work with true
- rpmlint is completely satisfied

Comment 2 Matt Domsch 2005-09-12 04:55:43 UTC
Thanks for the review.  I fixed the description (the extra spaces are present in
the original package's description), removed the full path to printer.png,
changed .desktop Name="Photo Printer" and StartupNotify=true.  New RPMs and spec
posted to the same location.

I did not create a new icon, as *any* existing icon would be better than what I
could create myself.  If someone wishes to create an icon for this package, I'll
be happy to add it later.

The example .desktop file in
has StartupNotify=false.  Perhaps this should be changed?

Comment 3 Gérard Milmeister 2005-09-12 18:21:30 UTC
(In reply to comment #2)
> The example .desktop file in
> has StartupNotify=false.  Perhaps this should be changed?

This is a safe default. For regular GNOME apps StartupNotify=true works.
For KDE apps I don't know.

Comment 4 Gérard Milmeister 2005-09-12 20:23:21 UTC

Comment 5 Matt Domsch 2005-11-11 04:06:35 UTC
Committed to cvs and building now for FC3 and FC4.  Closing.

Note You need to log in before you can comment on or make changes to this bug.