Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 168522 - Review Request: Tagtool
Summary: Review Request: Tagtool
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Aurelien Bompard
QA Contact: David Lawrence
URL: http://pwp.netcabo.pt/paol/tagtool/
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2005-09-16 20:59 UTC by Brian Pepple
Modified: 2007-11-30 22:11 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2005-09-25 22:31:33 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Brian Pepple 2005-09-16 20:59:36 UTC 
Spec Name or Url: http://piedmont.homelinux.org/fedora/tagtool/tagtool.spec
SRPM Name or Url: http://piedmont.homelinux.org/fedora/tagtool/tagtool-0.12.2-1.src.rpm
Description: Tag Tool is a Gtk2 program to manage the information fields in MP3 and Ogg Vorbis files.
Comment 1 Aurelien Bompard 2005-09-23 21:36:31 UTC 
At first I thought that MP3 support would be a problem, but since easytag is in
extras, I guess that tagging only is OK. Anyway :
Needs work:
* Scriptlets: missing update-desktop-database (desktop file contains MimeType)

Minor:
* Duplicate BuildRequires: gtk2-devel, libxml2-devel
* FYI, %dir %{_datadir}/%{name} and %{_datadir}/%{name}/* can be merged into
%{_datadir}/%{name}/
Comment 2 Brian Pepple 2005-09-23 23:20:34 UTC 
Updated based on comment #1:
Spec File: http://piedmont.homelinux.org/fedora/tagtool/tagtool.spec

SRPM: http://piedmont.homelinux.org/fedora/tagtool/tagtool-0.12.2-2.src.rpm

* Fri Sep 23 2005 Brian Pepple <bdpepple> - 0.12.2-2
- Drop redundant BR's: gtk2-devel, libxml2-devel.
- Add missing scriplets for desktop-database.
- Merge directories.
Comment 3 Aurelien Bompard 2005-09-24 08:25:51 UTC 
Review for release 2:
* RPM name is OK
* Source tagtool-0.12.2.tar.gz is the same as upstream
* Builds fine in mock
* rpmlint of tagtool looks OK
* File list of tagtool looks OK
* Works fine.
Note You need to log in before you can comment on or make changes to this bug.