Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1688945 - babel FTBFS with pytest 4.3
Summary: babel FTBFS with pytest 4.3
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: babel
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Miro Hrončok
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PYTEST4 PYTHON38
TreeView+ depends on / blocked
 
Reported: 2019-03-14 18:26 UTC by Miro Hrončok
Modified: 2019-06-05 14:51 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-06-05 14:51:42 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)
build.log from copr (299.00 KB, text/plain)
2019-03-14 18:26 UTC, Miro Hrončok 		no flags Details
View All


Links
System ID Private Priority Status Summary Last Updated
Github python-babel babel pull 635 0 None None None 2019-03-14 18:58:13 UTC

Description Miro Hrončok 2019-03-14 18:26:12 UTC 
Created attachment 1544152 [details]
build.log from copr

While bootstrapping babel in copr for Python 3.8, I've realized it fails to run %check with pytest 4.3.

==================================== ERRORS ====================================
______ ERROR at setup of test_no_inherit_metazone_marker_never_in_output _______
file /builddir/build/BUILD/Babel-2.6.0/tests/test_dates.py, line 769
  @pytest.mark.all_locales
  def test_no_inherit_metazone_marker_never_in_output(locale):
E       fixture 'locale' not found
>       available fixtures: cache, capfd, capfdbinary, caplog, capsys, capsysbinary, doctest_namespace, monkeypatch, os_environ, pytestconfig, record_property, record_xml_attribute, recwarn, tmp_path, tmp_path_factory, tmpdir, tmpdir_factory
>       use 'pytest --fixtures [testpath]' for help on them.
/builddir/build/BUILD/Babel-2.6.0/tests/test_dates.py:769
______________________ ERROR at setup of test_smoke_dates ______________________
file /builddir/build/BUILD/Babel-2.6.0/tests/test_smoke.py, line 17
  @pytest.mark.all_locales
  def test_smoke_dates(locale):
E       fixture 'locale' not found
>       available fixtures: cache, capfd, capfdbinary, caplog, capsys, capsysbinary, doctest_namespace, monkeypatch, os_environ, pytestconfig, record_property, record_xml_attribute, recwarn, tmp_path, tmp_path_factory, tmpdir, tmpdir_factory
>       use 'pytest --fixtures [testpath]' for help on them.
/builddir/build/BUILD/Babel-2.6.0/tests/test_smoke.py:17
_____________________ ERROR at setup of test_smoke_numbers _____________________
file /builddir/build/BUILD/Babel-2.6.0/tests/test_smoke.py, line 27
  @pytest.mark.all_locales
  def test_smoke_numbers(locale):
E       fixture 'locale' not found
>       available fixtures: cache, capfd, capfdbinary, caplog, capsys, capsysbinary, doctest_namespace, monkeypatch, os_environ, pytestconfig, record_property, record_xml_attribute, recwarn, tmp_path, tmp_path_factory, tmpdir, tmpdir_factory
>       use 'pytest --fixtures [testpath]' for help on them.
/builddir/build/BUILD/Babel-2.6.0/tests/test_smoke.py:27
Comment 1 Miro Hrončok 2019-03-14 18:29:04 UTC 
The locale "fixture" should come from here:

https://github.com/python-babel/babel/blob/69cda1d2082444ed99836d92135f175d20555463/tests/conftest.py#L12
Comment 2 Felix Schwarz 2019-04-10 12:32:35 UTC 
Hi Miro: I saw your pull request which looks good to me (though I don't know much about pytest). I guess we should just pull in that patch for Fedora as there is no official Babel release with it? (I'm ok with that.)
Comment 3 Jeffrey C. Ollie 2019-04-10 14:36:14 UTC 
I'm fine with whatever you all agree on. I'm not an active maintainer anymore so someone else will need to take point on this.
Comment 4 Miro Hrončok 2019-04-10 14:40:38 UTC 
OK. I'll take this and either use our patch or update when the time comes. Thanks
Comment 5 Miro Hrončok 2019-06-05 14:51:42 UTC 
2.7.0 includes this
Note You need to log in before you can comment on or make changes to this bug.