Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1693826 - ffwayland renders lastpass past the right side edge of firefox
Summary: ffwayland renders lastpass past the right side edge of firefox
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Fedora
Classification: Fedora
Component: mutter
Version: 30
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Martin Stransky
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: ffwayland
TreeView+ depends on / blocked
 
Reported: 2019-03-28 17:56 UTC by Chris Murphy
Modified: 2019-07-23 13:29 UTC (History)
17 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-07-23 13:29:45 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)
screenshot 1, Xwayland (1.55 MB, image/png)
2019-03-28 17:58 UTC, Chris Murphy 		no flags Details
screenshot 2, Wayland (1.47 MB, image/png)
2019-03-28 17:59 UTC, Chris Murphy 		no flags Details
single display screenshot (121.73 KB, image/png)
2019-03-28 23:24 UTC, Chris Murphy 		no flags Details
View All

Description Chris Murphy 2019-03-28 17:56:40 UTC 
Description of problem:

Firefox XWayland, clicking on Lastpass icon displays on only a single display (correct behavior).

Firefox Wayland, clicking on Lastpass icon causes the Lastpass "box" to partially display on both displays.



Version-Release number of selected component (if applicable):
firefox-66.0.1-1.fc30.x86_64

How reproducible:
Always


Steps to Reproduce:
1. Launch Firefox Wayland
2. double click top bar to make it full screen
3. click on Lastpass icon


Actual results:

the lastpass box content is split across two displays

Expected results:

the lastpass box should be on a single display, the display that has firefox on it

Additional info:


If I skip step 2 and just resize so I can see lastpass icon without going full screen, problem still happens. It's somehow just rendering wrong, i.e. the floating box is rendered to the right of Firefox rather than being bounded by Firefox's right hand edge.
Comment 1 Chris Murphy 2019-03-28 17:58:29 UTC 
Created attachment 1549166 [details]
screenshot 1, Xwayland

This works as expected.
Comment 2 Chris Murphy 2019-03-28 17:59:44 UTC 
Created attachment 1549167 [details]
screenshot 2, Wayland

This does not work as expected. Lastpass is split between the two monitors, of course the screenshot pretends the two displays are perfectly aligned which they aren't in reality. So the UX  here is far worse than the screenshot suggests.
Comment 3 Chris Murphy 2019-03-28 18:02:33 UTC 
In the wayland case, clicking anywhere in the lastpass box is a no op. I can type a password but clicking on anything in the box (the login button or any of the checkboxes or to any field) does nothing but deselect. So if the password box is selected and I click anywhere in the lastpass box, the password box is deselected and can't be selected again except by keyboard (tab).
Comment 4 Chris Murphy 2019-03-28 23:24:18 UTC 
Created attachment 1549242 [details]
single display screenshot

The problem affects single display use case as well; the addon's box is mostly rendered outside of the display.
Comment 5 Martin Stransky 2019-03-29 12:54:12 UTC 
Yes, I can see that.
Comment 6 Chris Murphy 2019-04-01 05:18:46 UTC 
I think this is a dup of 1693437. I use layout.css.devPixelsPerPx 1.3 and if I reset it the problem usually doesn't happen. It does happen maybe 1 in 12 attempts.
Comment 7 Martin Stransky 2019-04-01 07:40:54 UTC 
I can reproduce it even without partial scale.
Comment 8 Martin Stransky 2019-04-01 12:53:42 UTC 
Hm, this looks like a mutter bug. The window is positioned by Firefox twice but the second gdk_window_move_to_rect() request is ignored. Simple replace gdk_window_move_to_rect() > gtk_window_move() fixes that. Moving to mutter.
Comment 9 Martin Stransky 2019-04-01 12:55:50 UTC 
Let's wait to mutter-3.32.1 - it should have fixes for gdk_window_move_to_rect().
Comment 10 Martin Stransky 2019-05-02 11:23:45 UTC 
Can you please retest on latest Fedora 30 with mutter-3.32.1? Thanks.
Comment 11 Chris Murphy 2019-05-02 16:37:58 UTC 
I'm on mutter-3.32.1-1.fc30.x86_64 and the problem still happens.
Comment 12 Martin Stransky 2019-07-23 13:29:45 UTC 
Should be fixed in Firefox 69 - https://bugzilla.mozilla.org/show_bug.cgi?id=1562141
Note You need to log in before you can comment on or make changes to this bug.