Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1697254 - opencv-4.2.0 is available
Summary: opencv-4.2.0 is available
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: opencv
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Nicolas Chauvet (kwizart)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1735438
TreeView+ depends on / blocked
 
Reported: 2019-04-08 08:27 UTC by Upstream Release Monitoring
Modified: 2020-01-29 23:07 UTC (History)
15 users (show)

Fixed In Version:
Doc Type: Enhancement
Doc Text:
Clone Of:
: 1771313 (view as bug list)
Environment:
Last Closed: 2020-01-29 23:07:27 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Upstream Release Monitoring 2019-04-08 08:27:29 UTC
Latest upstream release: 4.1.0
Current version/release in rawhide: 3.4.4-7.fc31
URL: http://opencv.org/

Please consult the package updates policy before you issue an update to a stable branch: https://fedoraproject.org/wiki/Updates_Policy

More information about the service that created this bug can be found at: https://fedoraproject.org/wiki/Upstream_release_monitoring

Please keep in mind that with any upstream change, there may also be packaging changes that need to be made. Specifically, please remember that it is your responsibility to review the new version to ensure that the licensing is still correct and that no non-free or legally problematic items have been added upstream.

Based on the information from anitya:  https://release-monitoring.org/project/6615/

Comment 1 Upstream Release Monitoring 2019-04-08 14:05:21 UTC
Latest upstream release: 4.1.0-openvino
Current version/release in rawhide: 3.4.4-7.fc31
URL: http://opencv.org/

Please consult the package updates policy before you issue an update to a stable branch: https://fedoraproject.org/wiki/Updates_Policy

More information about the service that created this bug can be found at: https://fedoraproject.org/wiki/Upstream_release_monitoring

Please keep in mind that with any upstream change, there may also be packaging changes that need to be made. Specifically, please remember that it is your responsibility to review the new version to ensure that the licensing is still correct and that no non-free or legally problematic items have been added upstream.

Based on the information from anitya:  https://release-monitoring.org/project/6615/

Comment 2 Upstream Release Monitoring 2019-08-16 18:30:57 UTC
Latest upstream release: 4.1.1-openvino
Current version/release in rawhide: 3.4.6-6.fc31
URL: http://opencv.org/

Please consult the package updates policy before you issue an update to a stable branch: https://fedoraproject.org/wiki/Updates_Policy


More information about the service that created this bug can be found at: https://fedoraproject.org/wiki/Upstream_release_monitoring


Please keep in mind that with any upstream change, there may also be packaging changes that need to be made. Specifically, please remember that it is your responsibility to review the new version to ensure that the licensing is still correct and that no non-free or legally problematic items have been added upstream.


Based on the information from anitya: https://release-monitoring.org/project/6615/

Comment 3 Upstream Release Monitoring 2019-08-16 18:31:03 UTC
The following Sources of the specfile are not valid URLs so we cannot automatically build the new version for you.  Please use URLs in your Source declarations if possible.

- opencv-clean-4.1.1.tar.gz
- opencv_contrib-clean-4.1.1.tar.gz

Comment 4 Christopher N. Hesse 2019-08-22 11:19:18 UTC
Hi everyone,

it seems like no one is currently working on updating OpenCV within Fedora.
I talked to Andreas Schneider (asn) and he told me to come here to discuss the matter.
A while ago, I updated the Fedora spec to OpenCV 4.1.0 and have tested it with my own software for more than three months.
I have several years of experience in working with OpenCV and integrating/packaging software (especially on Yocto Linux).
Now I'd like to apply for co-maintainership of the OpenCV package within Fedora.

You can find my current OpenCV 4.1.0 builds for Fedora 30 and Rawhide in my COPR: https://copr.fedorainfracloud.org/coprs/raymanfx/opencv.
The source modifications (mostly .spec work) is here: https://github.com/raymanfx/fedora_rpms/tree/f30/opencv.

According to the Fedora wiki: https://fedoraproject.org/wiki/Releases/31/Schedule, the code freeze for Fedora 31 happens on the 29th of August. I'd like to get the 4.1.0 update in before that, so it makes it into the F31 release if possible.
Is anyone willing to test the build in my COPR?

Comment 5 Nicolas Chauvet (kwizart) 2019-08-22 12:08:17 UTC
Hello Christopher,

Thx very much for this work. This helps a lot.
What would be nice is to have some of the dependencies rebuilt into your copr (to see if it is safe for others).

Can you test that on your side ?
Thx in advance.

Comment 6 Christopher N. Hesse 2019-08-22 12:53:32 UTC
Sure, what kind of dependencies are we talking about here?
Do you mean direct dependencies of OpenCV itself or packages which depend on OpenCV?
I guess it's the latter, but just to make sure.
Do you have a good example in mind? I'll search trough the official Fedora repos to see if I can find some good candidates.

Comment 7 Christopher N. Hesse 2019-08-22 13:03:00 UTC
The only package I could find is "php-facedetect" (doing repoquery --whatrequires opencv).
I'm not familiar with php at all, not sure if I can work that out in time.

Additional notes:
I just kicked of a new build in my COPR and while that seems to be fine for F30, it errors in Rawhide due to the recent java binding additions.
The log is here: https://copr-be.cloud.fedoraproject.org/results/raymanfx/opencv/fedora-rawhide-x86_64/01014876-opencv/builder-live.log.gz.
Basically, the issue is this: "error: line 216: Illegal char ')' (0x29) in: Obsoletes:  libopencv_java.so(x86-64) < 4.1.0-1.fc32".
So I guess something changed in the RPM infrastructure in F31/Rawhide? Do you know what to do here offhand?

Comment 8 Nicolas Chauvet (kwizart) 2019-08-22 13:05:41 UTC
sudo dnf repoquery --whatrequires libopencv_\* --source 

(but there is a need to run this against rawhide enabling the appropriate repositories)

On my f29 system it gives:
( don't need to handle the rpmfusion packages).

OpenImageIO-1.8.14-1.fc29.src.rpm
OpenImageIO-1.8.16-1.fc29.src.rpm
YafaRay-3.3.0-12.fc29.src.rpm
YafaRay-3.3.0-18.20190223git.fc29.src.rpm
digikam-5.9.0-2.fc29.src.rpm
digikam-6.1.0-6.fc29.src.rpm
fawkes-1.0.1-18.fc29.src.rpm
frei0r-plugins-1.6.1-6.fc29.src.rpm
gmic-2.3.6-1.fc29.src.rpm
gmic-2.6.6-1.fc29.src.rpm
libfreenect-0.5.7-4.fc29.src.rpm
lives-2.10.0-1.fc29.src.rpm
lives-2.10.2-1.fc29.src.rpm
mlt-6.10.0-4.fc29.src.rpm
mrpt-1.4.0-9.fc29.src.rpm
nomacs-3.8.1-0.3.20180223git9b305e2.fc29.src.rpm
opencv-3.4.1-6.fc29.src.rpm
os-autoinst-4.5-15.20190312git1080c39.fc29.src.rpm
os-autoinst-4.5-7.20180208gitab8eeda.fc29.src.rpm
performous-1.1-3.fc29.src.rpm
php-facedetect-1.2.0-0.4.20180306gitc717941.fc29.src.rpm
player-3.1.0-8.fc29.src.rpm
simarrange-0.0-18.20170316git8238ce5.fc29.src.rpm
simon-0.4.1-18.fc29.src.rpm
siril-0.9.11-1.fc29.src.rpm
siril-0.9.9-6.fc29.src.rpm
waifu2x-converter-cpp-5.3.1-1.fc29.src.rpm

Comment 9 Sergio Basto 2019-08-22 13:48:53 UTC
(In reply to Christopher N. Hesse from comment #4)
> Hi everyone,
> 
> it seems like no one is currently working on updating OpenCV within Fedora.
> I talked to Andreas Schneider (asn) and he told me to come here to discuss
> the matter.
> A while ago, I updated the Fedora spec to OpenCV 4.1.0 and have tested it
> with my own software for more than three months.
> I have several years of experience in working with OpenCV and
> integrating/packaging software (especially on Yocto Linux).
> Now I'd like to apply for co-maintainership of the OpenCV package within
> Fedora.
> 
> You can find my current OpenCV 4.1.0 builds for Fedora 30 and Rawhide in my
> COPR: https://copr.fedorainfracloud.org/coprs/raymanfx/opencv.
> The source modifications (mostly .spec work) is here:
> https://github.com/raymanfx/fedora_rpms/tree/f30/opencv.
> 
> According to the Fedora wiki:
> https://fedoraproject.org/wiki/Releases/31/Schedule, the code freeze for
> Fedora 31 happens on the 29th of August. I'd like to get the 4.1.0 update in
> before that, so it makes it into the F31 release if possible.
> Is anyone willing to test the build in my COPR?

Hi,
Thanks for this work .
For you catch what I already had done, here [1] I already mention "I also built and have prepared opencv.spec for 4.1 but breaks a lot of
build of dependencies "

You need rebase your spec with the lastest commits [2] , I'm currently on holidays until Monday 2 September. 


[1]
 https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/G33SPJ2FQ7KVVJUTRQOBO6R3OTHYUDT3/


[2]
f380cb6 (HEAD -> master, origin/master, origin/HEAD) Rebuilt for Python 3.8
7ceebee (origin/f31) - Rebuilt for https://fedoraproject.org/wiki/Fedora_31_Mass_Rebuild
eefb8f5 Rebuild for coin-or package updates.
f1638db cmake: use relative PATH on OPENCV_CONFIG_INSTALL_PATH, fixes rhbz #1721876 cmake: don't set ENABLE_PKG_CONFIG
44a9724 Remove Obsoletes/Provides libopencv_java.so and use OPENCV_JAR_INSTALL_PATH
dd2b657 Fix cmakes location
2cdf5ee Fixed uploaded sources
35e6529 Update to 3.4.6
3c68ac1 (origin/f30, f30) Try improve Java Bindings
bb5bb8e Fix typo
8572c73 Obsolets python2-opencv to fix upgrade path
3b82c76 Enable Java Bindings (contribution of Ian Wallace)

Comment 10 Sergio Basto 2019-08-22 13:56:08 UTC
(In reply to Nicolas Chauvet (kwizart) from comment #8)
> sudo dnf repoquery --whatrequires libopencv_\* --source 
> 
> (but there is a need to run this against rawhide enabling the appropriate
> repositories)
> 
> On my f29 system it gives:
> ( don't need to handle the rpmfusion packages).
> 
> OpenImageIO-1.8.14-1.fc29.src.rpm
> OpenImageIO-1.8.16-1.fc29.src.rpm
> YafaRay-3.3.0-12.fc29.src.rpm
> YafaRay-3.3.0-18.20190223git.fc29.src.rpm
> digikam-5.9.0-2.fc29.src.rpm
> digikam-6.1.0-6.fc29.src.rpm
> fawkes-1.0.1-18.fc29.src.rpm
> frei0r-plugins-1.6.1-6.fc29.src.rpm
> gmic-2.3.6-1.fc29.src.rpm
> gmic-2.6.6-1.fc29.src.rpm
> libfreenect-0.5.7-4.fc29.src.rpm
> lives-2.10.0-1.fc29.src.rpm
> lives-2.10.2-1.fc29.src.rpm
> mlt-6.10.0-4.fc29.src.rpm
> mrpt-1.4.0-9.fc29.src.rpm
> nomacs-3.8.1-0.3.20180223git9b305e2.fc29.src.rpm
> opencv-3.4.1-6.fc29.src.rpm
> os-autoinst-4.5-15.20190312git1080c39.fc29.src.rpm
> os-autoinst-4.5-7.20180208gitab8eeda.fc29.src.rpm
> performous-1.1-3.fc29.src.rpm
> php-facedetect-1.2.0-0.4.20180306gitc717941.fc29.src.rpm
> player-3.1.0-8.fc29.src.rpm
> simarrange-0.0-18.20170316git8238ce5.fc29.src.rpm
> simon-0.4.1-18.fc29.src.rpm
> siril-0.9.11-1.fc29.src.rpm
> siril-0.9.9-6.fc29.src.rpm
> waifu2x-converter-cpp-5.3.1-1.fc29.src.rpm

you may try rebuild all these packages in your copr project

Comment 11 Christopher N. Hesse 2019-08-23 12:06:01 UTC
(In reply to Nicolas Chauvet (kwizart) from comment #8)
> sudo dnf repoquery --whatrequires libopencv_\* --source 
> 
> (but there is a need to run this against rawhide enabling the appropriate
> repositories)
> 
> On my f29 system it gives:
> ( don't need to handle the rpmfusion packages).
> 
> ..

Looks good, I can surely find some candidates in that list.
Thinking about it, I expect almost *all* of those to break when compiling against OpenCV 4.x.
This is because of some major API changes (e.g. the change in the color converter enums) like

OpenCV 3.4.x: "CV_BGR2RGBA"
OpenCV 4.x.x: "cv::COLOR_BGR2RGBA"

There are more changes like these that are highly likely to break any application building against OpenCV.
What is your preferred way to handle this?
I can envision taking the "easy" way out and renaming the current spec to something like "opencv-3" and then have the main "opencv" spec ship OpenCV 4.x.
That of course requires manually updating all the specs of the existing packages to build against opencv-3 in F31 going forward at least.
Better ideas are welcome though, this is my first time of really contributing to Fedora.

(In reply to Sergio Monteiro Basto from comment #9)
> (In reply to Christopher N. Hesse from comment #4)
> > Hi everyone,
> > 
> > it seems like no one is currently working on updating OpenCV within Fedora.
> > I talked to Andreas Schneider (asn) and he told me to come here to discuss
> > the matter.
> > A while ago, I updated the Fedora spec to OpenCV 4.1.0 and have tested it
> > with my own software for more than three months.
> > I have several years of experience in working with OpenCV and
> > integrating/packaging software (especially on Yocto Linux).
> > Now I'd like to apply for co-maintainership of the OpenCV package within
> > Fedora.
> > 
> > You can find my current OpenCV 4.1.0 builds for Fedora 30 and Rawhide in my
> > COPR: https://copr.fedorainfracloud.org/coprs/raymanfx/opencv.
> > The source modifications (mostly .spec work) is here:
> > https://github.com/raymanfx/fedora_rpms/tree/f30/opencv.
> > 
> > According to the Fedora wiki:
> > https://fedoraproject.org/wiki/Releases/31/Schedule, the code freeze for
> > Fedora 31 happens on the 29th of August. I'd like to get the 4.1.0 update in
> > before that, so it makes it into the F31 release if possible.
> > Is anyone willing to test the build in my COPR?
> 
> Hi,
> Thanks for this work .
> For you catch what I already had done, here [1] I already mention "I also
> built and have prepared opencv.spec for 4.1 but breaks a lot of
> build of dependencies "
> 
> You need rebase your spec with the lastest commits [2] , I'm currently on
> holidays until Monday 2 September. 
> 
> 
> [1]
>  https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/
> thread/G33SPJ2FQ7KVVJUTRQOBO6R3OTHYUDT3/
> 
> 
> [2]
> f380cb6 (HEAD -> master, origin/master, origin/HEAD) Rebuilt for Python 3.8
> 7ceebee (origin/f31) - Rebuilt for
> https://fedoraproject.org/wiki/Fedora_31_Mass_Rebuild
> eefb8f5 Rebuild for coin-or package updates.
> f1638db cmake: use relative PATH on OPENCV_CONFIG_INSTALL_PATH, fixes rhbz
> #1721876 cmake: don't set ENABLE_PKG_CONFIG
> 44a9724 Remove Obsoletes/Provides libopencv_java.so and use
> OPENCV_JAR_INSTALL_PATH
> dd2b657 Fix cmakes location
> 2cdf5ee Fixed uploaded sources
> 35e6529 Update to 3.4.6
> 3c68ac1 (origin/f30, f30) Try improve Java Bindings
> bb5bb8e Fix typo
> 8572c73 Obsolets python2-opencv to fix upgrade path
> 3b82c76 Enable Java Bindings (contribution of Ian Wallace)

Hi, good to know someone else also works on 4.x for Fedora.
I think you missed my latest spec, I rebased against the latest F30 branch yesterday, all those commits you mentioned are already part of my spec tree.
The problem I mentioned earlier still stands though - the addition of the Java bindings stuff breaks the build in Rawhide.
I'll take a closer look at the issue this weekend.

Comment 12 Sergio Basto 2019-08-26 00:43:39 UTC
(In reply to Christopher N. Hesse from comment #11)

> Hi, good to know someone else also works on 4.x for Fedora.
> I think you missed my latest spec, I rebased against the latest F30 branch
> yesterday, all those commits you mentioned are already part of my spec tree.

No , my new commits are only on F31 branch , you need to rebase to F31 sorry 

> The problem I mentioned earlier still stands though - the addition of the
> Java bindings stuff breaks the build in Rawhide.
> I'll take a closer look at the issue this weekend.

It is fixed on F31 branch

Comment 13 Sergio Basto 2019-08-26 01:37:50 UTC
Please take a look on [1] thinking better it will help more if you rebase against master branch 

Thanks ! 

[1]
https://src.fedoraproject.org/rpms/opencv/commits/master

Comment 14 Nicolas Chauvet (kwizart) 2019-08-27 07:06:59 UTC
We have entered the beta freeze, so it's not worth to break dependencies during Beta.
Best would be to build the opencv update after Beta.

I guess the Obsoletes is wrong, one doesn't need to obsoletes with arches, so you need to drop the %{_isa} macro for Obsoletes.
(that will fix opencv in rawhide).


What is the status for rebuilding packages that depend on opencv ?(in the copr repo)

Comment 15 Christopher N. Hesse 2019-08-27 09:26:23 UTC
(In reply to Sergio Monteiro Basto from comment #13)
> Please take a look on [1] thinking better it will help more if you rebase
> against master branch 
> 
> Thanks ! 
> 
> [1]
> https://src.fedoraproject.org/rpms/opencv/commits/master

I rebased against F31 now (which resolved the issue with the wrong obsoletes), will push it to my GitHub later.

(In reply to Nicolas Chauvet (kwizart) from comment #14)
> We have entered the beta freeze, so it's not worth to break dependencies
> during Beta.
> Best would be to build the opencv update after Beta.
> 
> I guess the Obsoletes is wrong, one doesn't need to obsoletes with arches,
> so you need to drop the %{_isa} macro for Obsoletes.
> (that will fix opencv in rawhide).
> 
> 
> What is the status for rebuilding packages that depend on opencv ?(in the
> copr repo)

I agree.
The problem however still stands: OpenCV 4 breaks the API (as expected given it's a major version increase).

Did you already think about how you want to handle this?
While I would like to go ahead and just update it and rename opencv to opencv3 for the old version, I don't think that's a sensible approach as a platform. Fedora (and other distros) still have "python" point to python2 not to break any scripts.
Should we just rename the updated version to "opencv4" and keep the old one available as "opencv" (version 3)?

The problem is that there is of course overlap in the installed files between these two, so one cannot have both "opencv" and "opencv4" installed at the same time. While we could rename the binaries in those packages, at least the -devel ones will crash inevitably (think headers, cmake files etc whose names we cannot change).

Let me know which way we want to go. If you decide to name it "opencv4", no package rebuilding needs to happen I guess.
Otherwise, we'd need to patch almost all of those repos to use the new opencv4 API (which should be simple changes, really, but it's hard to tell before really getting into it).

Comment 16 Nicolas Chauvet (kwizart) 2019-08-27 10:00:55 UTC
Sorry that's opencv4 out of the question as Fedora is concerned.
The fedora way is to update packages in master (not f31, so anything broken in master has to be corrected in the first step).
Once done, we will be able to update in f31 (after beta). Updating

The others point about dependencies is that is there are API changes, there is a need to look ahead if dependent packages will pick the new API or now.
That's what I mean by rebuilding the dependencies in your copr project.
You need to fedpkg clone foo and fedpkg srpm and upload the src.rpm into your copr project (eventually fix the build if the fix is easy)

Please try to submit a PR on pagure (aka src.fedoraproject.org) with the "master" branch so we can start reviewing.

Comment 17 Sergio Basto 2019-09-03 00:01:40 UTC
(In reply to Christopher N. Hesse from comment #15)
> (In reply to Sergio Monteiro Basto from comment #13)
> > Please take a look on [1] thinking better it will help more if you rebase
> > against master branch 
> > 
> > Thanks ! 
> > 
> > [1]
> > https://src.fedoraproject.org/rpms/opencv/commits/master
> 
> I rebased against F31 now (which resolved the issue with the wrong
> obsoletes), will push it to my GitHub later.

Is not yet updated or I'm missing something ? 

If depends on me , we will just have one opencv , more than overlap files , is a double work. But we need to check the dependent packages , to find out if we have any package that is critic and still depends on opencv3.
As I state before the problem is that almost all dependent packages fails to build  with opencv4 , so we need to wait for support and fixes for opencv4 ...

Comment 18 Christopher N. Hesse 2019-09-03 08:10:53 UTC
Hi, the work on my part is done, but I still need to update my GitHub repo. I'll do that in 2-3 hours.

Regarding the pull request on Pagure, I'm still fighting the Fedora infrastructure it seems. There's no apparent way for me to add ssh keys and the one I registered through FAS does not let me push to my Pagure repo.

Comment 19 Mattia Verga 2019-09-12 14:12:58 UTC
(In reply to Christopher N. Hesse from comment #15)
> Did you already think about how you want to handle this?
> While I would like to go ahead and just update it and rename opencv to
> opencv3 for the old version, I don't think that's a sensible approach as a
> platform. Fedora (and other distros) still have "python" point to python2
> not to break any scripts.
> Should we just rename the updated version to "opencv4" and keep the old one
> available as "opencv" (version 3)?
> 

I remember this has been discussed in the past in the devel mailing list about other packages... I don't remember what was decided to be the final solution and I can't find anything in the packaging guidelines.

I'd suggest you 1) to open a discussion on devel mailing list and 2) to open a System-Wide Change Proposal for F32.

Comment 20 Sergio Basto 2019-09-12 23:02:26 UTC
(In reply to Christopher N. Hesse from comment #18)
> Hi, the work on my part is done, but I still need to update my GitHub repo.
> I'll do that in 2-3 hours.

https://github.com/raymanfx/fedora_rpms/ still not updated 

> Regarding the pull request on Pagure, I'm still fighting the Fedora
> infrastructure it seems. There's no apparent way for me to add ssh keys and
> the one I registered through FAS does not let me push to my Pagure repo.

After login in [1] account -> edit and upload Public RSA SSH Key: , so your fas user will be able with ssh key will be able to use git authenticated. 
I use in  ~/.ssh/config [2] , and [3] may be used for apps, I think, I don't use it , I think also. 
api-key and not ssh-keys is needed , on other different site https://pagure.io ,  you got the 2 options (API Keys and SSH Keys) , copr just use api-keys I think. 

Best regards,

[1] 
https://admin.fedoraproject.org/accounts 

[2] 
    Host fedorapeople.org
    User sergiomb
    IdentityFile ~/.ssh/id_rsa

[3]
https://src.fedoraproject.org/settings -> api keys -> create new api keys -> toggle all -> create

Comment 21 Sergio Basto 2019-09-12 23:05:58 UTC
Fixing typos sorry 

After login in [1] account -> edit and upload Public RSA SSH Key: , so with your fas user and with ssh key you will be able to use git authenticated (git clone ssh://sergiomb.org/rpms/opencv.git)

I use in  ~/.ssh/config [2] , and [3] may be used for apps, I think, I don't use it , I think also. 
ssh-keys  and not api-key is needed , on other different site https://pagure.io ,  you got the 2 options (API Keys and SSH Keys) , copr just use api-keys I think.

Comment 22 Christopher N. Hesse 2019-09-13 19:42:36 UTC
I would have done that a long time ago - if it worked..
My public SSH key (that I use for GitHub and many other platforms) is registered with FAS and correctly displayed.
Still I cannot push to my forked OpenCV repo on pkgs.fedoraproject.org.
I have been using this SSH key for many years with multiple OSS projects, Gerrit instances and whatnot, I'm fairly sure I'm doing that right.

Pushing to ssh://raymanfx.org/forks/raymanfx/rpms/opencv.git fails with the standard error: Permission denied (publickey). It's rather frustrating for my first time contribution to be honest.
In the meantime, I uploaded the repo with my changes to https://github.com/raymanfx/fedora_opencv.
Maybe someone else could open a pull request with my commit?
If changes are requested, I will just update that GitHub repo and you can update the Pagure pull request.

Comment 23 Nicolas Chauvet (kwizart) 2019-09-13 22:11:00 UTC
Okay, I've tried to rebase and merge what everyone is doing on it's side (but no build yet - on purpose ).

The idea is to concentrate to land this to rawhide (first) and f31+ (freeze is in less than a month, so it's still doable).
I'm going to test dependencies into https://copr.fedorainfracloud.org/coprs/kwizart/opencv4/

@Christopher
Please remind that current upstream source tree is src.fedoraproject.org (and not pkgs or pagure).
You need to clone using fedpkg clone opencv and put you ssh pub key in admin.fedoraproject.org/accounts

Comment 24 Sergio Basto 2019-09-14 01:13:02 UTC
(In reply to Christopher N. Hesse from comment #22)
> I would have done that a long time ago - if it worked..
> My public SSH key (that I use for GitHub and many other platforms) is
> registered with FAS and correctly displayed.
> Still I cannot push to my forked OpenCV repo on pkgs.fedoraproject.org.
> I have been using this SSH key for many years with multiple OSS projects,
> Gerrit instances and whatnot, I'm fairly sure I'm doing that right.
> 
> Pushing to
> ssh://raymanfx.org/forks/raymanfx/rpms/opencv.git fails
> with the standard error: Permission denied (publickey). It's rather
> frustrating for my first time contribution to be honest.

what says [1] ? or if not enough [2] ? you should be close  

[1]
GIT_SSH_COMMAND="ssh -v" ssh://raymanfx.org/forks/raymanfx/rpms/opencv.git 

[2] 
GIT_SSH_COMMAND="ssh -vv" ssh://raymanfx.org/forks/raymanfx/rpms/opencv.git

Comment 25 Sergio Basto 2019-09-15 14:05:17 UTC
(In reply to Mattia Verga from comment #19)
> I remember this has been discussed in the past in the devel mailing list
> about other packages... I don't remember what was decided to be the final
> solution and I can't find anything in the packaging guidelines.
> 
> I'd suggest you 1) to open a discussion on devel mailing list and 2) to open
> a System-Wide Change Proposal for F32.

yes I think we should open a System-Wide Change Proposal for F32 , any volunteer ?

Comment 26 Mattia Verga 2019-09-17 08:45:10 UTC
(In reply to Nicolas Chauvet (kwizart) from comment #23)

> The idea is to concentrate to land this to rawhide (first) and f31+ (freeze
> is in less than a month, so it's still doable).

Please don't. F31 is in Beta Freeze and you need a FESCO exception to do that.
Since upgrading OpenCV involves so many packages, the correct way to do that is opening a System-Wide Change Proposal for F32.

And, please, coordinate your work with the maintainers of the affected packages for correctness: announce this on the devel list and CC to package-maintainer

Comment 27 Nicolas Chauvet (kwizart) 2019-09-17 10:30:29 UTC
I've submitted rebuilt on copr https://copr.fedorainfracloud.org/coprs/kwizart/opencv4/builds/ for f31+ (assuming no changes in devel/f31).
This will speed-up to discover issues. I will warn maintainers once finished.

(there is already one failure).

Comment 28 Nicolas Chauvet (kwizart) 2019-09-17 10:39:20 UTC
@Mattia
My understanding is that no all ABI changes needs a Change proposal. From the past, OpenCV has never done any change request. (It doesn't mean it cannot be done in the future).
Another point is that OpenCV is severely outdated and I'm expecting few issues to arise because of that.

So for updating f31, we are in the post-beta phase
https://fedoraproject.org/wiki/Updates_Policy#Beta_to_Pre_Release
*A void Major version updates, ABI breakage or API changes if at all possible.

So my understanding is that this can still be discussed, and that's what I'm planning to do...

Comment 29 Sergio Basto 2019-09-17 23:30:03 UTC
Many fails [1] seeings results from https://copr.fedorainfracloud.org/coprs/kwizart/opencv4/monitor/ and 6 built well ... 

[1]
fawkes 	
frei0r-plugins 	
gmic 
libfreenect 
mrpt 
os-autoinst 
player 	
simarrange 
YafaRay  (just on arches aarch64 and ppc64le)

Comment 30 Upstream Release Monitoring 2019-10-11 18:46:06 UTC
Latest upstream release: 4.1.2-openvino
Current version/release in rawhide: 3.4.6-9.fc32
URL: http://opencv.org/

Please consult the package updates policy before you issue an update to a stable branch: https://fedoraproject.org/wiki/Updates_Policy


More information about the service that created this bug can be found at: https://fedoraproject.org/wiki/Upstream_release_monitoring


Please keep in mind that with any upstream change, there may also be packaging changes that need to be made. Specifically, please remember that it is your responsibility to review the new version to ensure that the licensing is still correct and that no non-free or legally problematic items have been added upstream.


Based on the information from anitya: https://release-monitoring.org/project/6615/

Comment 31 Upstream Release Monitoring 2019-10-11 18:46:11 UTC
The following Sources of the specfile are not valid URLs so we cannot automatically build the new version for you.  Please use URLs in your Source declarations if possible.

- opencv-clean-4.1.2.tar.gz
- opencv_contrib-clean-4.1.2.tar.gz
- face_landmark_model.dat.xz

Comment 32 josef radinger 2019-10-18 18:46:27 UTC
gmic should build OK with a patch i imported for rawhide

Comment 33 Upstream Release Monitoring 2019-12-21 03:39:06 UTC
Latest upstream release: 4.2.0
Current version/release in rawhide: 3.4.8-1.fc32
URL: http://opencv.org/

Please consult the package updates policy before you issue an update to a stable branch: https://fedoraproject.org/wiki/Updates_Policy


More information about the service that created this bug can be found at: https://fedoraproject.org/wiki/Upstream_release_monitoring


Please keep in mind that with any upstream change, there may also be packaging changes that need to be made. Specifically, please remember that it is your responsibility to review the new version to ensure that the licensing is still correct and that no non-free or legally problematic items have been added upstream.


Based on the information from anitya: https://release-monitoring.org/project/6615/

Comment 34 Upstream Release Monitoring 2019-12-21 03:39:13 UTC
The following Sources of the specfile are not valid URLs so we cannot automatically build the new version for you.  Please use URLs in your Source declarations if possible.

- opencv-clean-4.2.0.tar.gz
- opencv_contrib-clean-4.2.0.tar.gz
- face_landmark_model.dat.xz
- opencv-4.x-deprecated-headers.tar.xz

Comment 35 Nicolas Chauvet (kwizart) 2019-12-30 16:48:23 UTC
Seems like we are nearing completion of OpenCV 4.1.2 in rawhide. (next will be OpenCV 4.2... at a later point)

- There is mrtp that would remains to be fixed, but given that upstream is at 1.5.7 and fedora still 1.4.0, I guess we need to find a new mrtp maintainer...
I might disable opencv support until it can be fixed or dropped.

- fawkes might be looked into once player might succeed (done locally) that will allow to fix one of it's dependency can be rebuilt (prevented because player was not installable).

Comment 36 Nicolas Chauvet (kwizart) 2020-01-27 23:06:12 UTC
opencv 4.2.0 is pushed in master...

All packages are working with opencv 4.2 https://copr.fedorainfracloud.org/coprs/kwizart/opencv4/packages/

Comment 37 Nicolas Chauvet (kwizart) 2020-01-29 23:07:27 UTC
side-tag merged into f32


Note You need to log in before you can comment on or make changes to this bug.