Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 170511 - Review Request: perl-Cflow - find flows in flow files
Summary: Review Request: perl-Cflow - find flows in flow files
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Paul Howarth
QA Contact: David Lawrence
URL: http://www.cora.nwra.com/~orion/fedora/
Whiteboard:
Depends On: 171206
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2005-10-12 14:28 UTC by Orion Poplawski
Modified: 2007-11-30 22:11 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2005-10-19 15:38:15 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Orion Poplawski 2005-10-12 14:28:18 UTC 
Spec Name or Url: http://www.cora.nwra.com/~orion/fedora/perl-Cflow.spec
SRPM Name or Url: http://www.cora.nwra.com/~orion/fedora/perl-Cflow-1.053-1.src.rpm
Description: 

Cflow with flow-tools support.  This module implements an API for
processing IP flow accounting information which as been collected from
routers and written into flow files.
Comment 1 Paul Howarth 2005-10-19 14:25:26 UTC 
Review:

- rpmlint clean
- package and spec naming OK
- package meets guidelines
- license is GPL, matches spec, text included
- spec file written in English and is legible
- sources match upstream
- package builds OK on FC4 (i386)
- BR's mostly OK
- no locales, libraries, subpackages or pkgconfigs to worry about
- not relocatable
- no directory ownership or permissions problems
- no duplicate files
- %clean section present and correct
- macro usage is consistent
- code, not content
- no large docs
- docs don't affect runtime
- no desktop entry needed
- no scriptlets
- package gives impression of running OK (flowdumper -h works as expected)

Nitpick:

- please capitalize the first letter of Summary:

- BR: perl is redundant as perl is a dep of rpm-build

Suggestion:

- package currently fails to build in mock due to Bug 171206
  you could work around this for now by adding a BR of zlib-devel

Approved.
Comment 2 Orion Poplawski 2005-10-19 15:38:15 UTC 
Build on devel succeeded.
Note You need to log in before you can comment on or make changes to this bug.