Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 170532 - Review Request: perl-Boulder - An API for hierarchical tag/value structures
Summary: Review Request: perl-Boulder - An API for hierarchical tag/value structures
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Paul Howarth
QA Contact: David Lawrence
URL: http://www.cora.nwra.com/~orion/fedora/
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2005-10-12 16:40 UTC by Orion Poplawski
Modified: 2007-11-30 22:11 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2005-10-21 15:41:47 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Orion Poplawski 2005-10-12 16:40:40 UTC 
Spec Name or Url: http://www.cora.nwra.com/~orion/fedora/perl-Boulder.spec
SRPM Name or Url: http://www.cora.nwra.com/~orion/fedora/perl-Boulder-1.30-1.src.rpm
Description: 

Boulder provides a simple stream-oriented format for transmitting data
objects between one or more processes.  It does not provide for the
serialization of Perl objects the way FreezeThaw or Data::Dumper do, but it
does provide the advantage of being language independent.
Comment 1 Paul Howarth 2005-10-21 11:41:02 UTC 
Review:

- rpmlint clean
- package and spec naming OK
- package meets guidelines
- license is same as perl, matches spec, text generated and included
- spec file written in English and is legible
- sources match upstream
- package builds OK in mock for rawhide (i386)
- no explicit BR's
- no locales, libraries, subpackages or pkgconfigs to worry about
- not relocatable
- no directory ownership or permissions issues
- no duplicate files
- %clean section present and correct
- macro usage is consistent
- code, not content
- no large docs
- docs don't affect runtime
- no desktop entry needed
- no scriptlets

Suggestion:

- perhaps %{perl_vendorlib}/Boulder.pod could be marked as %doc ?

Approved.
Comment 2 Orion Poplawski 2005-10-21 15:41:47 UTC 
Thanks for the review!

Not sure how to mark the pod file as %doc, and not sure that other perl modules
do this.

Imported and built on devel.
Comment 3 Paul Howarth 2005-10-21 15:50:26 UTC 
(In reply to comment #2)
> Not sure how to mark the pod file as %doc

You could do it by changing in the files list:

%{perl_vendorlib}/*

to:

%doc %{perl_vendorlib}/Boulder.pod
%{perl_vendorlib}/Boulder/
%{perl_vendorlib}/Stone*

which would mark the pod file as %doc and include every other file and directory
as before.

You can see which files are marked as docs in a package using the --docfiles
option of rpm.

> and not sure that other perl modules do this.

Most don't seem to ship the pod files at all.
Comment 4 Orion Poplawski 2005-10-21 15:55:47 UTC 
Ah, first I just tried adding it to the %doc list but it complained.  Checked in
the change.  Thanks!
Comment 5 Ville Skyttä 2005-10-21 15:58:23 UTC 
(In reply to comment #3)   
> Most don't seem to ship the pod files at all.   
   
On my FC4 box in /usr/lib/perl5/vendor_perl:   
   
    $ find . -name "*.pod" | wc -l   
    381   
   
Marking them as %doc calls for something automagic in rpmbuild instead   
of changing loads of perl-* specfiles IMO.
Note You need to log in before you can comment on or make changes to this bug.