Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 170534 - Review Request: perl-Net-Patricia - Patricia Trie perl module for fast IP address lookups
Summary: Review Request: perl-Net-Patricia - Patricia Trie perl module for fast IP add...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Paul Howarth
QA Contact: David Lawrence
URL: http://www.cora.nwra.com/~orion/fedora/
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2005-10-12 16:45 UTC by Orion Poplawski
Modified: 2007-11-30 22:11 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2005-10-24 16:18:56 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Orion Poplawski 2005-10-12 16:45:37 UTC 
Spec Name or Url: http://www.cora.nwra.com/~orion/fedora/perl-Net-Patricia.spec
SRPM Name or Url:
http://www.cora.nwra.com/~orion/fedora/perl-Net-Patricia-1.010-1.src.rpm
Description: 

This module uses a Patricia Trie data structure to quickly perform IP
address prefix matching for applications such as IP subnet, network or
routing table lookups.  The data structure is based on a radix tree using a
radix of two, so sometimes you see patricia implementations called "radix"
as well.  The term "Trie" is derived from the word "retrieval" but is
pronounced like "try".  Patricia stands for "Practical Algorithm to
Retrieve Information Coded as Alphanumeric", and was first suggested for
routing table lookups by Van Jacobsen.  Patricia Trie performance
characteristics are well-known as it has been employed for routing table
lookups within the BSD kernel since the 4.3 Reno release.
Comment 1 Paul Howarth 2005-10-24 12:49:40 UTC 
Review:

- rpmlint clean
- package and spec naming OK
- package meets guidelines
- license is GPL, matches spec, text included
- spec file written in English and is legible
- sources match upstream
- package builds OK in FC4 (i386) and in mock for rawhide (i386)
- BR's OK
- no locales, libraries, subpackages or pkgconfigs to worry about
- not relocatable
- no directory ownership or permissions issues
- no duplicate files
- %clean section present and correct
- macro usage is consistent
- code, not content
- docs don't affect runtime
- no large docs
- no desktop entry needed
- no scriptlets

Nitpick:

- fiddling with LD_RUN_PATH hasn't been necessary since FC2 - see
 
http://koti.welho.com/vskytta/packagers-handbook/packagers-handbook.html#guidelines-perl-linkerflags

Approved.
Comment 2 Orion Poplawski 2005-10-24 16:18:56 UTC 
Removed the LD_RUN_PATH change and built on devel.

Thanks for the review!
Note You need to log in before you can comment on or make changes to this bug.