Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 170616 - Review Request: ipxripd - IPX RIP/SAP daemon - routing for IPX networks
Summary: Review Request: ipxripd - IPX RIP/SAP daemon - routing for IPX networks
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: John Mahowald
QA Contact: David Lawrence
URL: ftp://ftp.ibiblio.org/pub/Linux/syste...
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2005-10-13 13:28 UTC by Dmitry Butskoy
Modified: 2011-12-06 06:12 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2005-12-13 12:02:02 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Dmitry Butskoy 2005-10-13 13:28:11 UTC
Yes, IPX looks like an obsolete thing.

Many distros ago RedHat began to plan IPX removal from its main distribution, however it till now there. It means that IPX is still necessary for users.

This package provides IPX routing and helps IPX browsing. Such functionality is missed in the standard ncpfs package.

Spec Url: http://dmitry.butskoy.name/ipxripd/ipxripd.spec
SRPM Url: http://dmitry.butskoy.name/ipxripd/ipxripd-0.8-1.src.rpm

Description: 
ipxripd is an implementation of Novell's RIP and SAP protocols.
It automagically builds and updates IPX routing table in the Linux kernel.
ipxripd can be useful to get a Linux box to act as an IPX router.

Comment 1 John Mahowald 2005-12-13 03:14:52 UTC
- rpmlint only says:
W: ipxripd incoherent-init-script-name ipxd

Looks like an OK name for the script though.

- package meets naming guidelines
- package meets packaging guidelines
- license (GPL) OK, text in %doc, matches source
- spec file legible
- source matches upstream
- package compiles on FC4 i386
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file 
- init script

However, %defattr(-,root,root) should be %defattr(-,root,root,-)

(I had to modprobe ipx before ipxd would stay running and not immediately exit.)

Make the %defattr change and this is APPROVED

Comment 2 Dmitry Butskoy 2005-12-13 11:33:31 UTC
> I had to modprobe ipx before ipxd would stay running and not immediately exit.
Normally ipxd is run after the IPX is configured by init scripts (therefore ipx
module is already loaded, ipx interfaces are activated etc.).

> %defattr(-,root,root) should be %defattr(-,root,root,-)
OK

Thanks for review!


Note You need to log in before you can comment on or make changes to this bug.