Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1707034 - krop should not depend on non-namespaced python sip package [NEEDINFO]
Summary: krop should not depend on non-namespaced python sip package
Keywords:
Status: ASSIGNED
Alias: None
Product: Fedora
Classification: Fedora
Component: krop
Version: rawhide
Hardware: All
OS: Linux
unspecified
low
Target Milestone: ---
Assignee: Tomáš Hozza
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1714218
Blocks: 1753069
TreeView+ depends on / blocked
 
Reported: 2019-05-06 16:46 UTC by Kai Kaminski
Modified: 2021-05-01 10:49 UTC (History)
4 users (show)

Fixed In Version: krop-0.5.1-3.fc30
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-06-25 01:25:18 UTC
Type: Bug
Embargoed:
projects.rg: needinfo? (thozza)

Attachments (Terms of Use)

Description Kai Kaminski 2019-05-06 16:46:30 UTC 
Description of problem:

Missing/incorrect dependency.

Version-Release number of selected component (if applicable):

0.5.1-2

How reproducible:

Always.

Steps to Reproduce:
1. Run 'dnf install krop'
2. Run 'krop' in a terminal.
3.

Actual results:

Traceback (most recent call last):
  File "/usr/lib/python3.7/site-packages/krop/config.py", line 5, in <module>
    import sip
ModuleNotFoundError: No module named 'sip'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/bin/krop", line 17, in <module>
    from krop.application import main
  File "/usr/lib/python3.7/site-packages/krop/application.py", line 19, in <module>
    from krop.config import KDE
  File "/usr/lib/python3.7/site-packages/krop/config.py", line 17, in <module>
    raise RuntimeError(_msg)
RuntimeError: Please install PyQt4 or PyQt5 first.

Expected results:

krop starts.

Additional info:

The problem can be fixed by installing the package python3-sip. The krop package has python2-sip (2 vs 3) as a dependency, so it's probably just a typo. I didn't check whether python2-sip is also required, though.
Comment 1 Raphael Groner 2019-05-23 20:33:10 UTC 
Reproducible for me. Should I file a pull request to add the missing dependency?
Comment 2 Fedora Update System 2019-05-27 13:44:21 UTC 
krop-0.5.1-3.fc30 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-20513011e7
Comment 3 Tomáš Hozza 2019-05-27 13:45:14 UTC 
(In reply to Raphael Groner from comment #1)
> Reproducible for me. Should I file a pull request to add the missing
> dependency?

Thanks for the offer, but it would be almost the same effort for me. Already done.
Comment 4 Tomáš Hozza 2019-05-27 13:46:42 UTC 
BTW the issue was in missing explicit dependency on pythonX-sip. The Python2 version of it is being pulled in by python3-poppler-qt.
Comment 5 Raphael Groner 2019-05-27 19:04:11 UTC 
(In reply to Tomáš Hozza 🤓 from comment #4)
> BTW the issue was in missing explicit dependency on pythonX-sip. The Python2
> version of it is being pulled in by python3-poppler-qt.

Does that mean another bug in python3-poppler-qt?
Comment 6 Raphael Groner 2019-05-27 19:24:55 UTC 
TBC, it's python3-poppler-qt5 with a false dependency to python2-sip.
Comment 7 Raphael Groner 2019-05-27 19:35:13 UTC 
Thanks, I found your bug #1714218.
Comment 8 Fedora Update System 2019-05-28 02:28:02 UTC 
krop-0.5.1-3.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-20513011e7
Comment 9 Fedora Update System 2019-06-25 01:25:18 UTC 
krop-0.5.1-3.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.
Comment 10 Rex Dieter 2019-09-18 20:21:43 UTC 
This was an incorrect fix, you shouldn't need an explicit dep on sip, nor should you be using the non-namespaced version, see bug #1753069
Comment 11 Rex Dieter 2019-09-18 20:23:09 UTC 
I see krop explicitly tries to load it,
krop/config.py:    import sip
krop/config.py:sip.setapi('QString', 2)
krop/config.py:sip.setapi('QVariant', 2)

Which is also probably not needed, I'll file a bug upstream, but you can probably just drop those 3 lines or switch to PyQt5.sip instead
Comment 12 Rex Dieter 2019-09-18 20:26:52 UTC 
Submitted https://github.com/arminstraub/krop/issues/23
Comment 13 Rex Dieter 2019-09-18 21:39:16 UTC 
rawhide commit,

 %changelog
+* Wed Sep 18 2019 Rex Dieter <rdieter> - 0.5.1-6
+- drop explicit dep pythonX-sip, use default name-spaced sip insetad (#1707034)

Will keep this open until there's upstream feedback.
Comment 14 Ben Cotton 2020-02-11 15:44:24 UTC 
This bug appears to have been reported against 'rawhide' during the Fedora 32 development cycle.
Changing version to 32.
Comment 15 Fedora Program Management 2021-04-29 17:09:07 UTC 
This message is a reminder that Fedora 32 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora 32 on 2021-05-25.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
Fedora 'version' of '32'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 32 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.
Comment 16 Raphael Groner 2021-05-01 10:49:39 UTC 
Well, let's keep this bug open in hope for new package update with upstream released version 0.6.0 including the proposed patch, besides blocked bug #1753069 also flagged for rawhide.
Please let me know if I can help with a new build.
Note You need to log in before you can comment on or make changes to this bug.