Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at
Bug 170905 - Review Request: pcsc-tools
Summary: Review Request: pcsc-tools
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: John Mahowald
QA Contact: David Lawrence
Depends On:
TreeView+ depends on / blocked
Reported: 2005-10-15 12:19 UTC by Ville Skyttä
Modified: 2007-11-30 22:11 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2005-12-13 21:15:35 UTC
Type: ---

Attachments (Terms of Use)

Description Ville Skyttä 2005-10-15 12:19:21 UTC

The pcsc-tools package contains some tools useful for a user of PC/SC
user. The tools provided are:
* pcsc_scan(1) scans available smart card readers and print detected
  events: card insertion with ATR, card removal;
* ATR_analysis(1) analyses a smart card ATR (Anwser To Reset)
* scriptor(1) Perl script to send commands to a smart card using a
  batch file or stdin;
* gscriptor(1) the same idea as scriptor(1) but with Perl-Gtk GUI.

Comment 1 John Mahowald 2005-12-13 05:17:48 UTC
Courtesy of fedora-qa script:
* RPM name is OK
* Source pcsc-tools-1.4.1.tar.gz is the same as upstream
* Builds fine in mock, FC4 i386
* rpmlint of pcsc-tools looks OK
* File list of pcsc-tools looks OK

Needs work:
* Source smartcard_list.txt is different from upstream,
  upstream is newer
  (wiki: QAChecklist item 2)
* BuildRequires: sed should not be included
  (wiki: PackagingGuidelines#Exceptions)
* Desktop file: the Categories tag should contain Application
  (wiki: PackagingGuidelines#desktop)

Comment 2 Ville Skyttä 2005-12-13 09:14:26 UTC
Thanks.  smartcard_list.txt is a moving target, updated to latest upstream and
"fixed" the other issues too (although I don't quite agree with them).

Comment 3 John Mahowald 2005-12-13 20:28:14 UTC
- package meets naming guidelines
- package meets packaging guidelines
- license (GPL) OK, text in %doc, matches source
- spec file legible
- source matches upstream
- package compiles on FC4 i386
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- .desktop file properly installed


Comment 4 Ville Skyttä 2005-12-13 21:15:35 UTC
Thanks, imported and successfully built for FC-4 and devel.

Note You need to log in before you can comment on or make changes to this bug.