Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 170973 - Review Request: gnomebaker: Gnome CD/DVD burner
Summary: Review Request: gnomebaker: Gnome CD/DVD burner
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Adrian Reber
QA Contact: David Lawrence
URL: http://gnomebaker.sourceforge.net/v2/
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2005-10-16 19:19 UTC by Brian Pepple
Modified: 2007-11-30 22:11 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-02-06 23:58:06 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
Build log for gnomebaker-0.5.0-2.src.rpm on Devel (deleted)
2005-10-17 17:38 UTC, Brian Pepple
no flags Details
Build log for gnomebaker-0.5.0-3.src.rpm on Devel (deleted)
2005-10-19 13:32 UTC, Brian Pepple
no flags Details

Description Brian Pepple 2005-10-16 19:19:59 UTC
Spec Name or Url: http://piedmont.homelinux.org/fedora/gnomebaker/gnomebaker.spec
SRPM Name or Url: http://piedmont.homelinux.org/fedora/gnomebaker/gnomebaker-0.5.0-1.src.rpm
Description: CD/DVD burner designed for the GNOME desktop.

Comment 1 Adrian Reber 2005-10-17 05:53:19 UTC
the debuginfo package is empty and the $RPM_OPT_FLAGS are not used.

Comment 2 Adrian Reber 2005-10-17 15:12:03 UTC
mock build on devel fails with:

RPM build errors:
    File not found:
/var/tmp/gnomebaker-0.5.0-1-root-mockbuild/usr/share/gnome/help/gnomebaker

Comment 4 Brian Pepple 2005-10-17 17:38:37 UTC
Created attachment 120066 [details]
Build log for gnomebaker-0.5.0-2.src.rpm on Devel

Comment 5 Adrian Reber 2005-10-19 06:29:13 UTC
The RPM_OPT_FLAGS are still not used. The following hack makes configure use the
flags:

@@ -35,6 +35,7 @@
 %setup -q
 %patch0 -p1 -b .desktop
 %patch1 -p1 -b .help
+sed -i -e "/^CFLAGS/d" configure.in
 aclocal
 autoconf


Comment 7 Brian Pepple 2005-10-19 13:32:31 UTC
Created attachment 120164 [details]
Build log for gnomebaker-0.5.0-3.src.rpm on Devel

Comment 8 Adrian Reber 2005-10-20 06:42:06 UTC
It builds now on devel; I can install it and start it but I cannot press on any
button in the GUI. The problem seems to be that it cannot find its own callbacks
because I can see many errors like these:

(gnomebaker:8562): libglade-WARNING **: could not find signal handler
'gnomebaker_on_notebook_switch_page'.

(gnomebaker:8562): libglade-WARNING **: could not find signal handler
'gnomebaker_on_preferences'.

(gnomebaker:8562): libglade-WARNING **: could not find signal handler
'gnomebaker_on_format_dvdrw'.

I will try now a build with FC-4 mock and see how that works.

Comment 9 Adrian Reber 2005-10-20 06:54:58 UTC
The FC-4 versions doesn't have this problem. Works as expected.

Comment 10 Brian Pepple 2005-10-22 19:41:02 UTC
(In reply to comment #8)
Looks like this has been already reported upstream:
https://sourceforge.net/tracker/index.php?func=detail&aid=1327700&group_id=127397&atid=708499

Hopefully, later this weekend I can get some time to see what the problem is.



Comment 11 Michael J Knox 2006-01-21 22:17:15 UTC
Under FC5test2 updated to 22nd Jan, gnomebaker is not looking good. 

[monkey@hailstorm ~]$ gnomebaker

(gnomebaker:23334): Gtk-WARNING **: gtkwidget.c:4205: widget not within a GtkWindow

(gnomebaker:23334): Gtk-WARNING **: Theme directory
16x16/status16x16/stock/chart of theme gnome has no size field

*** glibc detected *** gnomebaker: free(): invalid pointer: 0x09ef6468 ***

[monkey@hailstorm ~]$


Comment 12 Michael J Knox 2006-01-22 00:08:21 UTC
this seems to be mostly fixed in CVS. Unable to do a CVS checkout at the moment. 

Ubuntu's drapper source's (CVS 2005-01-10 0.5.1) seem to work. 

Would this be suitable for use (the CVS snapshot)? I can redo the srpm against
it if there is no one else too. 

Comment 13 Peter Gordon 2006-01-22 00:13:23 UTC
I'm pretty sure CVS snapshots are acceptable. Be sure that it works otherwise,
though, and is packaged according to the snapshot packaging guidelines:
http://fedoraproject.org/wiki/PackageNamingGuidelines#head-975237cdcb9aa7775601adeaaccbc70290f69812

Comment 14 Brian Pepple 2006-01-22 00:25:15 UTC
Luke's gearing up for another release fairly soon, so I'm inclined not to use a
CVS snapshot.  Regardless, I'm probably not gonna have time to look at this for
another week or so.

Comment 15 Michael J Knox 2006-01-22 02:13:20 UTC
Understnad, However, I was in need of a CD/DVD burning app and did not want to
use K3b. My preference is for gnomebaker. 

I modified the srpm and spec, bit can be review from here:
http://www.knox.net.nz/fedora_stuff/gnomebaker-0.5.1-1.20050110cvs.fc4.src.rpm
http://www.knox.net.nz/fedora_stuff/gnomebaker.spec



Comment 16 Brian Pepple 2006-01-22 05:01:31 UTC
I appreciate your enthusiasm Michael, but I'm not comfortable with using a cvs
version for it's initial review, given all the changes being made in this version.

Comment 17 Michael J Knox 2006-01-22 05:05:50 UTC
Not a problem. Its there, changes for the new version with regards to the
patches and FC5 have been made to the SPEC. 

Comment 18 drago01 2006-01-22 12:08:57 UTC
on fc4 I get:
 rpmbuild -bb gnomebaker.spec
Error: /home/dragoran/rpm/SPECS/gnomebaker.spec:16: parseExpressionBoolean
returns -1
Error: Package has no %description: gnomebaker


Comment 19 Michael J Knox 2006-01-22 17:31:46 UTC
%{?dist} was used to seperate buildrequires under fc4 and fc5. 

Please rebuild using --define "dist fc4"

Comment 20 Paul Howarth 2006-01-22 17:39:17 UTC
(In reply to comment #19)
> %{?dist} was used to seperate buildrequires under fc4 and fc5. 
> 
> Please rebuild using --define "dist fc4"

The extras buildsystem will define "%{?dist}" as ".fc4" or ".fc5", not just
"fc4" or "fc5".

See the "Conditionals" section of http://fedoraproject.org/wiki/DistTag for how
to do distribution-specific builds.

Comment 21 Michael J Knox 2006-01-22 17:49:25 UTC
I know. But if you want to rebuild it outside the buildsys, then using the
define flag will be needed. 

I had read that url and spoke with people in #fedora-extras and the method used
was the method suggested. 

Comment 22 Brian Pepple 2006-02-05 01:18:49 UTC
Updated package to new version, which fixes the problem with glade.

Spec: http://piedmont.homelinux.org/fedora/gnomebaker/gnomebaker.spec
SRPM: http://piedmont.homelinux.org/fedora/gnomebaker/gnomebaker-0.5.1-1.src.rpm

Note: This spec is currently set-up for FC5 only (gstreamer08-devel).

Comment 23 Brian Pepple 2006-02-05 01:19:38 UTC
Comment on attachment 120164 [details]
Build log for gnomebaker-0.5.0-3.src.rpm on Devel

No longer relevent

Comment 24 Adrian Reber 2006-02-06 12:45:21 UTC
* source matches upstream
* rpmlint is happy
* spec looks good
* clean installation and removal
* works as expected
* builds in mock

APPROVED

Comment 25 Brian Pepple 2006-02-06 23:58:06 UTC
Packages built, and should be available soon.


Note You need to log in before you can comment on or make changes to this bug.