Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 171090 - Review Request: paps - Plain Text to PostScript(TM) converter
Summary: Review Request: paps - Plain Text to PostScript(TM) converter
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Aurelien Bompard
QA Contact: David Lawrence
URL: http://people.redhat.com/tagoh/paps/
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2005-10-18 03:01 UTC by Akira TAGOH
Modified: 2007-11-30 22:11 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2005-10-25 10:54:51 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Akira TAGOH 2005-10-18 03:01:14 UTC
Spec Name or Url: http://people.redhat.com/tagoh/paps/paps.spec
SRPM Name or Url: http://people.redhat.com/tagoh/paps/paps-0.3-1.src.rpm
Description: 

paps is a PostScript(TM) converter from plain text file using Pango.

Comment 1 Aurelien Bompard 2005-10-22 20:38:50 UTC
* BuildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
  (wiki: PackagingGuidelines#BuildRoot)
* The package should contain the text of the license (the COPYING file)
  (wiki: PackageReviewGuidelines)
* The package does not honor RPM_OPT_FLAGS. Building with:
  make %{?_smp_mflags} CC="gcc $RPM_OPT_FLAGS"
  should do it.


Comment 2 Akira TAGOH 2005-10-25 02:47:37 UTC
Thank you for reviewing. I've put the updated spec file and srpm file at the
same place.

Comment 3 Aurelien Bompard 2005-10-25 07:47:37 UTC
* RPM name is OK
* Source paps-0.3.tgz is the same as upstream
* Builds fine in mock
* rpmlint of paps looks OK
* File list of paps looks OK
* Works fine
APPROVED

Next time please increase release when updating the package, it make it easier
to know which release has been approved.

Comment 4 Akira TAGOH 2005-10-25 10:54:51 UTC
Sure. thanks.

Comment 5 Dov Grobgeld 2005-11-03 21:03:52 UTC
Please use paps-0.5.tgz that I just released instead. It's postscript is up to
100 times more compact and it fixes several critical layout bugs.


Note You need to log in before you can comment on or make changes to this bug.