I'm not sure whether you really want to install a benchmark, but that's up to you.

Tests do not pass though, (since they attempt to use fuse?), so you'll need to skip some or add a conditional so they don't run on koji.


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "BSD 3-clause "New" or "Revised"
     License". 156 files have unknown license. Detailed output of
     licensecheck in 1712280-golang-github-hanwen-fuse/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/gocode,
     /usr/share/gocode/src
[x]: Package does not own files or directories owned by other packages.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[?]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 184320 bytes in 26 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in golang-
     github-hanwen-fuse , golang-github-hanwen-fuse-devel
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[!]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: golang-github-hanwen-fuse-1.0.0-1.fc31.x86_64.rpm
          golang-github-hanwen-fuse-devel-1.0.0-1.fc31.noarch.rpm
          golang-github-hanwen-fuse-debuginfo-1.0.0-1.fc31.x86_64.rpm
          golang-github-hanwen-fuse-debugsource-1.0.0-1.fc31.x86_64.rpm
          golang-github-hanwen-fuse-1.0.0-1.fc31.src.rpm
golang-github-hanwen-fuse.x86_64: W: no-manual-page-for-binary bulkstat
golang-github-hanwen-fuse-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/hanwen/go-fuse/.goipath
golang-github-hanwen-fuse.src: E: specfile-error warning: -u use in %forgemeta is deprecated, use -z instead to select a separate set of rpm variables!
5 packages and 0 specfiles checked; 1 errors, 2 warnings.




Rpmlint (debuginfo)
-------------------
Checking: golang-github-hanwen-fuse-debuginfo-1.0.0-1.fc31.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.





Rpmlint (installed packages)
----------------------------
golang-github-hanwen-fuse-debuginfo.x86_64: W: invalid-url URL: https://github.com/hanwen/go-fuse <urlopen error [Errno -2] Name or service not known>
golang-github-hanwen-fuse.x86_64: W: invalid-url URL: https://github.com/hanwen/go-fuse <urlopen error [Errno -2] Name or service not known>
golang-github-hanwen-fuse.x86_64: W: no-manual-page-for-binary bulkstat
golang-github-hanwen-fuse-devel.noarch: W: invalid-url URL: https://github.com/hanwen/go-fuse <urlopen error [Errno -2] Name or service not known>
golang-github-hanwen-fuse-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/hanwen/go-fuse/.goipath
golang-github-hanwen-fuse-debugsource.x86_64: W: invalid-url URL: https://github.com/hanwen/go-fuse <urlopen error [Errno -2] Name or service not known>
4 packages and 0 specfiles checked; 0 errors, 6 warnings.



Source checksums
----------------
https://github.com/hanwen/go-fuse/archive/v1.0.0/go-fuse-1.0.0.tar.gz :
  CHECKSUM(SHA256) this package     : 3b84158c02b767f0942936a9ef869cfdc2a8251adf304b079554d3dbf6b8678e
  CHECKSUM(SHA256) upstream package : 3b84158c02b767f0942936a9ef869cfdc2a8251adf304b079554d3dbf6b8678e


Requires
--------
golang-github-hanwen-fuse (rpmlib, GLIBC filtered):
    libc.so.6()(64bit)
    libpthread.so.0()(64bit)
    rtld(GNU_HASH)

golang-github-hanwen-fuse-devel (rpmlib, GLIBC filtered):
    golang(golang.org/x/sys/unix)

golang-github-hanwen-fuse-debuginfo (rpmlib, GLIBC filtered):

golang-github-hanwen-fuse-debugsource (rpmlib, GLIBC filtered):



Provides
--------
golang-github-hanwen-fuse:
    golang-github-hanwen-fuse
    golang-github-hanwen-fuse(x86-64)

golang-github-hanwen-fuse-devel:
    golang(github.com/hanwen/go-fuse/benchmark)
    golang(github.com/hanwen/go-fuse/fuse)
    golang(github.com/hanwen/go-fuse/fuse/nodefs)
    golang(github.com/hanwen/go-fuse/fuse/pathfs)
    golang(github.com/hanwen/go-fuse/fuse/test)
    golang(github.com/hanwen/go-fuse/internal/testutil)
    golang(github.com/hanwen/go-fuse/internal/utimens)
    golang(github.com/hanwen/go-fuse/splice)
    golang(github.com/hanwen/go-fuse/unionfs)
    golang(github.com/hanwen/go-fuse/zipfs)
    golang-github-hanwen-fuse-devel
    golang-ipath(github.com/hanwen/go-fuse)

golang-github-hanwen-fuse-debuginfo:
    debuginfo(build-id)
    golang-github-hanwen-fuse-debuginfo
    golang-github-hanwen-fuse-debuginfo(x86-64)

golang-github-hanwen-fuse-debugsource:
    golang-github-hanwen-fuse-debugsource
    golang-github-hanwen-fuse-debugsource(x86-64)



Generated by fedora-review 0.7.2 (65d36bb) last change: 2019-04-09
Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1712280
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: PHP, Java, Ocaml, Python, Haskell, SugarActivity, R, fonts, C/C++, Perl
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

Thank you for the feedback - your comments pointed me to read the autogenerated spec a bit differently.  I've updated the files with a new spec that just generates a -devel package.  There really isn't anything else in this package.

From your comments, it seems that most of this is good to go.  It appears there is not a fuse dependency anymore, so I haven't added it.  Your comments continue to be appreciated.

Thank you.

You've simplified a bit too much; the name of the package must still be %{goname} with a %{goname}-devel subpackage.

I've uploaded updated files.

I've put it back to making a -devel package.  I think I have it, however I am concerned by not having a %build section.  Another reviewer on a different package seems to be upset if there is not an empty %build section ...

Adding just fuse BRs doesn't work unfortunately, as tests require the fuse module to be loaded. I don't think you'll ever be able to get that on a koji builder, so you'll need to disable them by default.

I've run koji scratch builds and local builds and the tests don't seem to be executing.  Can you help me see the log where you see them?

It's because this package has a Go.mod and that causes golist to crash and not run any tests. You can grab a working version from bug 1714090 and test with that.

I have had a chance to return to this.  There seems to be several ways to skip the tests, none of which feels right.  Your advice is appreciated.

Option 1: Delete the fuse/test subdirectory to eliminate the tests
Option 2: Figure out how to tell go-test, as generated by the macro, to not test the fuse package - not sure how to do this
Option 3: Edit all of the test files to use a +build similar to https://stackoverflow.com/questions/24030059/skip-some-tests-with-go-test -- this feels super fragile and probably still requires the macro edits as in Option 2

What is your suggestion?

You can tell %gochecks to skip files or directories: https://fedoraproject.org/wiki/More_Go_packaging#Excluding_testing_in_specific_directories

If _all_ tests requires fuse, then switch the toggle at the top to default-off.

Thanks for the reference.  

So I have updated the spec and src rpm, however, it didn't seem to need me to turn off tests.

Here is a scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=35264028

I did have to add a line to disable debug information as that was causing local and koji builds to fail.

Due to poor version hygiene I can't decide if I had this line and then deleted it or what.

I've run rpmlint and fedora-review locally and things look right to me.

The new golist (which doesn't crash) and go-compilers should be available in Rawhide now, so if you run a scratch build, it will fail. You might not get this with mock though, as I think the latest Rawhide compose failed.

You don't need debug_package %{nil}, but instead remove %build.

I've now read through the new docs from eclipseo and the email on devel list and tried this all again in Rawhide.  I had to disable all tests as they require fuse.

Updated:

Spec URL: https://bex.fedorapeople.org/golang-github-hanwen-fuse/golang-github-hanwen-fuse.spec
SRPM URL: https://bex.fedorapeople.org/golang-github-hanwen-fuse/golang-github-hanwen-fuse-1.0.0-1.fc31.src.rpm
Description: FUSE bindings for Go
Fedora Account System Username: bex

Scratch Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=35428096

Assuming this works, do we have an option to get it working in F30 too?  I don't think the macros are backported.

Set these

%global golicenses LICENSE
%global godocs README.md

to replace the commented out %files bits and remove extra %license.

I think the rest should work out, though I have not tried it.

For F30, you will have to use the old macros, unfortunately.

I've made changes and run a new scratch build (https://koji.fedoraproject.org/koji/taskinfo?taskID=35486883)

You'll need to set those globals earlier to have any effect (not sure exactly how much earlier, but go2rpm would place them before Name:).

updated :) https://koji.fedoraproject.org/koji/taskinfo?taskID=35499038

I'm not sure you need to use the %godevel* versions instead of %go*.

Also, it doesn't appear that you've uploaded new copies of the spec/srpm or used it in the scratch build.

The use of the %go versions seems to be what the templates now call for ... does this need to be changed for rawhide?

I've uploaded a new SRPM and spec file.

Spec URL: https://bex.fedorapeople.org/golang-github-hanwen-fuse/golang-github-hanwen-fuse.spec
SRPM URL: https://bex.fedorapeople.org/golang-github-hanwen-fuse/golang-github-hanwen-fuse-1.0.0-1.fc30.src.rpm

A new scratchbuild is here: https://koji.fedoraproject.org/koji/taskinfo?taskID=35598086

No, I mean %godevelpkg vs %gopkg; it doesn't seem that you require the devel-only one instead of the generic one. Seems fine either way I guess.

It seems that I would use it, per https://docs.fedoraproject.org/en-US/packaging-guidelines/Golang/#_package_metadata as I only need the devel sub-packages.

WDYT?

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-hanwen-fuse

Built for rawhide https://koji.fedoraproject.org/koji/taskinfo?taskID=35736960

*** Bug 1409780 has been marked as a duplicate of this bug. ***