Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 171505 - Review Request: digikamimageplugins: Plugins for digikam
Summary: Review Request: digikamimageplugins: Plugins for digikam
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Aurelien Bompard
QA Contact: David Lawrence
URL: http://extragear.kde.org/apps/digikam...
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2005-10-21 21:38 UTC by Rex Dieter
Modified: 2007-11-30 22:11 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2005-11-01 15:44:51 UTC
Type: ---
Embargoed:
petersen: fedora-cvs-

Attachments (Terms of Use)

Description Rex Dieter 2005-10-21 21:38:03 UTC 
Spec Name or Url: http://apt.kde-redhat.org/apt/kde-redhat/SPECS/digikamimageplugins-0.7.4-1.spec
SRPM Name or Url: http://apt.kde-redhat.org/apt/kde-redhat/all/SRPMS.stable/digikamimageplugins-0.7.4-1.src.rpm
Description: 
DigikamImagePlugins are a collection of plugins for digiKam Image
Editor and showfoto (digiKam stand alone image editor implementation).
These plugins add new image treatment options like color management,
filters, or special effects.

Currently implemented plugins are listed below:
* Image improvements:
  o icon Adjust levels : a tool to adjust the photograph histogram levels manually.
  o icon Adjust curves : a tool to adjust the photograph colors using curves.
  o icon Noise Reduction : a photograph noise reduction filter.
  o icon Unsharp : a photograph unsharp mask filter to unblur picture without increase noise.
  o icon Lens Distortion : a tool for correct lens spherical aberration on photograph.
  o icon Anti Vignetting : a tool for correct vignetting on photograph.
* Transformation tools:
  o icon Free Rotation : a plugin to rotate a photograph with a free angle in degrees.
  o icon Shear Tool : a plugin to shear a photograph horizontally and vertically.
  o icon Perpective Tool : a plugin to adjust the photograph perpective.
* Image tools:
  o icon Template Superimpose : a tool for superimpose a template on photograph.
  o icon Add Border : a tool for add border around a photograph.
* Special effects:
  o icon Solarize : a plugin to solarize a photograph.
  o icon Oil Paint : simulate oil painting on photograph (using Pieter Voloshyn algorithm).
  o icon Emboss : an effect filter to emboss photograph (using Pieter Voloshyn algorithm).
  o icon Rain Drops : adding the visual effect of raindrops on photograph (using Pieter Voloshyn algorithm).
  o icon Charcoal : simulate charcoal drawing on photograph.
  o icon FilmGrain : simulate film grain on photograph.
Comment 1 Aurelien Bompard 2005-10-22 15:17:48 UTC 
Build fails in mock:
Making all in adjustlevels
make[3]: Entering directory `[...]/digikamimageplugins/adjustlevels'
/usr/lib/qt-3.3/bin/moc ./adjustlevels.h -o adjustlevels.moc
/usr/lib/qt-3.3/bin/moc ./imageplugin_adjustlevels.h -o imageplugin_adjustlevels.moc
creating digikamimageplugin_adjustlevels_la.all_cpp.cpp ...
/bin/sh ../../libtool [...] -c -o digikamimageplugin_adjustlevels_la.all_cpp.lo
digikamimageplugin_adjustlevels_la.all_cpp.cpp
/bin/sh ../../libtool [...] digikamimageplugin_adjustlevels_la.all_cpp.lo 
-lkparts -ldigikam
grep: /usr/lib/libgdbm.la: No such file or directory
/bin/sed: can't read /usr/lib/libgdbm.la: No such file or directory
libtool: link: `/usr/lib/libgdbm.la' is not a valid libtool archive
make[3]: *** [digikamimageplugin_adjustlevels.la] Error 1
Comment 2 Rex Dieter 2005-10-22 15:26:50 UTC 
Gotta love libtool.  Looks like a digikam bug (not omitting libtool archives),
bug #171503
Comment 3 Rex Dieter 2005-10-22 15:33:05 UTC 
%changelog
* Sat Oct 22 2005 Rex Dieter <rexdieter[AT]users.sf.net> 0.7.4-2
- BR: gdbm-devel (workaround for digikam bug #171503)

Spec Name or Url:
http://apt.kde-redhat.org/apt/kde-redhat/SPECS/digikamimageplugins-0.7.4-2.spec
SRPM Name or Url:
http://apt.kde-redhat.org/apt/kde-redhat/all/SRPMS.stable/digikamimageplugins-0.7.4-2.src.rpm
Comment 4 Rex Dieter 2005-10-22 15:46:21 UTC 
%changelog
* Sat Oct 22 2005 Rex Dieter <rexdieter[AT]users.sf.net> 0.7.4-3
- follow icon spec (touch icon theme dir)

Spec Name or Url:
http://apt.kde-redhat.org/apt/kde-redhat/SPECS/digikamimageplugins-0.7.4-3.spec
SRPM Name or Url:
http://apt.kde-redhat.org/apt/kde-redhat/all/SRPMS.stable/digikamimageplugins-0.7.4-3.src.rpm
Comment 5 Aurelien Bompard 2005-10-22 15:58:24 UTC 
Build failed again in mach, this time requirering /usr/lib/libkipi.la (but we
don't ship it anymore)
By the way, some lines are more than 80 cols in the description.
Comment 6 Rex Dieter 2005-10-22 16:30:02 UTC 
%changelog
* Sat Oct 22 2005 Rex Dieter <rexdieter[AT]users.sf.net> 0.7.4-4
- %%description: < 80 columns
- BR: libkipi-devel, libkexif-devel, gphoto2-devel, imlib2-devel
  (workaround for digikam bug #171503)

Spec Name or Url:
http://apt.kde-redhat.org/apt/kde-redhat/SPECS/digikamimageplugins-0.7.4-4.spec
SRPM Name or Url:
http://apt.kde-redhat.org/apt/kde-redhat/all/SRPMS.stable/digikamimageplugins-0.7.4-4.src.rpm
Comment 7 Aurelien Bompard 2005-10-22 17:23:20 UTC 
Review for release 4:
* RPM name is OK
* Source digikamimageplugins-0.7.4.tar.bz2 is the same as upstream
* Builds fine in mock
* rpmlint of digikamimageplugins looks OK
* File list of digikamimageplugins looks OK
* Plugins are detected by digikam, and work fine.
I would approve it but for the scriptlets not running gtk-update-icon-cache. I
understand your point about not running it, therefore I'm adding the bug as a
dependency.
Comment 8 Rex Dieter 2005-10-22 17:56:03 UTC 
fine, I'll re-add the gtk-update-icon-cache call... I just needed to vent... (-:
Comment 9 Rex Dieter 2005-10-22 18:21:47 UTC 
Blockers have been worked-around, removing...

%changelog
* Sat Oct 22 2005 Rex Dieter <rexdieter[AT]users.sf.net> 0.7.4-5
- %%post,%%postun: gtk-update-icon-cache
- drop %%{?debug_package}
- drop CVS tags

Spec Name or Url:
http://apt.kde-redhat.org/apt/kde-redhat/SPECS/digikamimageplugins-0.7.4-5.spec
SRPM Name or Url:
http://apt.kde-redhat.org/apt/kde-redhat/all/SRPMS.stable/digikamimageplugins-0.7.4-5.src.rpm
Comment 10 Aurelien Bompard 2005-10-22 20:17:04 UTC 
Yeah, I understand, it's quite a pain in the bottom...
I hope the cron job will be added before everybody has updated their spec file...
OK, looks good. APPROVED.
Comment 11 Rex Dieter 2007-03-27 12:58:33 UTC 
Package Change Request
======================
Package Name: digikamimageplugins
[Updated Fedora Owners: mgarski
Comment 12 Jens Petersen 2007-03-27 13:37:04 UTC 
Is the intention to add a comaintainer or a change of package ownership?
Please clarify and set fedora-cvs to '?' again.
Note You need to log in before you can comment on or make changes to this bug.