Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1716489 - python-asynctest fails to build on Fedora 31
Summary: python-asynctest fails to build on Fedora 31
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: python-asynctest
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: ---
Assignee: Dominik 'Rathann' Mierzejewski
QA Contact: Fedora Extras Quality Assurance
URL: https://copr.fedorainfracloud.org/cop...
Whiteboard:
: 1736476 (view as bug list)
Depends On:
Blocks: F31FTBFS PYTHON38 1732841
TreeView+ depends on / blocked
 
Reported: 2019-06-03 14:37 UTC by Miro Hrončok
Modified: 2019-08-11 20:12 UTC (History)
4 users (show)

Fixed In Version: python-asynctest-0.13.0-1.fc31
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-08-11 12:38:39 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Miro Hrončok 2019-06-03 14:37:41 UTC 
See https://copr.fedorainfracloud.org/coprs/g/python/python3.8/package/python-asynctest/ for actual logs. This report is automated and not very verbose, but feel free to ping me for help.
Comment 1 Karthikeyan Singaravelan 2019-06-29 17:05:14 UTC 
Some of the test failures are fixed on reverting https://bugs.python.org/issue36996 . I am not sure if it's a CPython regression or if asynctest test's have to be changed as per the changes over patch can now act on async functions.
Comment 2 Miro Hrončok 2019-07-10 12:49:48 UTC 
======================================================================
ERROR: test_both_patch_and_patch_dict_with_scope_global (test.test_mock.Test_patch_and_patch_dict_scope) [patch and patch.dict]
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/asynctest-0.12.2/asynctest/mock.py", line 1240, in _patch_dict
    self._original = self.in_dict.copy()
AttributeError: 'str' object has no attribute 'copy'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/builddir/build/BUILD/asynctest-0.12.2/asynctest/mock.py", line 914, in patched_factory
    arg = patching.__enter__()
  File "/usr/lib64/python3.8/unittest/mock.py", line 1726, in __enter__
    self._patch_dict()
  File "/builddir/build/BUILD/asynctest-0.12.2/asynctest/mock.py", line 1246, in _patch_dict
    self._original[key] = self.in_dict[key]
TypeError: string indices must be integers

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/lib64/python3.8/unittest/mock.py", line 1782, in _clear_dict
    in_dict.clear()
AttributeError: 'str' object has no attribute 'clear'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/builddir/build/BUILD/asynctest-0.12.2/test/test_mock.py", line 1381, in test_both_patch_and_patch_dict_with_scope_global
    self.assertEqual((True, True), run_coroutine(a_coroutine()))
  File "/builddir/build/BUILD/asynctest-0.12.2/test/utils.py", line 9, in run_coroutine
    return loop.run_until_complete(coroutine)
  File "/usr/lib64/python3.8/asyncio/base_events.py", line 608, in run_until_complete
    return future.result()
  File "/builddir/build/BUILD/asynctest-0.12.2/asynctest/mock.py", line 958, in patched_generator
    return (yield from patched_factory(*args, **kwargs))
  File "/builddir/build/BUILD/asynctest-0.12.2/asynctest/mock.py", line 948, in patched_factory
    patching.__exit__(*exc_info)
  File "/usr/lib64/python3.8/unittest/mock.py", line 1773, in __exit__
    self._unpatch_dict()
  File "/builddir/build/BUILD/asynctest-0.12.2/asynctest/mock.py", line 1269, in _unpatch_dict
    _clear_dict(self.in_dict)
  File "/usr/lib64/python3.8/unittest/mock.py", line 1786, in _clear_dict
    del in_dict[key]
TypeError: 'str' object does not support item deletion


...

Ran 215 tests in 0.773s

FAILED (failures=27, errors=18, unexpected successes=1)
Comment 3 Charalampos Stratakis 2019-07-23 14:54:24 UTC 
Any updates on that?
Comment 4 Dominik 'Rathann' Mierzejewski 2019-08-05 22:19:35 UTC 
*** Bug 1736476 has been marked as a duplicate of this bug. ***
Comment 5 Dominik 'Rathann' Mierzejewski 2019-08-11 12:21:24 UTC 
Looks like 0.13.0 builds and its testsuite passes, so I'll just bump the version.
Comment 6 Dominik 'Rathann' Mierzejewski 2019-08-11 12:38:39 UTC 
... but rawhide is still carrying python 3.7.4?

Anyway, the bug title says FTBFS in F31, which is no longer true, so I'm closing this.
Comment 7 Miro Hrončok 2019-08-11 12:50:22 UTC 
rawhide is still carrying python 3.7, yes. if it builds in rawhide, it's good. if it builds with 3.7 but not 3.8, I'll figure that out and open a separate bug if needed.

Thanks.
Comment 8 Miro Hrončok 2019-08-11 20:12:38 UTC 
And indeed it fails: bz1739895
Note You need to log in before you can comment on or make changes to this bug.