Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1716536 - python-vulture fails to build with Python 3.8
Summary: python-vulture fails to build with Python 3.8
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: python-vulture
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: ---
Assignee: Yatin Karel
QA Contact: Fedora Extras Quality Assurance
URL: https://copr.fedorainfracloud.org/cop...
Whiteboard:
Depends On:
Blocks: PYTHON38
TreeView+ depends on / blocked
 
Reported: 2019-06-03 14:41 UTC by Miro Hrončok
Modified: 2019-09-10 06:26 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-09-10 06:26:10 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Miro Hrončok 2019-06-03 14:41:10 UTC 
See https://copr.fedorainfracloud.org/coprs/g/python/python3.8/package/python-vulture/ for actual logs. This report is automated and not very verbose, but feel free to ping me for help.
Comment 1 Miro Hrončok 2019-07-10 14:20:53 UTC 
============================= test session starts ==============================
platform linux -- Python 3.8.0b2, pytest-4.4.1, py-1.8.0, pluggy-0.12.0
rootdir: /builddir/build/BUILD/vulture-0.27, inifile: setup.cfg
plugins: cov-2.7.1
collected 144 items

tests/test_conditions.py ..............                                  [  9%]
tests/test_confidence.py ......                                          [ 13%]
tests/test_errors.py ...                                                 [ 15%]
tests/test_format_strings.py FFFFF.                                      [ 20%]
tests/test_imports.py .............                                      [ 29%]
tests/test_item.py .                                                     [ 29%]
tests/test_scavenging.py .......................................         [ 56%]
tests/test_script.py .........                                           [ 63%]
tests/test_size.py ..F........................                           [ 81%]
tests/test_sorting.py .                                                  [ 82%]
tests/test_unreachable.py .........................                      [100%]

=================================== FAILURES ===================================
____________________________ test_old_format_string ____________________________

v = <vulture.core.Vulture object at 0x7fefdfed4580>

    def test_old_format_string(v):
        v.scan("'%(a)s, %(b)d' % locals()")
>       check(v.used_names, ['a', 'b', 'locals'])

tests/test_format_strings.py:7: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

items_or_names = LoggingSet({'locals'}), expected_names = ['a', 'b', 'locals']

    def check(items_or_names, expected_names):
        if isinstance(items_or_names, set):
            # items_or_names is a set of strings.
>           assert items_or_names == set(expected_names)
E           AssertionError

tests/__init__.py:10: AssertionError
----------------------------- Captured stdout call -----------------------------
1 Module(body=[Expr(value=BinOp(left=Constant(value='%(a)s, %(b)d', kind=None), op=Mod(), right=Call(func=Name(id='locals', ctx=Load()), args=[], keywords=[])))], type_ignores=[]) '%(a)s, %(b)d' % locals()
1 Expr(value=BinOp(left=Constant(value='%(a)s, %(b)d', kind=None), op=Mod(), right=Call(func=Name(id='locals', ctx=Load()), args=[], keywords=[]))) '%(a)s, %(b)d' % locals()
1 BinOp(left=Constant(value='%(a)s, %(b)d', kind=None), op=Mod(), right=Call(func=Name(id='locals', ctx=Load()), args=[], keywords=[])) '%(a)s, %(b)d' % locals()
1 Constant(value='%(a)s, %(b)d', kind=None) '%(a)s, %(b)d' % locals()
1 Mod() '%(a)s, %(b)d' % locals()
1 Call(func=Name(id='locals', ctx=Load()), args=[], keywords=[]) '%(a)s, %(b)d' % locals()
1 Name(id='locals', ctx=Load()) '%(a)s, %(b)d' % locals()
use name "locals"
1 Load() '%(a)s, %(b)d' % locals()
____________________________ test_new_format_string ____________________________

v = <vulture.core.Vulture object at 0x7fefdff396d0>

    def test_new_format_string(v):
        v.scan("'{a}, {b:0d} {c:<30} {d:.2%}'.format(**locals())")
>       check(v.used_names, ['a', 'b', 'c', 'd', 'locals'])

tests/test_format_strings.py:12: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

items_or_names = LoggingSet({'locals'})
expected_names = ['a', 'b', 'c', 'd', 'locals']

    def check(items_or_names, expected_names):
        if isinstance(items_or_names, set):
            # items_or_names is a set of strings.
>           assert items_or_names == set(expected_names)
E           AssertionError

tests/__init__.py:10: AssertionError
----------------------------- Captured stdout call -----------------------------
1 Module(body=[Expr(value=Call(func=Attribute(value=Constant(value='{a}, {b:0d} {c:<30} {d:.2%}', kind=None), attr='format', ctx=Load()), args=[], keywords=[keyword(arg=None, value=Call(func=Name(id='locals', ctx=Load()), args=[], keywords=[]))]))], type_ignores=[]) '{a}, {b:0d} {c:<30} {d:.2%}'.format(**locals())
1 Expr(value=Call(func=Attribute(value=Constant(value='{a}, {b:0d} {c:<30} {d:.2%}', kind=None), attr='format', ctx=Load()), args=[], keywords=[keyword(arg=None, value=Call(func=Name(id='locals', ctx=Load()), args=[], keywords=[]))])) '{a}, {b:0d} {c:<30} {d:.2%}'.format(**locals())
1 Call(func=Attribute(value=Constant(value='{a}, {b:0d} {c:<30} {d:.2%}', kind=None), attr='format', ctx=Load()), args=[], keywords=[keyword(arg=None, value=Call(func=Name(id='locals', ctx=Load()), args=[], keywords=[]))]) '{a}, {b:0d} {c:<30} {d:.2%}'.format(**locals())
1 Attribute(value=Constant(value='{a}, {b:0d} {c:<30} {d:.2%}', kind=None), attr='format', ctx=Load()) '{a}, {b:0d} {c:<30} {d:.2%}'.format(**locals())
use attribute "format"
1 Constant(value='{a}, {b:0d} {c:<30} {d:.2%}', kind=None) '{a}, {b:0d} {c:<30} {d:.2%}'.format(**locals())
1 Load() '{a}, {b:0d} {c:<30} {d:.2%}'.format(**locals())
1 keyword(arg=None, value=Call(func=Name(id='locals', ctx=Load()), args=[], keywords=[])) '{a}, {b:0d} {c:<30} {d:.2%}'.format(**locals())
1 Call(func=Name(id='locals', ctx=Load()), args=[], keywords=[]) '{a}, {b:0d} {c:<30} {d:.2%}'.format(**locals())
1 Name(id='locals', ctx=Load()) '{a}, {b:0d} {c:<30} {d:.2%}'.format(**locals())
use name "locals"
1 Load() '{a}, {b:0d} {c:<30} {d:.2%}'.format(**locals())
________________________ test_new_format_string_access _________________________

v = <vulture.core.Vulture object at 0x7fefdfe333a0>

    def test_new_format_string_access(v):
        v.scan("'{a.b}, {c.d.e} {f[g]} {h[i][j]}'.format(**locals())")
>       check(v.used_names, ['a', 'c', 'f', 'h', 'locals'])

tests/test_format_strings.py:17: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

items_or_names = LoggingSet({'locals'})
expected_names = ['a', 'c', 'f', 'h', 'locals']

    def check(items_or_names, expected_names):
        if isinstance(items_or_names, set):
            # items_or_names is a set of strings.
>           assert items_or_names == set(expected_names)
E           AssertionError

tests/__init__.py:10: AssertionError
----------------------------- Captured stdout call -----------------------------
1 Module(body=[Expr(value=Call(func=Attribute(value=Constant(value='{a.b}, {c.d.e} {f[g]} {h[i][j]}', kind=None), attr='format', ctx=Load()), args=[], keywords=[keyword(arg=None, value=Call(func=Name(id='locals', ctx=Load()), args=[], keywords=[]))]))], type_ignores=[]) '{a.b}, {c.d.e} {f[g]} {h[i][j]}'.format(**locals())
1 Expr(value=Call(func=Attribute(value=Constant(value='{a.b}, {c.d.e} {f[g]} {h[i][j]}', kind=None), attr='format', ctx=Load()), args=[], keywords=[keyword(arg=None, value=Call(func=Name(id='locals', ctx=Load()), args=[], keywords=[]))])) '{a.b}, {c.d.e} {f[g]} {h[i][j]}'.format(**locals())
1 Call(func=Attribute(value=Constant(value='{a.b}, {c.d.e} {f[g]} {h[i][j]}', kind=None), attr='format', ctx=Load()), args=[], keywords=[keyword(arg=None, value=Call(func=Name(id='locals', ctx=Load()), args=[], keywords=[]))]) '{a.b}, {c.d.e} {f[g]} {h[i][j]}'.format(**locals())
1 Attribute(value=Constant(value='{a.b}, {c.d.e} {f[g]} {h[i][j]}', kind=None), attr='format', ctx=Load()) '{a.b}, {c.d.e} {f[g]} {h[i][j]}'.format(**locals())
use attribute "format"
1 Constant(value='{a.b}, {c.d.e} {f[g]} {h[i][j]}', kind=None) '{a.b}, {c.d.e} {f[g]} {h[i][j]}'.format(**locals())
1 Load() '{a.b}, {c.d.e} {f[g]} {h[i][j]}'.format(**locals())
1 keyword(arg=None, value=Call(func=Name(id='locals', ctx=Load()), args=[], keywords=[])) '{a.b}, {c.d.e} {f[g]} {h[i][j]}'.format(**locals())
1 Call(func=Name(id='locals', ctx=Load()), args=[], keywords=[]) '{a.b}, {c.d.e} {f[g]} {h[i][j]}'.format(**locals())
1 Name(id='locals', ctx=Load()) '{a.b}, {c.d.e} {f[g]} {h[i][j]}'.format(**locals())
use name "locals"
1 Load() '{a.b}, {c.d.e} {f[g]} {h[i][j]}'.format(**locals())
______________________ test_new_format_string_attributes _______________________

v = <vulture.core.Vulture object at 0x7fefdfe0da60>

    def test_new_format_string_attributes(v):
        v.scan("'{a.b}, {c.d.e} {f[g]} {h[i][j].k}'.format(**locals())")
>       check(v.used_names, ['a', 'c', 'f', 'h', 'locals'])

tests/test_format_strings.py:22: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

items_or_names = LoggingSet({'locals'})
expected_names = ['a', 'c', 'f', 'h', 'locals']

    def check(items_or_names, expected_names):
        if isinstance(items_or_names, set):
            # items_or_names is a set of strings.
>           assert items_or_names == set(expected_names)
E           AssertionError

tests/__init__.py:10: AssertionError
----------------------------- Captured stdout call -----------------------------
1 Module(body=[Expr(value=Call(func=Attribute(value=Constant(value='{a.b}, {c.d.e} {f[g]} {h[i][j].k}', kind=None), attr='format', ctx=Load()), args=[], keywords=[keyword(arg=None, value=Call(func=Name(id='locals', ctx=Load()), args=[], keywords=[]))]))], type_ignores=[]) '{a.b}, {c.d.e} {f[g]} {h[i][j].k}'.format(**locals())
1 Expr(value=Call(func=Attribute(value=Constant(value='{a.b}, {c.d.e} {f[g]} {h[i][j].k}', kind=None), attr='format', ctx=Load()), args=[], keywords=[keyword(arg=None, value=Call(func=Name(id='locals', ctx=Load()), args=[], keywords=[]))])) '{a.b}, {c.d.e} {f[g]} {h[i][j].k}'.format(**locals())
1 Call(func=Attribute(value=Constant(value='{a.b}, {c.d.e} {f[g]} {h[i][j].k}', kind=None), attr='format', ctx=Load()), args=[], keywords=[keyword(arg=None, value=Call(func=Name(id='locals', ctx=Load()), args=[], keywords=[]))]) '{a.b}, {c.d.e} {f[g]} {h[i][j].k}'.format(**locals())
1 Attribute(value=Constant(value='{a.b}, {c.d.e} {f[g]} {h[i][j].k}', kind=None), attr='format', ctx=Load()) '{a.b}, {c.d.e} {f[g]} {h[i][j].k}'.format(**locals())
use attribute "format"
1 Constant(value='{a.b}, {c.d.e} {f[g]} {h[i][j].k}', kind=None) '{a.b}, {c.d.e} {f[g]} {h[i][j].k}'.format(**locals())
1 Load() '{a.b}, {c.d.e} {f[g]} {h[i][j].k}'.format(**locals())
1 keyword(arg=None, value=Call(func=Name(id='locals', ctx=Load()), args=[], keywords=[])) '{a.b}, {c.d.e} {f[g]} {h[i][j].k}'.format(**locals())
1 Call(func=Name(id='locals', ctx=Load()), args=[], keywords=[]) '{a.b}, {c.d.e} {f[g]} {h[i][j].k}'.format(**locals())
1 Name(id='locals', ctx=Load()) '{a.b}, {c.d.e} {f[g]} {h[i][j].k}'.format(**locals())
use name "locals"
1 Load() '{a.b}, {c.d.e} {f[g]} {h[i][j].k}'.format(**locals())
________________________ test_new_format_string_numbers ________________________

v = <vulture.core.Vulture object at 0x7fefdfe1de50>

    def test_new_format_string_numbers(v):
        v.scan("'{0.b}, {0.d.e} {0[1]} {0[1][1].k}'.format('foo')")
        check(v.used_names, [])
>       check(v.used_attrs, ['b', 'd', 'e', 'k', 'format'])

tests/test_format_strings.py:29: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

items_or_names = LoggingSet({'format'})
expected_names = ['b', 'd', 'e', 'k', 'format']

    def check(items_or_names, expected_names):
        if isinstance(items_or_names, set):
            # items_or_names is a set of strings.
>           assert items_or_names == set(expected_names)
E           AssertionError

tests/__init__.py:10: AssertionError
----------------------------- Captured stdout call -----------------------------
1 Module(body=[Expr(value=Call(func=Attribute(value=Constant(value='{0.b}, {0.d.e} {0[1]} {0[1][1].k}', kind=None), attr='format', ctx=Load()), args=[Constant(value='foo', kind=None)], keywords=[]))], type_ignores=[]) '{0.b}, {0.d.e} {0[1]} {0[1][1].k}'.format('foo')
1 Expr(value=Call(func=Attribute(value=Constant(value='{0.b}, {0.d.e} {0[1]} {0[1][1].k}', kind=None), attr='format', ctx=Load()), args=[Constant(value='foo', kind=None)], keywords=[])) '{0.b}, {0.d.e} {0[1]} {0[1][1].k}'.format('foo')
1 Call(func=Attribute(value=Constant(value='{0.b}, {0.d.e} {0[1]} {0[1][1].k}', kind=None), attr='format', ctx=Load()), args=[Constant(value='foo', kind=None)], keywords=[]) '{0.b}, {0.d.e} {0[1]} {0[1][1].k}'.format('foo')
1 Attribute(value=Constant(value='{0.b}, {0.d.e} {0[1]} {0[1][1].k}', kind=None), attr='format', ctx=Load()) '{0.b}, {0.d.e} {0[1]} {0[1][1].k}'.format('foo')
use attribute "format"
1 Constant(value='{0.b}, {0.d.e} {0[1]} {0[1][1].k}', kind=None) '{0.b}, {0.d.e} {0[1]} {0[1][1].k}'.format('foo')
1 Load() '{0.b}, {0.d.e} {0[1]} {0[1][1].k}'.format('foo')
1 Constant(value='foo', kind=None) '{0.b}, {0.d.e} {0[1]} {0[1][1].k}'.format('foo')
______________________________ test_size_if_else _______________________________

    def test_size_if_else():
        example = """
    @identity
    class Foo(object):
        @identity
        @identity
        def bar(self):
            if "a" == "b":
                pass
            elif "b" == "c":
                pass
            else:
                pass
    """
>       check_size(example, 11)

tests/test_size.py:81: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

example = '\n@identity\nclass Foo(object):\n    @identity\n    @identity\n    def bar(self):\n        if "a" == "b":\n            pass\n        elif "b" == "c":\n            pass\n        else:\n            pass\n'
size = 11

    def check_size(example, size):
        tree = ast.parse(example)
        for node in tree.body:
            if isinstance(node, ast.ClassDef) and node.name == 'Foo':
>               assert count_lines(node) == size
E               assert 10 == 11
E                +  where 10 = count_lines(<_ast.ClassDef object at 0x7fefdfeb2520>)

tests/test_size.py:36: AssertionError

----------- coverage: platform linux, python 3.8.0-beta-2 ------------
Name                                    Stmts   Miss  Cover
-----------------------------------------------------------
vulture/__init__.py                         3      0   100%
vulture/__main__.py                         2      0   100%
vulture/core.py                           287      7    98%
vulture/lines.py                           28      0   100%
vulture/utils.py                           74      3    96%
vulture/whitelists/argparse.py   error: Bad exit status from /var/tmp/rpm-tmp.Gj0xwt (%check)
           6      0   100%
vulture/whitelists/ast.py                  67      0   100%
vulture/whitelists/collections.py           3      0   100%
vulture/whitelists/sys.py                   5      0   100%
vulture/whitelists/unittest.py             13      0   100%
vulture/whitelists/whitelist_utils.py       4      0   100%
-----------------------------------------------------------
TOTAL                                     492     10    98%
Coverage HTML written to dir htmlcov

===================== 6 failed, 138 passed in 3.47 seconds =====================

This might be related to https://github.com/python/cpython/pull/9445
Comment 2 Yatin Karel 2019-07-23 10:43:27 UTC 
Created an issue with vulture:- https://github.com/jendrikseipp/vulture/issues/166
Comment 3 Ben Cotton 2019-08-13 16:49:04 UTC 
This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle.
Changing version to '31'.
Comment 4 Miro Hrončok 2019-08-14 22:24:27 UTC 
The coordinated rebuild of Python 3.8 has started in the `f32-python` side tag.

If you figure out how to rebuild this package, please don't rebuild it in regular rawhide, but use the side tag instead:

    on branch master:
    $ fedpkg build --target=f32-python

To wait for a build to show up in the side tag, do:

    $ koji wait-repo f32-python --build=<nvr>

Where <nvr> is name-version-release of the source package, e.g. python-foo-1.1-2.fc32.

An updated mock config is posted at:
http://copr.fedorainfracloud.org/coprs/g/python/python3.8/

Note that it will take a while before the essential packages are rebuilt, so don't expect all your dependencies to be available right away.

Thanks. Let us know if you need up to date info, or if you have any questions.



PS this message is mass posted to all the bugs that block the PYTHON38 bug. If this is also a Fedora 31 FTBFS bug and you manage to fix it, you can do a f31 build as usual:

    on branch f31:
    $ fedpkg build
Comment 5 Miro Hrončok 2019-08-21 16:35:12 UTC 
The f32-python side tag has been merged. In order to rebuild the package, do it in regular rawhide, but please wait until python3-3.8 is tagged:

  $ koji wait-repo f32-build --build python3-3.8.0~b3-3.fc32


If your built already started in f32-python, after it is finished, please tag it to rawhide with:

  $ koji tag-build f32-pending <nvr>

For example:

  $ koji tag-build f32-pending libreoffice-6.3.0.4-3.fc32

Thanks!

(This comment is mass posted to all bugzillas blocking the PYTHON38 tracking bug.)
Comment 6 Miro Hrončok 2019-08-21 17:29:16 UTC 
(Python 3.8 has landed in the rawhide buildroot.)
Comment 7 Yatin Karel 2019-08-30 12:34:19 UTC 
built against rawhide, temporary disabled test until vulture pushes fixes for python3.8:- https://koji.fedoraproject.org/koji/buildinfo?buildID=1367414
Note You need to log in before you can comment on or make changes to this bug.