Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1717660 - python-parso fails to build with Python 3.8
Summary: python-parso fails to build with Python 3.8
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: python-parso
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
urgent
Target Milestone: ---
Assignee: Carl George
QA Contact: Fedora Extras Quality Assurance
URL: https://copr.fedorainfracloud.org/cop...
Whiteboard:
Depends On: 1722645
Blocks: PYTHON38
TreeView+ depends on / blocked
 
Reported: 2019-06-05 21:44 UTC by Miro Hrončok
Modified: 2019-06-25 13:57 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-06-25 13:57:41 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Miro Hrončok 2019-06-05 21:44:31 UTC
python-parso fails to build with Python 3.8.0b1. See https://copr.fedorainfracloud.org/coprs/g/python/python3.8/package/python-parso/ for actual logs. This report is automated and not very verbose, but I'll get back here with details.

Comment 1 Miro Hrončok 2019-06-05 21:55:17 UTC
=================================== FAILURES ===================================
___________________ test_python_exception_matches[f'{a=3}'] ____________________

code = "f'{a=3}'"

    @pytest.mark.parametrize('code', FAILING_EXAMPLES)
    def test_python_exception_matches(code):
        wanted, line_nr = _get_actual_exception(code)
    
        errors = _get_error_list(code)
        actual = None
        if errors:
            error, = errors
            actual = error.message
>       assert actual in wanted
E       AssertionError: assert 'SyntaxError: invalid syntax' in ['SyntaxError: EOL while scanning string literal']

test/test_python_errors.py:39: AssertionError
=============== 1 failed, 934 passed, 1 xfailed in 11.05 seconds ===============

Comment 2 Miro Hrončok 2019-06-10 16:42:56 UTC
This issue is blocking the Python 3.8 rebuilds. If this package won't build with 3.8, it won't be installable, along with all its dependent packages, after the side tag is merged.
Furthermore, as it fails to install, its dependent packages will fail to install and/or build as well. The fix should be pushed on the master branch and no release bump is required.

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.8: https://copr.fedorainfracloud.org/coprs/g/python/python3.8/

This issue needs to be resolved by next week, if other rebuilds of Python 3.8 beta 1 go well. If this is unrealistic for you, let us know how much time you need.

If you don't have free cycles to dedicate fixing your package, notify us and we'll try to provide some pointers. Let us know if we can push a fix directly without a pull request, in the case we happen to have one before you do.

We recommend always consulting with upstream, chances are this is already fixed there.

Comment 3 Petr Viktorin 2019-06-11 12:19:19 UTC
Fixes are in upstream commits:
    https://github.com/davidhalter/parso/commit/6cdd47fe2b2efcb7f7b7f73a44f2d142caf39b44
    https://github.com/davidhalter/parso/commit/5430415d4463900c1780488f9cdddc5eb9814ecc

I can open a dist-git PR if upstream doesn't release these quick enough.

Comment 4 Carl George 2019-06-13 13:50:45 UTC
It appears that 0.5.0 will have these fixes.  It's already in the changelog, but isn't tagged yet or published on PyPI.  I've nudged upstream, we'll see what they say.

https://github.com/davidhalter/parso/commit/b5d50392a4058919c0018666cdfc8c3eaaea9cb5

Comment 5 Carl George 2019-06-25 13:57:41 UTC
I've built 0.5.0 in rawhide, and confirmed it builds locally with the python3.8 copr enabled.  It should be ready now for the python3.8 mass rebuild.  Let me know if you see any other issues.


Note You need to log in before you can comment on or make changes to this bug.