Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1718366 - python-typing-extensions fails to build with Python 3.8
Summary: python-typing-extensions fails to build with Python 3.8
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: python-typing-extensions
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: ---
Assignee: Jonny Heggheim
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PYTHON38
TreeView+ depends on / blocked
 
Reported: 2019-06-07 14:42 UTC by Petr Viktorin
Modified: 2019-07-12 11:22 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-07-12 11:22:11 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github python typing issues 643 0 None None None 2019-06-08 12:24:16 UTC

Description Petr Viktorin 2019-06-07 14:42:46 UTC 
python-typing-extensions fails to build with Python 3.8.0b1.

From the build log, it looks like some of the extensions were moved to Python's own typing module, invalidating the tests' expectations:
======================================================================
FAIL: test_typing_extensions_defers_when_possible (__main__.AllTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "src_py3/test_typing_extensions.py", line 1384, in test_typing_extensions_defers_when_possible
    self.assertIs(
AssertionError: <function final at 0x7fd16783f280> is not <function final at 0x7fd167c929d0>
======================================================================
FAIL: test_repr (__main__.LiteralTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "src_py3/test_typing_extensions.py", line 237, in test_repr
    self.assertEqual(repr(Literal[1]), "typing_extensions.Literal[1]")
AssertionError: 'typing.Literal[1]' != 'typing_extensions.Literal[1]'
- typing.Literal[1]
+ typing_extensions.Literal[1]
?       +++++++++++
----------------------------------------------------------------------


For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.8/fedora-rawhide-x86_64/00927854-python-typing-extensions/

For all our attempts to build python-typing-extensions with Python 3.8, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.8/package/python-typing-extensions/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.8:
https://copr.fedorainfracloud.org/coprs/g/python/python3.8/

Let us know here if you have any questions.
Comment 1 Jonny Heggheim 2019-06-17 07:22:30 UTC 
This have been fixed by upstream in master
Comment 2 Miro Hrončok 2019-07-10 15:10:19 UTC 
Could you please backport the fix?
Comment 3 Jonny Heggheim 2019-07-10 20:43:01 UTC 
(In reply to Miro Hrončok from comment #2)
> Could you please backport the fix?

I will not backport the fix, but I welcome others to apply the patch and test. It is possible to use the newer version?
Comment 4 Miro Hrončok 2019-07-10 22:25:24 UTC 
> It is possible to use the newer version?

Possible how?
Comment 5 Jonny Heggheim 2019-07-12 08:58:12 UTC 
(In reply to Miro Hrončok from comment #4)
> > It is possible to use the newer version?
> 
> Possible how?

You asked to backport the fix. Why not update to the latest version?

I see that I have not built for rawhide, doing it now. Just let me know if you want to push updates to f30 (and f29)
Comment 6 Miro Hrončok 2019-07-12 09:09:20 UTC 
> You asked to backport the fix. Why not update to the latest version?

You've said this have been fixed by upstream in master. I assumed the fix is not yet in a released version. If it is, update should work as well.


> Just let me know if you want to push updates to f30 (and f29)

Not needed. Thanks.
Comment 7 Jonny Heggheim 2019-07-12 10:14:02 UTC 
Great, just some misunderstandings. 

Can you test against the latest build in rawhide?
https://koji.fedoraproject.org/koji/buildinfo?buildID=1312400
Comment 8 Miro Hrončok 2019-07-12 11:22:11 UTC 
Thanks, builds.
Note You need to log in before you can comment on or make changes to this bug.