Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at
Bug 172140 - Review Request: libmal: a convenience library for malsync
Summary: Review Request: libmal: a convenience library for malsync
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: John Mahowald
QA Contact: David Lawrence
: 172141 (view as bug list)
Depends On:
TreeView+ depends on / blocked
Reported: 2005-10-31 19:20 UTC by Rex Dieter
Modified: 2007-11-30 22:11 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2006-03-22 15:28:34 UTC
Type: ---

Attachments (Terms of Use)

Description Rex Dieter 2005-10-31 19:20:12 UTC
Spec Name or Url:
SRPM Name or Url:
A convenience library of the object files contained in Tom Whittaker's
malsync distribution, along with a few wrapper functions.

Comment 1 Rex Dieter 2005-10-31 19:36:15 UTC
*** Bug 172141 has been marked as a duplicate of this bug. ***

Comment 2 Chris Chabot 2006-01-18 14:23:31 UTC
Still looking for a reviewer? I'd be willing to pick it up. I see upstream has a
new version (0.40), want to update it to that version or want the review to be
for this one?

Comment 3 Rex Dieter 2006-02-06 02:01:49 UTC
Yes, still need a reviewer.  No, I want/need libmal-0.31, since that's what
kdepim currently can use.

When/if there's ever a need/demand for 0.40, we can make a compat pkg.

Comment 4 Mike McGrath 2006-02-22 12:00:58 UTC
Looks good

Do the patches included in this srpm have an upstream url that you could append
to them in the spec file?

Comment 5 Rex Dieter 2006-02-22 12:46:01 UTC
The patches are from me, so there is no upstream url for them.

Comment 6 John Mahowald 2006-02-24 15:49:40 UTC
Looks good overall, a few nitpicks:

Needs work:
* rpmlint of libmal: Remove empty files and capitalize summary.
* The package should contain the text of the license
  (wiki: PackageReviewGuidelines)

Just a couple spec tweaks, and query the author to package the license with the

Comment 7 John Mahowald 2006-03-21 22:46:21 UTC
Oh, the license is included. Never mind about that.

- rpmlint checks return:
W: libmal summary-not-capitalized a convenience library for malsync
W: libmal summary-not-capitalized a convenience library for malsync
E: libmal zero-length /usr/share/doc/libmal-0.31/TODO
E: libmal zero-length /usr/share/doc/libmal-0.31/NEWS
E: libmal zero-length /usr/share/doc/libmal-0.31/AUTHORS
W: libmal-debuginfo objdump-failed
E: libmal-devel only-non-binary-in-usr-lib

Capitalize summary and remove empty files. for devel package,
only-non-binary-in-usr-lib, it's a symlink, ignore.

- package meets naming guidelines
- package meets packaging guidelines
- license (MPL) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file

- devel package ok
- no .la files
- post/postun ldconfig ok
- devel requires base package n-v-r 


Comment 8 Rex Dieter 2006-03-22 15:28:34 UTC
Thanks, imported, suggested minor changes incomporated into libmal-0.31-2

Note You need to log in before you can comment on or make changes to this bug.