Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 172343 - Review Request: libtomoe-gtk (renamed tomoe-gtk)
Summary: Review Request: libtomoe-gtk (renamed tomoe-gtk)
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: John Mahowald
QA Contact: David Lawrence
URL: http://tomoe.sourceforge.jp/
Whiteboard:
Depends On:
Blocks: FE-ACCEPT 178874
TreeView+ depends on / blocked
 
Reported: 2005-11-03 00:38 UTC by Ryo Dairiki
Modified: 2008-07-09 05:41 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-03-21 22:55:00 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Ryo Dairiki 2005-11-03 00:38:21 UTC
Spec Name or Url: http://proxy.f2.ymdb.yahoofs.jp/users/d1e4801f/bc/libtomoe-gtk/libtomoe-gtk.spec?bcpaA4DB7yOz1XS.
SRPM Name or Url: http://proxy.f2.ymdb.yahoofs.jp/users/d1e4801f/bc/libtomoe-gtk/libtomoe-gtk-0.1.0-1.src.rpm?bcpaA4DBjduEbYXg
Description:
Gtk library for tomoe Japanese handwritten input.
This package is used by scim-tomoe, or uim-tomoe.

Comment 1 John Mahowald 2005-12-21 01:50:41 UTC
Build failed.

checking for GTK2... configure: error: Package requirements (gtk+-2.0 >= 2.4.0)
were not met:

No package 'gtk+-2.0' found

You will need BuildRequires: gtk2-devel

Comment 3 John Mahowald 2005-12-27 02:48:03 UTC
Builds in mock now, FC4 i386.

Needs work:
* No downloadable source. Please give the full URL in the Source tag.
* rpmlint of libtomoe-gtk-devel: Limit description lines to 80 characters.
* Missing ldconfig scriptlet at %post and %postun. wiki: ScriptletSnippets

Comment 5 John Mahowald 2006-01-27 14:34:44 UTC
How annoying, the sourceforge link doesn't download automatically. md5sum checks
manually though.

Good:

- rpmlint only notices that ldconfig in spec is a one line script. Can ignore,
or use the -p option (wiki: ScriptletSnippets).
- package meets naming guidelines
- package meets packaging guidelines
- license (GPL) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on FC4 i386
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file


- devel package ok
- no .la files
- devel requires base package n-v-r 

Missing ldconfig for the devel package, which I believe is needed. Looks good
otherwise.

Comment 6 Ryo Dairiki 2006-01-27 15:17:42 UTC
Thank you for reviewing.
I've fixed the following problems.

1. The sourcefiles is not downloaded automatically.
2. You must use "-p" int the "post" and "postun" sections.


SRPM:
http://proxy.f2.ymdb.yahoofs.jp/users/d1e4801f/bc/libtomoe-gtk/libtomoe-gtk-0.1.0-4.src.rpm?bcR5j2DBDHKQ6EjA

SPEC:
http://proxy.f2.ymdb.yahoofs.jp/users/d1e4801f/bc/libtomoe-gtk/libtomoe-gtk.spec?bcR5j2DBlYt9kUIe

Comment 7 John Mahowald 2006-02-04 06:52:35 UTC
Links are not working. bcvrf.yahoo.com could not be found.

Comment 8 Ryo Dairiki 2006-02-04 13:26:19 UTC
I'm sorry, it seems like yahoo briefcase sometimes changes it's download link URLs.

You can see them in libtomoe-gtk folder at http://briefcase.yahoo.co.jp/ryo_dairiki
But I'll upload them as soon as I get a better file sharering repository.

Comment 9 Ryo Dairiki 2006-02-11 07:58:36 UTC
Now it's okay.
I've uploaded them on the stable place.

SRPM:
http://homepage2.nifty.com/shibatama/garage/libtomoe-gtk-0.1.0-4.src.rpm

SPEC:
http://homepage2.nifty.com/shibatama/garage/libtomoe-gtk.spec

# I'm sorry to have trouble you, with the old repository.

Comment 10 John Mahowald 2006-02-27 15:55:41 UTC
New site downloads much better.

One thing still blocking: the devel subpackage needs it's own call to ldconfig.
See the ReviewGuidelines on the wiki.

Good:

- rpmlint checks return:
W: libtomoe-gtk-debuginfo objdump-failed
Not critical.

- package meets naming guidelines
- package meets packaging guidelines
- license (GPL) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- locales handled by %find_lang
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file


- devel package ok
- no .la files
- devel requires base package n-v-r 

Comment 11 Ryo Dairiki 2006-02-28 00:37:16 UTC
SPEC: http://homepage2.nifty.com/shibatama/garage/libtomoe-gtk.spec
SRPM: http://homepage2.nifty.com/shibatama/garage/libtomoe-gtk-0.5. 

I've added ldconfig for the devel package.
But I still get some errors and warnings, do you have any idea?

rpmlint libtomot-gtk-devel:
E: libtomoe-gtk-devel only-non-binary-in-usr-lib
(Yeah, there is only "libtomoe-gtk.so" in that directory)

rpmlint libtomoe-gtk-debuginfo:
W: libtomoe-gtk-debuginfo objdump-failed
(What is it?)

Comment 13 Jens Petersen 2006-02-28 00:57:59 UTC
Sorry, why does the -devel package need ldconfig?

Comment 14 John Mahowald 2006-02-28 03:08:54 UTC
Initially I saw this guideline:

- MUST: If the package contains shared library files located in the dynamic
linker's default paths, that package must call ldconfig in %post and %postun. If
the package has multiple subpackages with libraries, each subpackage should also
have a %post/%postun section that calls /sbin/ldconfig.
http://fedoraproject.org/wiki/Packaging/ReviewGuidelines

and thought that there was a devel subpackage that has an object in the linker's
path. However, on second thought, this is merely a symlink to the library in the
main libtomoe-gtk package and so doesn't need it.

What rpmlint has to say about objdump-failed:
Executing objdump on this file failed, all checks could not be run.
Which just means rpmlint couldn't examine the object files further. This is not
serious.

APPROVED

Comment 15 Ryo Dairiki 2006-02-28 04:20:33 UTC
Okay, thanks.

Comment 16 John Mahowald 2006-03-21 22:55:00 UTC
Package in the repository. Please close bug when package builds successfully.

Closing.

Comment 17 Christian Iseli 2006-04-08 20:56:37 UTC
Please add the package in owners.list

Comment 18 Ryo Dairiki 2006-04-08 23:39:10 UTC
> Please add the package in owners.list

Done, thanks.

Comment 19 Jens Petersen 2008-07-09 05:41:09 UTC
Renaming this package to tomoe-gtk since that has been the upstream name for
some time.


Note You need to log in before you can comment on or make changes to this bug.