Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at
Bug 172579 - Review Request: gtkwave - Waveform Viewer
Summary: Review Request: gtkwave - Waveform Viewer
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Michael A. Peters
QA Contact: David Lawrence
Depends On:
TreeView+ depends on / blocked
Reported: 2005-11-07 15:16 UTC by Paul Howarth
Modified: 2007-11-30 22:11 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2005-11-23 11:30:48 UTC
Type: ---

Attachments (Terms of Use)

Description Paul Howarth 2005-11-07 15:16:46 UTC
Spec Name or Url:
SRPM Name or Url:

GTKWave is a waveform viewer that can view VCD files produced by most Verilog
simulation tools, as well as LXT files produced by certain Verilog simulation

This package includes support for reading .ghw files as produced by ghdl.

This review request follows on from Bug 172547, which was a combined ghdl/gtkwave submission.

Comment 1 Thomas Sailer 2005-11-07 16:50:19 UTC
Thanks, looks good. Compiled and tested against a GHDL ghw file, works.

rpmlint gives me these:
E: gtkwave unknown-key GPG#b56a8bac
E: gtkwave configure-without-libdir-spec

I've sent the ghw patch to the gtkwave author, no answer yet, but we'll see...

Comment 2 Paul Howarth 2005-11-07 17:06:57 UTC
(In reply to comment #1)
> Thanks, looks good. Compiled and tested against a GHDL ghw file, works.
> rpmlint gives me these:
> E: gtkwave unknown-key GPG#b56a8bac

This is normal since I signed the package and rpmlint doesn't recognise my key.

> E: gtkwave configure-without-libdir-spec

This is to be expected since gtkwave's configure script is not an
autotools-generated one and does not expect a --libdir= parameter.

> I've sent the ghw patch to the gtkwave author, no answer yet, but we'll see...

Hopefully it'll get included upstream, since it doesn't (I think) break any
current feature.

Are you able to approve the package?

Comment 3 Paul Howarth 2005-11-08 07:18:47 UTC
Package now updated to 1.3.77, which includes the ghw support upstream so the
patches are dropped.

Comment 6 Michael A. Peters 2005-11-22 23:21:34 UTC
Looks good - there's an rpmlint errors:

[mpeters@utility result]$ ls *.rpm
gtkwave-1.3.79-1.fc4.i386.rpm  gtkwave-debuginfo-1.3.79-1.fc4.i386.rpm
[mpeters@utility result]$ rpmlint *.rpm
E: gtkwave configure-without-libdir-spec
E: gtkwave-debuginfo script-without-shellbang
[mpeters@utility result]$ 

First can be ignored, second probably can be fixed.

I'll work on formal review, with the rpmlint debuginfo noted.

Comment 7 Michael A. Peters 2005-11-22 23:28:06 UTC
[mpeters@utility gtkwave-1.3.79]$ ls -l src/helpers/ |grep "h$"
-rw-r--r--  1 mpeters family  8608 Jan 18  2004 lxt2_read.h
-rw-r--r--  1 mpeters family  9684 Feb  4  2004 lxt2_write.h
-rwxr-xr-x  1 mpeters family  7863 Oct 26 22:17 lxt_write.h
-rw-r--r--  1 mpeters family  3689 Feb  4  2004 v2l_analyzer.h
-rw-r--r--  1 mpeters family  3615 Feb 22  2004 v2l_analyzer_lxt2.h
-rw-r--r--  1 mpeters family  2654 Nov  3  2002 v2l_debug.h
-rw-r--r--  1 mpeters family  2654 Feb 11  2003 v2l_debug_lxt2.h
-rw-r--r--  1 mpeters family  8149 Mar 26  2005 vzt_read.h
-rw-r--r--  1 mpeters family  9014 Feb 27  2005 vzt_write.h

removing the execution bit on that header file should fix the debuginfo rpmlint

Comment 8 Michael A. Peters 2005-11-23 00:04:33 UTC
Review per

Needs Work:
See rpmlint comment #6 and #7

* With above noted exception, rpmlint clean
- error on configure ignorable as explained in comment #2
* Package properly named according to guidelines
* Spec file name matches src.rpm name
* Package meets packaging guidelines
* Package license (GPL & MIT) matches src
* License files in %doc
* Written in American English, legible
* Source matches upstream timestamp and md5sum
* Package succesfully builds on x86 (fc4)
* No BuildRequires in exceptions section of packaging guidelines
* All other BuildRequires properly specified
* No locale files that need find_lang
* No shared libraries
* No use of Prefix
* Package owns all directories it creates
* Proper Permissions
* Proper %clean
* consistent use of macros
* contains permissable code
* does not need docs subpackage
* Works without files in %doc
* No devel package concerns
** Desktop File - 
   - 'Twould be nice if it had one, but as explained in specfile:
# Note that GTKWave is a GUI application but no desktop entry is provided for it.
# This is because the application requires at least one mandatory parameter (file
# to view) and cannot be opened in a "no file" mode from a menu.
   - Hopefully upstream will decide to change that at some point.
* Package builds in mock

Fix the rpmlint warning on debuginfo package and I'll approve.

Comment 9 Paul Howarth 2005-11-23 10:22:31 UTC
Updated package fixes debuginfo rpmlint issue. I also added a comment in the
spec file about the configure script not being an autotools-generated one and
hence not supporting --libdir.

Comment 10 Michael A. Peters 2005-11-23 10:48:02 UTC

Comment 11 Paul Howarth 2005-11-23 11:30:48 UTC
Build on target fedora-development-extras succeeded.

Note You need to log in before you can comment on or make changes to this bug.