Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 172871 - Review Request: driftnet
Summary: Review Request: driftnet
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Adrian Reber
QA Contact: David Lawrence
URL:
Whiteboard:
: 187684 (view as bug list)
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2005-11-10 19:12 UTC by Bastien Nocera
Modified: 2007-11-30 22:11 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-04-03 12:45:27 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)
spec patch (3.26 KB, patch)
2005-11-11 15:11 UTC, Adrian Reber 		no flags Details | Diff
View All

Description Bastien Nocera 2005-11-10 19:12:22 UTC 
Spec Name or Url: http://files.hadess.net/redhat/perso/spec/driftnet.spec
SRPM Name or Url: http://files.hadess.net/redhat/perso/source/driftnet-0.1.6-4.src.rpm
Description:
Driftnet is a program which listens to network traffic and picks out images from
TCP streams it observes. Fun to run on a host which sees lots of web traffic.
Comment 1 Adrian Reber 2005-11-11 15:07:54 UTC 
I will attach a patch for the spec file because it had just to many differences
with the packaging guidelines to list them all here.
Comment 2 Adrian Reber 2005-11-11 15:11:51 UTC 
Created attachment 120944 [details]
spec patch

The changes are:
- added URL
- added full URL for source0
- changed buildroot
- added requires %{_bindir}/consolehelper
- fixed description (< 80 characters)
- %setup -q
- honour RPM_OPT_FLAGS
- parallel build
- use of macros instead of hardcoded paths
- added clean section
Comment 3 Bastien Nocera 2005-11-11 15:55:39 UTC 
That was pretty gross indeed. I should really have checked the spec file before
putting it there ;)
Thanks Adrian.

Spec Name or Url: http://files.hadess.net/redhat/perso/spec/driftnet.spec
SRPM Name or Url:
http://files.hadess.net/redhat/perso/source/driftnet-0.1.6-5.src.rpm
Comment 4 Adrian Reber 2005-11-14 07:59:41 UTC 
- builds in mock
- source matches upstream
- spec looks good
- additional sources and patch look good
- clean installation and removal

Not approving yet as following makes me nervous, especially as this is running
as root:

/builddir/build/BUILD/driftnet-0.1.6/driftnet.c:588: warning: the use of
`tmpnam' is dangerous, better use `mkstemp'
Comment 5 Michael A. Peters 2005-11-14 08:16:33 UTC 
http://mirror.espri.arizona.edu/gentoo/rsync/net-analyzer/driftnet/files/driftnet-0.1.6-tmpnam-is-bad.diff

That's a gentoo patch for the tmpnam issue.
Comment 6 Bastien Nocera 2005-11-14 11:13:05 UTC 
Yay for the gentoo patch which doesn't clean up after itself...
Comment 7 Bastien Nocera 2005-12-13 16:57:25 UTC 
The mkdtemp in the gentoo patch didn't prefix the template with the user's tempdir.

Updated packages:
http://files.hadess.net/redhat/perso/source/driftnet-0.1.6-6.src.rpm
http://files.hadess.net/redhat/perso/spec/driftnet.spec

Adrian, do you want me to fix more compilation warnings with that, or?
Comment 8 Adrian Reber 2005-12-13 19:40:52 UTC 
* rpmlint is almost happy:
W: driftnet conffile-without-noreplace-flag /etc/security/console.apps/driftnet
W: driftnet no-dependency-on usermode-consoleonly
(can be ignored from my point of view)
* clean installation and removal
* builds in "mock -r fedora-development-i386-core"
* source matches upstream
* spec looks good (almost; see below)
* patches look sane

APPROVED

driftnet-0.1.6-pam.config:

using "auth       include      system-auth" instead of "auth       required    
pam_stack.so service=system-auth" like other applications from rawhide would be
a good idea.

The other warnings are not nice but at least they do not say that it is a
security risk to use them. If you like you can of course fix more warnings :-)

One more fix would be necessary before you upload it. There is a rm -rf in %prep
this should be moved to the beginning of %install.
Comment 9 Christian Iseli 2006-03-28 15:22:25 UTC 
Any particular reason why this package is not yet imported and built ?
Comment 10 Adrian Reber 2006-04-02 18:07:10 UTC 
*** Bug 187684 has been marked as a duplicate of this bug. ***
Comment 11 Bastien Nocera 2006-04-03 12:45:27 UTC 
Pushed to CVS in devel.
Note You need to log in before you can comment on or make changes to this bug.