Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 173671 - Review Request: xfce4-weather-plugin
Summary: Review Request: xfce4-weather-plugin
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Greg DeKoenigsberg
QA Contact: David Lawrence
URL: http://xfce-goodies.berlios.de/
Whiteboard:
Depends On:
Blocks: FE-ACCEPT 173672
TreeView+ depends on / blocked
 
Reported: 2005-11-18 21:01 UTC by Christoph Wickert
Modified: 2014-09-21 21:50 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2005-12-15 02:51:22 UTC
Type: ---
Embargoed:
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Christoph Wickert 2005-11-18 21:01:51 UTC 
Spec Name or Url: 
http://home.arcor.de/christoph.wickert/fedora/extras-review/SPECS/xfce4-weather-plugin.spec
SRPM Name or Url: 
http://home.arcor.de/christoph.wickert/fedora/extras-review/SRPMS/xfce4-weather-plugin-0.4.9-3.fc4.src.rpm
Description: 
A weather plugin for the Xfce panel. It shows the current temperature and weather condition, using weather data provided by xoap.weather.com.

Comments:
rpmlint clean
license BSD included
Comment 1 Luya Tshimbalanga 2005-11-30 18:00:39 UTC 
Hi, 

Using yum-builddep, I noticed there are missed packages for BuildRequires:
- libxfce4gui-devel
- libxfce4util-devel
- libxfce4mcs-devel

Also check out if there is a Requires for that plugin.

When it comes to BSD, could specify it is the original or the modified license.
I think other developers five a very good explaination to avoid confusion.
Comment 2 Christoph Wickert 2005-12-01 01:54:01 UTC 
(In reply to comment #1)
> Hi, 
> 
> Using yum-builddep, I noticed there are missed packages for BuildRequires:
> - libxfce4gui-devel

Added

> - libxfce4util-devel

false positive, pulled automatically by xfcegui-devel.

> - libxfce4mcs-devel

I can't see where this depends on libxfce4mcs-devel:
checking XFCE4_PANEL_CFLAGS... -DXTHREADS -D_REENTRANT -DXUSE_MTSAFE_API
-I/usr/include/xfce4 -I/usr/X11R6/include -I/usr/include/libxml2
-I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/pango-1.0
-I/usr/include/freetype2 -I/usr/include/freetype2/config -I/usr/include/glib-2.0
-I/usr/lib/glib-2.0/include -I/usr/include/atk-1.0
checking XFCE4_PANEL_LIBS... -L/usr/X11R6/lib -lxfcegui4 -lxml2 -lpthread -lz
-lgtk-x11-2.0 -lxfce4util -lgdk-x11-2.0 -latk-1.0 -lgdk_pixbuf-2.0 -lm
-lpangoxft-1.0 -lpangox-1.0 -lpango-1.0 -lgobject-2.0 -lgmodule-2.0 -ldl -lglib-2.0

> 
> Also check out if there is a Requires for that plugin.

Nope, AFAIK not. 

> 
> When it comes to BSD, could specify it is the original or the modified license.
> I think other developers five a very good explaination to avoid confusion.

This is the "New BSD License" from 
http://www.opensource.org/licenses/bsd-license.php

New SRPM
http://home.arcor.de/christoph.wickert/fedora/extras-review/SRPMS/xfce4-weather-plugin-0.4.9-4.fc4.src.rpm
Updated SPEC
http://home.arcor.de/christoph.wickert/fedora/extras-review/SPECS/xfce4-weather-plugin.spec
Comment 3 Luya Tshimbalanga 2005-12-01 08:48:39 UTC 
Congragulations, your src.rpm has succesfully passed the test including rpmlint
with built rpm and mock.

The spec file fully complies with Packaging Guidelines
http://fedoraproject.org/wiki/PackagingGuidelines. 

It is the honor to get xfce4-weather-plugin package status as ACCEPTED.
Comment 4 Christoph Wickert 2005-12-15 02:51:22 UTC 
Thank you very much for your work on my packages. xfce-weather-plugin has build
successfully on all arches & branches.
Comment 5 Mukundan Ragavan 2014-09-21 21:44:07 UTC 
Package Change Request
======================
Package Name: xfce4-weather-plugin
New Branches: epel7
Owners: cwickert
InitialCC: nonamedotc
Comment 6 Gwyn Ciesla 2014-09-21 21:50:53 UTC 
Git done (by process-git-requests).
Note You need to log in before you can comment on or make changes to this bug.