Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1738597 - [wayland] firefox toolbar layout wrong at startup - wrong screen is used
Summary: [wayland] firefox toolbar layout wrong at startup - wrong screen is used
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: firefox
Version: 31
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Jan Horak
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: ffwayland
TreeView+ depends on / blocked
 
Reported: 2019-08-07 14:24 UTC by Hans de Goede
Modified: 2020-11-24 16:47 UTC (History)
12 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-11-24 16:47:43 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)
screencast of the bug (1.51 MB, video/webm)
2019-11-05 12:22 UTC, Laurent Meunier 		no flags Details
wayland_debug_with_bug (47.80 KB, text/plain)
2019-11-06 07:25 UTC, Laurent Meunier 		no flags Details
wayland_debug_without_bug (46.00 KB, text/plain)
2019-11-06 07:25 UTC, Laurent Meunier 		no flags Details
View All

Description Hans de Goede 2019-08-07 14:24:24 UTC 
I've customized my toolbar a bit, it has a separate search entry and the empty areas for dragging are removed.

When I start firefox-wayland (now the default in F31 it seems) often my toolbar looks different, as if it has gone into some fallback mode for really small screens.

Left of my URL bar the home button is gone and on the right side the separate search bar is gone, as well as the bookmarks menu icon and my ublock origin icon, these can now all be found under the overflow ">>" icon. The hamburger menu on the right edge still is there.

If I resize the window and make it smaller, nothing changes. If I make it wider even by one pixel, firefox notices it has plenty of space for my normal toolbar layout and correctly switches to this. It seems as if it is doing the check for this minimal fallback version, before it knows its window size.

I can force the minimal width layout to return after making the window 1 pixel larger by making it much smaller (reducing its width) then its normal startup width and it will jump back to my normal layout by making it slightly bigger then the moment when it goes to the minimal width layout, the moment when it switches back to my normal layout it is still much smaller (less wide) then my normal / startup ff window size.
Comment 1 Ben Cotton 2019-08-13 17:02:14 UTC 
This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle.
Changing version to '31'.
Comment 2 Ben Cotton 2019-08-13 17:34:28 UTC 
This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle.
Changing version to 31.
Comment 3 Martin Stransky 2019-11-05 11:37:12 UTC 
I'm afraid I don't quite understand. Can you please try to create a screencast of the bug?
How-to is here: https://help.gnome.org/users/gnome-help/stable/screen-shot-record.html.en
Comment 4 Laurent Meunier 2019-11-05 12:22:43 UTC 
Created attachment 1632948 [details]
screencast of the bug

Hi Martin,

I've added a screencast of the bug. In the screencast you can see a similar behaviour as described by Hans, except that I don't need to resize the Firefox window to get my toolbar layout restored (I use "Customize Toolbar..." button).

I don't known why the screencast flickers. When I start the screencast with the ctrl-alt-shift-R shortcut, my framerate drops well below 1 fps.
Comment 5 Martin Stransky 2019-11-05 13:55:27 UTC 
Ahh I think I understand now - it looks like small monitor is reported. I see you use multi-monitor scenario, perhaps Firefox takes (wrongly) the primary screen which is smaller than the actual one.
I guess if you turn-off your the second screen and have opened only one you get the correct behavior, am I right?
Thanks.
Comment 6 Martin Stransky 2019-11-05 13:56:17 UTC 
Jan, any idea here?
Comment 7 Hans de Goede 2019-11-05 15:07:40 UTC 
(In reply to Martin Stransky from comment #5)
> Ahh I think I understand now - it looks like small monitor is reported.

Yes it seems that firefox uses a layout which is intended for small monitors.

> I see you use multi-monitor scenario, perhaps Firefox takes (wrongly) the
> primary screen which is smaller than the actual one.
> I guess if you turn-off your the second screen and have opened only one you
> get the correct behavior, am I right?

I also have 2 monitors, but they are both 1920x1080, so I do not believe that this is the case.

My feeling is that Firefox sometimes (often) checks the window size to see if it needs to use the layout for small monitors *before* the window has been assigned a size by the compositor.

As I explained when resizing if I make the window smaller (less wide) then the layout stays the same; but as soon as I make it one pixel wider (even if less wide then the starting width) then things correct itself. I have the feeling the resize handler for some reason (expensive?) only redo-s the check if it needs to stop using the "mini" layout for the toolbars if the window has gotten larger and it skips it when it receives the initial size. Just doing the check when the initial size is received will probably fix / workaround the race here.

Going to customize and then exiting indeed is another workaround.
Comment 8 Laurent Meunier 2019-11-05 17:34:51 UTC 
I was able to reproduce the bug with the second screen turned-off.

I use a laptop docked on a docking station with two monitors pluged on the docking station.
The laptop monitor is not used (the laptop is closed). The two pluged monitors are both 1920x1200.
Comment 9 Martin Stransky 2019-11-06 07:11:28 UTC 
Jan, can you look at it please? There may be wrong screen size reported or so?

Hans, can you run firefox on single monitor setup with WAYLAND_DEBUG=1 env variable set (when the bug is exhibited) and attach the log here?

Thanks.
Comment 10 Martin Stransky 2019-11-06 07:12:21 UTC 
Err sorry I meant Laurent.
Comment 11 Laurent Meunier 2019-11-06 07:25:28 UTC 
Created attachment 1633204 [details]
wayland_debug_with_bug
Comment 12 Laurent Meunier 2019-11-06 07:25:46 UTC 
Created attachment 1633205 [details]
wayland_debug_without_bug
Comment 13 Laurent Meunier 2019-11-06 07:27:41 UTC 
I've attached 2 wayland log files: the first (wayland_debug_with_bug) when Firefox is started and the bug appeared, and the second (wayland_debug_without_bug) when Firefox is started and the toolbar is displayed as expected.
Comment 14 Ben Cotton 2020-11-03 15:30:53 UTC 
This message is a reminder that Fedora 31 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora 31 on 2020-11-24.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
Fedora 'version' of '31'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 31 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.
Comment 15 Ben Cotton 2020-11-24 16:47:43 UTC 
Fedora 31 changed to end-of-life (EOL) status on 2020-11-24. Fedora 31 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.
Note You need to log in before you can comment on or make changes to this bug.