Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1743586 - Misplaced bookmark menus / screen fit
Summary: Misplaced bookmark menus / screen fit
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Fedora
Classification: Fedora
Component: firefox
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Martin Stransky
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: ffwayland
TreeView+ depends on / blocked
 
Reported: 2019-08-20 09:14 UTC by Vít Ondruch
Modified: 2019-09-10 08:29 UTC (History)
12 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-09-10 08:29:49 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)
Fulscreen missplaced menu (47.90 KB, image/png)
2019-08-20 09:15 UTC, Vít Ondruch 		no flags Details
Displaced menu (312.50 KB, image/png)
2019-08-20 09:16 UTC, Vít Ondruch 		no flags Details
Screenshot(fixed missplaced menus) (111.34 KB, image/png)
2019-09-09 16:19 UTC, Akarshan Biswas 		no flags Details
View All

Description Vít Ondruch 2019-08-20 09:14:17 UTC 
Description of problem:
FF does not show menus and especially submenus properly. E.g. the favourites menu is linked to the top of the window (see the attached SS), but the submenu is not visible at all.

Changing the FF window size helps to display the menu, but it is misplaced as well.

Version-Release number of selected component (if applicable):
$ rpm -q firefox
firefox-68.0.2-1.fc32.x86_64


How reproducible:
Always


Steps to Reproduce:
1.
2.
3.

Actual results:
Menus are misplaced.

Expected results:
Menus are correctly placed.


Additional info:
Comment 1 Vít Ondruch 2019-08-20 09:15:35 UTC 
Created attachment 1606025 [details]
Fulscreen missplaced menu

This displays fullscreen situation, where the submenu is not displayed at all (or it is off limits).
Comment 2 Vít Ondruch 2019-08-20 09:16:23 UTC 
Created attachment 1606027 [details]
Displaced menu

This illustrates the situation with normal window and misplaced menu.
Comment 3 Martin Stransky 2019-08-20 09:31:56 UTC 
Can you check if you see that also with mozilla nightly + wayland? How-to is here:
https://fedoraproject.org/wiki/How_to_debug_Firefox_problems#Testing_Mozilla_binaries

I'm going to backport missing wayland patches to FF69.
Comment 4 Akarshan Biswas 2019-09-05 15:36:52 UTC 
Hi. I can confirm that this issue if fixed in Firefox 69.
Comment 5 Vít Ondruch 2019-09-06 09:45:13 UTC 
It is still issue for me using firefox-69.0-1.fc32.x86_64. There seems to be -2 with some Wayland patches. Going to try ...
Comment 6 Vít Ondruch 2019-09-06 09:48:10 UTC 
Hm can't see any difference with firefox-69.0-2.fc32.x86_64 :(
Comment 7 Vít Ondruch 2019-09-09 10:49:31 UTC 
(In reply to Vít Ondruch from comment #6)
> Hm can't see any difference with firefox-69.0-2.fc32.x86_64 :(

Actually, the bookmark menu behaves a bit better, to the point that I can actually use it again. But it is far from correct. All the submenus appears to be misplaced by two rows, but this might be because the main bookmark menu si misplaced? It should pop down from the button, while it pops down from the top of the screen. So the SS in attachment 1606025 [details] still applies.
Comment 8 Vít Ondruch 2019-09-09 10:52:30 UTC 
Also, I suspect that the issue might exhibit itself just for long bookmark menus. The experience for short bookmark menu might be correct (but I have not tested it). AFAIR, it was possible to scroll in such long menus, but that his not possible now. I appears that FF does what it can to fit it the menu on the screen, but that is not really correct behavior.
Comment 9 Vít Ondruch 2019-09-09 10:57:34 UTC 
And it appears that context menus has similar issues 🙈
Comment 10 Martin Stransky 2019-09-09 11:36:31 UTC 
The menu is placed by mutter compositor as we use move_to_rect wayland compositor method to place the popup. It's also determined by screen size/menu size etc. I suppose for such small screens and large popups compositor just fails to find any placement. Can you try to compare it with X11 Firefox for instance?
Comment 11 Akarshan Biswas 2019-09-09 16:19:05 UTC 
Created attachment 1613265 [details]
Screenshot(fixed missplaced menus)

Running on Wayland, Gnome 3.30, Fedora 30. Menus appear in their respective places. I now use it as my daily driver on all of my machines.
Comment 12 Akarshan Biswas 2019-09-09 16:20:45 UTC 
*gnome 3.32.2
Comment 13 Vít Ondruch 2019-09-10 05:19:04 UTC 
(In reply to Akarshan Biswas from comment #11)
> Created attachment 1613265 [details]
> Screenshot(fixed missplaced menus)

Yes, I can confirm that the main hamburger menu is on its place (not sure if it wasn't previously) but that does not apply to bookmarks menu.
Comment 14 Martin Stransky 2019-09-10 08:27:56 UTC 
I think we should reduce popup menu size (add scrollbar) and place it at correct location. I think it's related do https://bugzilla.mozilla.org/show_bug.cgi?id=1565401
Comment 15 Martin Stransky 2019-09-10 08:29:49 UTC 
Moving upstream.
Note You need to log in before you can comment on or make changes to this bug.