Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1748527 - Consider moving sip-api provides from python2-sip to python3-sip
Summary: Consider moving sip-api provides from python2-sip to python3-sip
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: sip
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Rex Dieter
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PYTHONIS3
TreeView+ depends on / blocked
 
Reported: 2019-09-03 19:11 UTC by Kevin Fenzi
Modified: 2019-11-06 13:45 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-09-16 16:00:37 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Kevin Fenzi 2019-09-03 19:11:54 UTC
Right now python2-sip provides:

python2-sip = 4.19.18-5.fc32
python2-sip(x86-64) = 4.19.18-5.fc32
python2-sip-api(12) = 12.6
python2-sip-api(12)(x86-64) = 12.6
python2.7dist(sip) = 4.19.18
python2dist(sip) = 4.19.18
sip-api(12) = 12.6
sip-api(12)(x86-64) = 12.6

and python3-sip provides: 

python3-sip = 4.19.18-5.fc32
python3-sip(x86-64) = 4.19.18-5.fc32
python3-sip-api(12) = 12.6
python3-sip-api(12)(x86-64) = 12.6
python3.8dist(sip) = 4.19.18
python3dist(sip) = 4.19.18

This causes calibre to pull in python2-sip where all the rest of it is python3.
Looks like avogadro is also in this boat. 

Can we move the api provides over to the python3 package now?

Comment 1 Rex Dieter 2019-09-03 22:05:07 UTC
Consumers should probably move to the explicit python2-sip-api or python3-sip-api variants.  The sip-api one is kept for historical reasons only... I'd prefer to remove them rather than change it.

Comment 2 Rex Dieter 2019-09-03 22:12:29 UTC
I'll think on it some more... then work to implement that changes needed (I think it's a little more complicated)

Comment 3 Kevin Fenzi 2019-09-03 22:16:18 UTC
I can change calibre easily enough. 

diff --git a/calibre.spec b/calibre.spec                                                                     
index 1a5d7e2..9092935 100644                                                                                
--- a/calibre.spec                                                                                           
+++ b/calibre.spec                                                                                           
@@ -1,4 +1,4 @@                                                                                              
-%{?_sip_api:Requires: sip-api(%{_sip_api_major}) >= %{_sip_api}}                                            
+%{?_sip_api:Requires: python3-sip-api(%{_sip_api_major}) >= %{_sip_api}}                                    
                                                                                                             
 %global __provides_exclude_from ^%{_libdir}/calibre/calibre/plugins/.*\.so$                                                            
@@ -6,7 +6,7 @@                                                                                              
                                                                                                             
 Name:           calibre
 Version:        3.47.1
-Release:        1%{?dist}
+Release:        2%{?dist}
 Summary:        E-book converter and library manager
 License:        GPLv3
 URL:            https://calibre-ebook.com/
@@ -401,6 +401,9 @@ ln -s %{_jsdir}/mathjax %{_datadir}/calibre/viewer/
 %{_datadir}/metainfo/*.appdata.xml
  
 %changelog
+* Tue Sep 03 2019 Kevin Fenzi <kevin> - 3.47.1-2
+- Adjust sip requires to Require the python3-sip-api package.
+
 * Mon Sep 02 2019 Kevin Fenzi <kevin> - 3.47.1-1
 - Update 3.47.1. Fixes bug #1747848
  
I can push that for now, and we can adjust if you want to move the main sip-api?

Comment 4 Rex Dieter 2019-09-04 11:57:40 UTC
Thing is, I dont think that's the right fix.  You prob want sip-pyqt5 (or o e of it's provides)

Comment 5 Rex Dieter 2019-09-04 11:58:50 UTC
Arg, make that python3-sip-pyqt5

Comment 6 Kevin Fenzi 2019-09-15 23:04:11 UTC
Hum, I don't see anything providing that?

Comment 7 Rex Dieter 2019-09-16 13:13:24 UTC
https://src.fedoraproject.org/rpms/sip/blob/master/f/sip.spec#_157

is where it's at, committing change to calibre now

Comment 8 Rex Dieter 2019-09-16 13:24:30 UTC
calibre fixed:

https://src.fedoraproject.org/rpms/calibre/c/0a6632fccdbcc3949e3650d0beb2075e7d1c8ab6?branch=master


qgis fixed:

https://src.fedoraproject.org/rpms/qgis/c/858a2312dd642ba7511a11dceb1efca76ad59711?branch=master


Those are the last two (according to repoquery), so I think I can follow-through with the threat to remove the non-namespaced python-sip subpkgs (for f31+)

Comment 9 Rex Dieter 2019-09-16 14:04:43 UTC
 %changelog
+* Mon Sep 16 2019 Rex Dieter <rdieter> - 4.19.18-7
+- drop no_namespace variant for f31+

Comment 10 Miro Hrončok 2019-09-16 15:04:34 UTC
I just got this from koschei: nothing provides python3-sip needed by python3-arcus-4.1.0-3.fc32.x86_64

What should I require instead? I assume python3-pyqt5-sip.

Comment 11 Rex Dieter 2019-09-16 15:36:40 UTC
OK, I only repoquery'd for python3-sip-api , that's probably what python3-arcus should depend on.  I'll take a closer look.

Comment 12 Rex Dieter 2019-09-16 15:42:24 UTC
Arg, thouht this sounded familiar, seems upstream closed
https://github.com/Ultimaker/libArcus/issues/76
without actually changing/fixing anything. :(

So, our patch
libArcus-3.5.1-PyQt5.sip.patch

I *think* makes libarcus depend on namespaced python3-pyqt5-sip, I'll need to test that to confirm.

Comment 14 Victor Stinner 2019-09-17 08:25:56 UTC
> Those are the last two (according to repoquery), so I think I can follow-through with the threat to remove the non-namespaced python-sip subpkgs (for f31+)

enki package is also affected by this change: see rhbz#1752766.

Comment 15 Rex Dieter 2019-09-18 13:51:35 UTC
followup issues being tracked in bug #1753069

Comment 16 Fedora Update System 2019-10-25 18:38:08 UTC
FEDORA-2019-c919b2ffda has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-c919b2ffda

Comment 17 Fedora Update System 2019-10-27 04:02:23 UTC
libarcus-4.1.0-4.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-c919b2ffda

Comment 18 Fedora Update System 2019-11-01 17:01:21 UTC
FEDORA-2019-1dc2365f05 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-1dc2365f05

Comment 19 Fedora Update System 2019-11-03 06:01:40 UTC
libarcus-4.1.0-5.fc31, libsavitar-4.1.0-4.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-1dc2365f05

Comment 20 Fedora Update System 2019-11-06 13:45:10 UTC
libarcus-4.1.0-5.fc31, libsavitar-4.1.0-4.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.