Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 175279 - Review Request: gift-openft: Openft plugin for giFT
Summary: Review Request: gift-openft: Openft plugin for giFT
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Aurelien Bompard
QA Contact: David Lawrence
URL:
Whiteboard:
Depends On: 175276
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2005-12-08 14:56 UTC by Rex Dieter
Modified: 2007-11-30 22:11 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-01-03 14:59:14 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Rex Dieter 2005-12-08 14:56:40 UTC 
Spec Name or
Url:http://apt.kde-redhat.org/apt/kde-redhat/SPECS/gift-gnutella-0.0.10-1.spec
SRPM Name or Url:
http://apt.kde-redhat.org/apt/kde-redhat/all/SRPMS.stable/gift-gnutella-0.0.10-1.src.rpm
Description:  Openft plugin for giFT.
Comment 1 Aurelien Bompard 2005-12-17 17:27:02 UTC 
You probably mean
http://apt.kde-redhat.org/apt/kde-redhat/all/SRPMS.stable/gift-openft-0.2.1.6-1.src.rpm

Just one small problem:
"Requires: gift" is redundant, the package already depends on libgift.so.0 (you
should remove it in case you split the library out of the main package one day)
Comment 2 Rex Dieter 2005-12-19 12:48:59 UTC 
%changelog
* Mon Dec 19 2005 Rex Dieter <rexdieter[AT]users.sf.net. 0.2.1.6-2
- drop redundant Requires: gift

Spec Name or Url:
http://apt.kde-redhat.org/apt/kde-redhat/SPECS/gift-openft-0.2.1.6-2.spec
SRPM Name or Url:
http://apt.kde-redhat.org/apt/kde-redhat/all/SRPMS.stable/gift-openft-0.2.1.6-2.src.rpm
Comment 3 Aurelien Bompard 2005-12-20 13:57:13 UTC 
Review for release 2:
* RPM name is OK
* Source gift-openft-0.2.1.6.tar.bz2 is the same as upstream
* Builds fine in mock
* rpmlint of gift-openft looks OK
* File list of gift-openft looks OK
* Works
APPROVED
Note You need to log in before you can comment on or make changes to this bug.