Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 175281 - Review Request: perl-Tie-EncryptedHash
Summary: Review Request: perl-Tie-EncryptedHash
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jason Tibbitts
QA Contact: David Lawrence
URL: http://search.cpan.org/dist/Tie-Encry...
Whiteboard:
Depends On: 168580
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2005-12-08 15:01 UTC by Paul Howarth
Modified: 2009-03-13 03:06 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-02-08 07:55:54 UTC
Type: ---
Embargoed:
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Paul Howarth 2005-12-08 15:01:13 UTC
Spec Name or Url: http://www.city-fan.org/~paul/extras/perl-Tie-EncryptedHash/perl-Tie-EncryptedHash.spec
SRPM Name or Url: http://www.city-fan.org/~paul/extras/perl-Tie-EncryptedHash/perl-Tie-EncryptedHash-1.21-1.src.rpm
Description:

Tie::EncryptedHash augments Perl hash semantics to build secure, encrypting
containers of data. Tie::EncryptedHash introduces special hash fields that are
coupled with encrypt/decrypt routines to encrypt assignments at STORE() and
decrypt retrievals at FETCH(). By design, encrypting fields are associated with
keys that begin in single underscore. The remaining keyspace is used for
accessing normal hash fields, which are retained without modification.

While the password is set, a Tie::EncryptedHash behaves exactly like a standard
Perl hash. This is its transparent mode of access. Encrypting and normal fields
are identical in this mode. When password is deleted, encrypting fields are
accessible only as ciphertext. This is Tie::EncryptedHash's opaque mode of
access, optimized for serialization.

Encryption is done with Crypt::CBC(3), which encrypts in the cipher block
chaining mode with Blowfish, DES or IDEA. Tie::EncryptedHash uses Blowfish by
default, but can be instructed to employ any cipher supported by Crypt::CBC(3).

Comment 1 Jason Tibbitts 2006-02-07 21:41:16 UTC
perl-Crypt-DES isn't built on the FC-4 branch yet so I build it from CVS.

There's not really much to this package.  The shebang line at the top of the
module is odd; thanks for removing it.

Good stuff:
pmlint is completely silent.
Package meets naming and packaging guidelines.
Specfile is properly named, legible, and uses macros consistently.
BuildRequires: is proper.
License is acceptable and matches License: tag.
Source file md5sum matches upstream.
Package builds and installs on FC4 x86 and FC3 x86_64.

Odd stuff:
The tests spew a few (nine) warnings.  They don't seem to affect the outcome.

t/operations test takes fifteen seconds on FC3 x86_64 but seems to be
instantaneous on i386.  Everything does build and pass on x86_64 so I'm not sure
what the issue is.

I see no reason why either of these should be blockers.

Approved.

Comment 2 Paul Howarth 2006-02-08 07:55:54 UTC
Thanks for the review.

Build on target fedora-development-extras succeeded.

I'm not sure about the test issues either, but there don't seems to be any bugs
 on rt.cpan.org and this module release is getting on for 4 years old now, so I
reckon it's OK.

Comment 3 Paul Howarth 2009-03-11 10:30:57 UTC
Package Change Request
======================
Package Name: perl-Tie-EncryptedHash
New Branches: EL-4 EL-5
Owners: pghmcfc
InitialCC: perl-sig

Comment 4 Kevin Fenzi 2009-03-13 03:06:48 UTC
cvs done.


Note You need to log in before you can comment on or make changes to this bug.