Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 175282 - Review Request: apollon: Filesharing client
Summary: Review Request: apollon: Filesharing client
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Aurelien Bompard
QA Contact: David Lawrence
URL:
Whiteboard:
Depends On: 170602 175276
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2005-12-08 15:07 UTC by Rex Dieter
Modified: 2007-11-30 22:11 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-01-03 14:58:46 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Rex Dieter 2005-12-08 15:07:27 UTC 
Spec Name or
Url:http://apt.kde-redhat.org/apt/kde-redhat/SPECS/apollon-1.0.1-1.spec
SRPM Name or Url:
http://apt.kde-redhat.org/apt/kde-redhat/all/SRPMS.stable/apollon-1.0.1-1.src.rpm
Description:  A filesharing client which uses giFT.
Comment 1 Rex Dieter 2005-12-08 15:08:36 UTC 
See also previous livna review/comments: 
http://bugzilla.livna.org/show_bug.cgi?id=233
Comment 2 Aurelien Bompard 2005-12-17 22:41:40 UTC 
Needs work:
* The package should contain the text of the license
  (wiki: PackageReviewGuidelines)
* The package contains a libtool archive file
  (wiki: PackagingGuidelines#StaticLibraries)
  Apollon seems to work without it.
Comment 3 Rex Dieter 2005-12-19 12:51:38 UTC 
%changelog
* Mon Dec 19 2005 Rex Dieter <rexdieter[AT]users.sf.net> 1.0.1-2
- more %%doc's: AUTHORS ChangeLog COPYING TODO
- drop %%_libdir/lib*.la

Spec Name or Url:
http://apt.kde-redhat.org/apt/kde-redhat/SPECS/apollon-1.0.1-2.spec
SRPM Name or Url:
http://apt.kde-redhat.org/apt/kde-redhat/all/SRPMS.stable/apollon-1.0.1-2.src.rpm
Comment 4 Aurelien Bompard 2005-12-20 13:43:13 UTC 
missing BuildRequires: libacl-devel
Comment 5 Rex Dieter 2005-12-20 13:49:58 UTC 
libacl-devel shouldn't be necessary.  Or is this a manifestation of bug #170602
"Remove references to -lacl (and others) in .la files"?  (I assume you're seeing
this on fc4?  If so, I'll reopen the bug)
Comment 6 Aurelien Bompard 2005-12-20 14:02:33 UTC 
Yes, this is in an FC4 chroot via mock.
Comment 7 Rex Dieter 2005-12-20 14:16:13 UTC 
%changelog
* Tue Dec 20 2005 Rex Dieter <rexdieter[AT]users.sf.net> 1.0.1-3
- BR: libacl-devel (workaround kdelibs bug #170602)

Spec Name or Url:
http://apt.kde-redhat.org/apt/kde-redhat/SPECS/apollon-1.0.1-3.spec
SRPM Name or Url:
http://apt.kde-redhat.org/apt/kde-redhat/all/SRPMS.stable/apollon-1.0.1-3.src.rpm
Comment 8 Aurelien Bompard 2005-12-20 15:07:34 UTC 
Review for release 3:
* RPM name is OK
* Source apollon-1.0.1.tar.bz2 is the same as upstream
* This is the latest version
* Builds fine in mock
* rpmlint of apollon looks OK
* File list of apollon looks OK
* Works
APPROVED
Note You need to log in before you can comment on or make changes to this bug.